7a6c89427c
When sampleFDO is enabled, people may expect they can use -fno-profile-sample-use to opt-out using sample profile for a certain file. That could be either for debugging purpose or for performance tuning purpose. However, when thinlto is enabled, if a function in file A compiled with -fno-profile-sample-use is imported to another file B compiled with -fprofile-sample-use, the inlined copy of the function in file B may still get its profile annotated. The inconsistency may even introduce profile unused warning because if the target is not compiled with explicit debug information flag, the function in file A won't have its debug information enabled (debug information will be enabled implicitly only when -fprofile-sample-use is used). After it is imported into file B which is compiled with -fprofile-sample-use, profile annotation for the outline copy of the function will fail because the function has no debug information, and that will trigger profile unused warning. We add a new attribute use-sample-profile to control whether a function will use its sample profile no matter for its outline or inline copies. That will make the behavior of -fno-profile-sample-use consistent. Differential Revision: https://reviews.llvm.org/D79959
21 lines
962 B
C
21 lines
962 B
C
// Test use-sample-profile attribute is present only when SampleFDO
|
|
// is enabled.
|
|
//
|
|
// RUN: %clang_cc1 -O2 -fno-experimental-new-pass-manager \
|
|
// RUN: -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -emit-llvm -o - \
|
|
// RUN: 2>&1 | FileCheck %s
|
|
// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager \
|
|
// RUN: -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -emit-llvm -o - \
|
|
// RUN: 2>&1 | FileCheck %s
|
|
// RUN: %clang_cc1 -O2 -fno-experimental-new-pass-manager %s \
|
|
// RUN: -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=NOATTR
|
|
// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager %s -emit-llvm -o - \
|
|
// RUN: 2>&1 | FileCheck %s --check-prefix=NOATTR
|
|
|
|
// CHECK: define{{.*}} @func{{.*}} #[[ATTRID:[0-9]+]]
|
|
// CHECK: attributes #[[ATTRID]] = {{.*}} "use-sample-profile"
|
|
// NOATTR: define{{.*}} @func{{.*}} #[[ATTRID:[0-9]+]]
|
|
// NOATTR-NOT: attributes #[[ATTRID]] = {{.*}} "use-sample-profile"
|
|
|
|
int func(int a) { return a; }
|