eb10b065f2
Background: ----------- There are two related argument types which can be sent into a diagnostic to display the name of an entity: DeclarationName (ak_declarationname) or NamedDecl* (ak_nameddecl) (there is also ak_identifierinfo for IdentifierInfo*, but we are not concerned with it here). A DeclarationName in a diagnostic will just be streamed to the output, which will directly result in a call to DeclarationName::print. A NamedDecl* in a diagnostic will also ultimately result in a call to DeclarationName::print, but with two customisation points along the way: The first customisation point is NamedDecl::getNameForDiagnostic which is overloaded by FunctionDecl, ClassTemplateSpecializationDecl and VarTemplateSpecializationDecl to print the template arguments, if any. The second customisation point is NamedDecl::printName. By default it just streams the stored DeclarationName into the output but it can be customised to provide a user-friendly name for an entity. It is currently overloaded by DecompositionDecl and MSGuidDecl. What this patch does: --------------------- For many diagnostics a DeclarationName is used instead of the NamedDecl*. This bypasses the two customisation points mentioned above. This patches fix this for diagnostics in Sema.cpp, SemaCast.cpp, SemaChecking.cpp, SemaDecl.cpp, SemaDeclAttr.cpp, SemaDecl.cpp, SemaOverload.cpp and SemaStmt.cpp. I have only modified diagnostics where I could construct a test-case which demonstrates that the change is appropriate (either with this patch or the next one). Reviewed By: erichkeane, aaron.ballman Differential Revision: https://reviews.llvm.org/D84656
98 lines
3.8 KiB
C++
98 lines
3.8 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: %clang_cc1 -std=c++17 -fmodules -fimplicit-module-maps -x objective-c++ -fmodules-cache-path=%t -fmodule-name=module_private_left -emit-module %S/Inputs/module.map
|
|
// RUN: %clang_cc1 -std=c++17 -fmodules -fimplicit-module-maps -x objective-c++ -fmodules-cache-path=%t -fmodule-name=module_private_right -emit-module %S/Inputs/module.map
|
|
// RUN: %clang_cc1 -std=c++17 -fmodules -fimplicit-module-maps -x objective-c++ -fmodules-cache-path=%t -I %S/Inputs %s -verify
|
|
// FIXME: When we have a syntax for modules in C++, use that.
|
|
|
|
@import module_private_left;
|
|
@import module_private_right;
|
|
|
|
void test() {
|
|
int &ir = f0(1.0); // okay: f0() from 'right' is not visible
|
|
}
|
|
|
|
int test_broken() {
|
|
HiddenStruct hidden; // expected-error{{unknown type name 'HiddenStruct'}}
|
|
Integer i; // expected-error{{unknown type name 'Integer'}}
|
|
|
|
int *ip = 0;
|
|
f1(ip); // expected-error{{use of undeclared identifier 'f1'}}
|
|
|
|
vector<int> vec; // expected-error{{no template named 'vector'}}
|
|
|
|
VisibleStruct vs;
|
|
vs.field = 0; // expected-error{{no member named 'field' in 'VisibleStruct'}}
|
|
vs.setField(1); // expected-error{{no member named 'setField' in 'VisibleStruct'}}
|
|
|
|
return hidden_var; // expected-error{{use of undeclared identifier 'hidden_var'}}
|
|
}
|
|
|
|
// Check for private redeclarations of public entities.
|
|
template<typename T>
|
|
class public_class_template;
|
|
|
|
template<typename T>
|
|
__module_private__ class public_class_template;
|
|
|
|
|
|
typedef int public_typedef;
|
|
typedef __module_private__ int public_typedef;
|
|
|
|
extern int public_var;
|
|
extern __module_private__ int public_var;
|
|
|
|
void public_func();
|
|
__module_private__ void public_func();
|
|
|
|
template<typename T>
|
|
void public_func_template();
|
|
template<typename T>
|
|
__module_private__ void public_func_template();
|
|
|
|
struct public_struct;
|
|
__module_private__ struct public_struct;
|
|
|
|
// Check for attempts to make specializations private
|
|
template<> __module_private__ void public_func_template<int>(); // expected-error{{template specialization cannot be declared __module_private__}}
|
|
|
|
template<typename T>
|
|
struct public_class {
|
|
struct inner_struct;
|
|
static int static_var;
|
|
|
|
friend __module_private__ void public_func_friend();
|
|
friend __module_private__ struct public_struct_friend;
|
|
};
|
|
|
|
template<> __module_private__ struct public_class<int>::inner_struct { }; // expected-error{{member specialization cannot be declared __module_private__}}
|
|
template<> __module_private__ int public_class<int>::static_var = 17; // expected-error{{member specialization cannot be declared __module_private__}}
|
|
|
|
template<>
|
|
__module_private__ struct public_class<float> { }; // expected-error{{template specialization cannot be declared __module_private__}}
|
|
|
|
template<typename T>
|
|
__module_private__ struct public_class<T *> { }; // expected-error{{partial specialization cannot be declared __module_private__}}
|
|
|
|
// Check for attempts to make parameters and variables with automatic
|
|
// storage module-private.
|
|
|
|
void local_var_private(__module_private__ int param) { // expected-error{{parameter 'param' cannot be declared __module_private__}}
|
|
__module_private__ struct Local { int x, y; } local; //expected-error{{local variable 'local' cannot be declared __module_private__}}
|
|
|
|
__module_private__ auto [x, y] = local; // expected-error {{local variable '[x, y]' cannot be declared __module_private__}}
|
|
|
|
__module_private__ struct OtherLocal { int x; }; // expected-error{{local struct cannot be declared __module_private__}}
|
|
|
|
typedef __module_private__ int local_typedef; // expected-error{{typedef 'local_typedef' cannot be declared __module_private__}}
|
|
}
|
|
|
|
void param_private(__module_private__ int) {} // expected-error {{parameter '' cannot be declared __module_private}}
|
|
|
|
// Check struct size
|
|
struct LikeVisibleStruct {
|
|
int field;
|
|
virtual void setField(int f);
|
|
};
|
|
|
|
int check_struct_size[sizeof(VisibleStruct) == sizeof(LikeVisibleStruct)? 1 : -1];
|