956cf0e5de
Initialization of reduction variable for min-reduction is set to largest negative value. As such, in presence of non-negative operands, min reduction gives incorrect output. This patch initialises min-reduction to use the maximum positive value instead, so that it can produce correct output for the entire range of real valued operands. Fixes https://github.com/llvm/llvm-project/issues/73101
77 lines
2.6 KiB
Fortran
77 lines
2.6 KiB
Fortran
! RUN: bbc -emit-fir -hlfir=false -fopenmp -o - %s 2>&1 | FileCheck %s
|
|
! RUN: %flang_fc1 -emit-fir -flang-deprecated-no-hlfir -fopenmp -o - %s 2>&1 | FileCheck %s
|
|
|
|
!CHECK: omp.reduction.declare @[[MIN_DECLARE_F:.*]] : f32 init {
|
|
!CHECK: %[[MAXIMUM_VAL_F:.*]] = arith.constant 3.40282347E+38 : f32
|
|
!CHECK: omp.yield(%[[MAXIMUM_VAL_F]] : f32)
|
|
!CHECK: combiner
|
|
!CHECK: ^bb0(%[[ARG0_F:.*]]: f32, %[[ARG1_F:.*]]: f32):
|
|
!CHECK: %[[COMB_VAL_F:.*]] = arith.minimumf %[[ARG0_F]], %[[ARG1_F]] {{.*}}: f32
|
|
!CHECK: omp.yield(%[[COMB_VAL_F]] : f32)
|
|
|
|
!CHECK: omp.reduction.declare @[[MIN_DECLARE_I:.*]] : i32 init {
|
|
!CHECK: %[[MAXIMUM_VAL_I:.*]] = arith.constant 2147483647 : i32
|
|
!CHECK: omp.yield(%[[MAXIMUM_VAL_I]] : i32)
|
|
!CHECK: combiner
|
|
!CHECK: ^bb0(%[[ARG0_I:.*]]: i32, %[[ARG1_I:.*]]: i32):
|
|
!CHECK: %[[COMB_VAL_I:.*]] = arith.minsi %[[ARG0_I]], %[[ARG1_I]] : i32
|
|
!CHECK: omp.yield(%[[COMB_VAL_I]] : i32)
|
|
|
|
!CHECK-LABEL: @_QPreduction_min_int
|
|
!CHECK-SAME: %[[Y_BOX:.*]]: !fir.box<!fir.array<?xi32>>
|
|
!CHECK: %[[X_REF:.*]] = fir.alloca i32 {bindc_name = "x", uniq_name = "_QFreduction_min_intEx"}
|
|
!CHECK: omp.parallel
|
|
!CHECK: omp.wsloop reduction(@[[MIN_DECLARE_I]] -> %[[X_REF]] : !fir.ref<i32>) for
|
|
!CHECK: %[[Y_I_REF:.*]] = fir.coordinate_of %[[Y_BOX]]
|
|
!CHECK: %[[Y_I:.*]] = fir.load %[[Y_I_REF]] : !fir.ref<i32>
|
|
!CHECK: omp.reduction %[[Y_I]], %[[X_REF]] : i32, !fir.ref<i32>
|
|
!CHECK: omp.yield
|
|
!CHECK: omp.terminator
|
|
|
|
!CHECK-LABEL: @_QPreduction_min_real
|
|
!CHECK-SAME: %[[Y_BOX:.*]]: !fir.box<!fir.array<?xf32>>
|
|
!CHECK: %[[X_REF:.*]] = fir.alloca f32 {bindc_name = "x", uniq_name = "_QFreduction_min_realEx"}
|
|
!CHECK: omp.parallel
|
|
!CHECK: omp.wsloop reduction(@[[MIN_DECLARE_F]] -> %[[X_REF]] : !fir.ref<f32>) for
|
|
!CHECK: %[[Y_I_REF:.*]] = fir.coordinate_of %[[Y_BOX]]
|
|
!CHECK: %[[Y_I:.*]] = fir.load %[[Y_I_REF]] : !fir.ref<f32>
|
|
!CHECK: omp.reduction %[[Y_I]], %[[X_REF]] : f32, !fir.ref<f32>
|
|
!CHECK: omp.yield
|
|
!CHECK: omp.terminator
|
|
|
|
subroutine reduction_min_int(y)
|
|
integer :: x, y(:)
|
|
x = 0
|
|
!$omp parallel
|
|
!$omp do reduction(min:x)
|
|
do i=1, 100
|
|
x = min(x, y(i))
|
|
end do
|
|
!$omp end do
|
|
!$omp end parallel
|
|
print *, x
|
|
end subroutine
|
|
|
|
subroutine reduction_min_real(y)
|
|
real :: x, y(:)
|
|
x = 0.0
|
|
!$omp parallel
|
|
!$omp do reduction(min:x)
|
|
do i=1, 100
|
|
x = min(y(i), x)
|
|
end do
|
|
!$omp end do
|
|
!$omp end parallel
|
|
print *, x
|
|
|
|
!$omp parallel
|
|
!$omp do reduction(min:x)
|
|
do i=1, 100
|
|
!CHECK-NOT: omp.reduction
|
|
if (y(i) .gt. x) x = y(i)
|
|
end do
|
|
!$omp end do
|
|
!$omp end parallel
|
|
print *, x
|
|
end subroutine
|