ab1c259613
R_RISCV_CALL/R_RISCV_CALL_PLT distinction isn't necessary. R_RISCV_CALL has been deprecated as a resolution to https://github.com/riscv-non-isa/riscv-elf-psabi-doc/issues/98 . ld.lld and mold treat the two relocation types the same. GNU ld has a custom handling for undefined weak functions which is unnecessary: calling an unresolved undefined weak function is UB and GNU ld can handle the case without a relocation error (such a function call is usually guarded by a zero value check and should be allowed). This patch assembles `call foo` to use R_RISCV_CALL_PLT instead of the deprecated R_RISCV_CALL. Note: the code generator still differentiates `call foo` and (maybe preemptible) `call foo@plt`, but the difference is purely aesthetic. Note: D105429 does not support R_RISCV_CALL_PLT correctly. Changed the test to force R_RISCV_CALL for now. Reviewed By: kito-cheng Differential Revision: https://reviews.llvm.org/D132530
68 lines
1.9 KiB
ArmAsm
68 lines
1.9 KiB
ArmAsm
# RUN: llvm-mc -filetype=obj -triple riscv32 < %s \
|
|
# RUN: | llvm-objdump -d - | FileCheck --check-prefix=INSTR %s
|
|
# RUN: llvm-mc -filetype=obj -triple riscv32 < %s \
|
|
# RUN: | llvm-readobj -r - | FileCheck -check-prefix=RELOC %s
|
|
# RUN: llvm-mc -triple riscv32 < %s -show-encoding \
|
|
# RUN: | FileCheck -check-prefix=FIXUP %s
|
|
|
|
.long foo
|
|
|
|
call foo
|
|
# RELOC: R_RISCV_CALL_PLT foo 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: foo, kind: fixup_riscv_call
|
|
call bar
|
|
# RELOC: R_RISCV_CALL_PLT bar 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: bar, kind: fixup_riscv_call
|
|
|
|
# Ensure that calls to functions whose names coincide with register names work.
|
|
|
|
call zero
|
|
# RELOC: R_RISCV_CALL_PLT zero 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: zero, kind: fixup_riscv_call
|
|
|
|
call f1
|
|
# RELOC: R_RISCV_CALL_PLT f1 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: f1, kind: fixup_riscv_call
|
|
|
|
call ra
|
|
# RELOC: R_RISCV_CALL_PLT ra 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: ra, kind: fixup_riscv_call
|
|
|
|
call mstatus
|
|
# RELOC: R_RISCV_CALL_PLT mstatus 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: mstatus, kind: fixup_riscv_call
|
|
|
|
# Ensure that calls to procedure linkage table symbols work.
|
|
|
|
call foo@plt
|
|
# RELOC: R_RISCV_CALL_PLT foo 0x0
|
|
# INSTR: auipc ra, 0
|
|
# INSTR: jalr ra
|
|
# FIXUP: fixup A - offset: 0, value: foo@plt, kind: fixup_riscv_call_plt
|
|
|
|
# Ensure that an explicit register operand can be parsed.
|
|
|
|
call a0, foo
|
|
# RELOC: R_RISCV_CALL_PLT foo 0x0
|
|
# INSTR: auipc a0, 0
|
|
# INSTR: jalr a0
|
|
# FIXUP: fixup A - offset: 0, value: foo, kind: fixup_riscv_call
|
|
|
|
call a0, foo@plt
|
|
# RELOC: R_RISCV_CALL_PLT foo 0x0
|
|
# INSTR: auipc a0, 0
|
|
# INSTR: jalr a0
|
|
# FIXUP: fixup A - offset: 0, value: foo@plt, kind: fixup_riscv_call_plt
|