1ada819c23
This enables odr indicators on all platforms and private aliases on non-Windows. Note that GCC also uses private aliases: this fixes bogus `The following global variable is not properly aligned.` errors for interposed global variables Fix https://github.com/google/sanitizers/issues/398 Fix https://github.com/google/sanitizers/issues/1017 Fix https://github.com/llvm/llvm-project/issues/36893 (we can restore D46665) Global variables of non-hasExactDefinition() linkages (i.e. linkonce/linkonce_odr/weak/weak_odr/common/external_weak) are not instrumented. If an instrumented variable gets interposed to an uninstrumented variable due to symbol interposition (e.g. in issue 36893, _ZTS1A in foo.so is resolved to _ZTS1A in the executable), there may be a bogus error. With private aliases, the register code will not resolve to a definition in another module, and thus prevent the issue. Cons: minor size increase. This is mainly due to extra `__odr_asan_gen_*` symbols. (ELF) In addition, in relocatable files private aliases replace some relocations referencing global symbols with .L symbols and may introduce some STT_SECTION symbols. For lld, with -g0, the size increase is 0.07~0.09% for many configurations I have tested: -O0, -O1, -O2, -O3, -O2 -ffunction-sections -fdata-sections -Wl,--gc-sections. With -g1 or above, the size increase ratio will be even smaller. This patch obsoletes D92078. Don't migrate Windows for now: the static data member of a specialization `std::num_put<char>::id` is a weak symbol, as well as its ODR indicator. Unfortunately, link.exe (and lld without -lldmingw) generally doesn't support duplicate weak definitions (weak symbols in different TUs likely pick different defined external symbols and conflict). Differential Revision: https://reviews.llvm.org/D137227
73 lines
3.8 KiB
C++
73 lines
3.8 KiB
C++
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
|
|
// XFAIL: android
|
|
// Fails with debug checks: https://bugs.llvm.org/show_bug.cgi?id=46862
|
|
// XFAIL: !compiler-rt-optimized && !riscv64
|
|
//
|
|
// We use fast_unwind_on_malloc=0 to have full unwinding even w/o frame
|
|
// pointers. This setting is not on by default because it's too expensive.
|
|
//
|
|
// Note, -asan-use-private-alias=1 -asan-use-odr-indicator=1 is the default.
|
|
// -fno-sanitize-address-use-odr-indicator turns off both.
|
|
//
|
|
// Different size: detect a bug if detect_odr_violation>=1
|
|
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -fno-sanitize-address-use-odr-indicator %s -o %dynamiclib
|
|
// RUN: %clangxx_asan -g -fno-sanitize-address-use-odr-indicator %s %ld_flags_rpath_exe -o %t-ODR-EXE
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=1 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=0 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
//
|
|
// Same size: report a bug only if detect_odr_violation>=2.
|
|
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -fno-sanitize-address-use-odr-indicator %s -o %dynamiclib -DSZ=100
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=1 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
// RUN: echo "odr_violation:foo::ZZZ" > %t.supp
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2:suppressions=%t.supp not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
// RUN: echo "odr_violation:foo::G" > %t.supp
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2:suppressions=%t.supp %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
|
|
// RUN: rm -f %t.supp
|
|
//
|
|
// Use private aliases for global variables without indicator symbol.
|
|
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-odr-indicator=0 %s -o %dynamiclib -DSZ=100
|
|
// RUN: %clangxx_asan -g -mllvm -asan-use-odr-indicator=0 %s %ld_flags_rpath_exe -o %t-ODR-EXE
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
|
|
|
|
// Use private aliases for global variables: use indicator symbol to detect ODR violation.
|
|
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared %s -o %dynamiclib -DSZ=100
|
|
// RUN: %clangxx_asan -g %s %ld_flags_rpath_exe -o %t-ODR-EXE
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
|
|
// Same as above but with clang switches.
|
|
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -fsanitize-address-use-odr-indicator %s -o %dynamiclib -DSZ=100
|
|
// RUN: %clangxx_asan -g -fsanitize-address-use-odr-indicator %s %ld_flags_rpath_exe -o %t-ODR-EXE
|
|
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
|
|
|
|
// GNU driver doesn't handle .so files properly.
|
|
// REQUIRES: Clang
|
|
|
|
// REQUIRES: fast-unwinder-works
|
|
|
|
#ifndef SZ
|
|
# define SZ 4
|
|
#endif
|
|
|
|
#if BUILD_SO
|
|
namespace foo { char G[SZ]; }
|
|
#else
|
|
#include <stdio.h>
|
|
namespace foo { char G[100]; }
|
|
// CHECK: ERROR: AddressSanitizer: odr-violation
|
|
// CHECK: size=100 'foo::G' {{.*}}odr-violation.cpp:[[@LINE-2]]
|
|
// CHECK: size={{4|100}} 'foo::G'
|
|
int main(int argc, char **argv) {
|
|
printf("PASS: %p\n", &foo::G);
|
|
}
|
|
#endif
|
|
|
|
// CHECK: These globals were registered at these points:
|
|
// CHECK: {{odr-violation.cpp|ODR-EXE}}
|
|
// CHECK: odr-violation.cpp{{$}}
|
|
// CHECK: SUMMARY: AddressSanitizer: odr-violation: global 'foo::G' at {{.*}}odr-violation.cpp
|
|
// DISABLED: PASS
|