d1cce66469
…uses The Flang implemenation of OpenACC uses a .td file in the llvm/Frontend directory to determine appertainment in 4 categories: -Required: If this list has items in it, the directive requires at least 1 of these be present. -AllowedExclusive: Items on this list are all allowed, but only 1 from the list may be here (That is, they are exclusive of eachother). -AllowedOnce: Items on this list are all allowed, but may not be duplicated. Allowed: Items on this list are allowed. Note th at the actual list of 'allowed' is all 4 of these lists together. This is a draft patch to swtich Clang over to use those tables. Surgery to get this to happen in Clang Sema was somewhat reasonable. However, some gaps in the implementations are obvious, the existing clang implementation disagrees with the Flang interpretation of it. SO, we're keeping a task list here based on what gets discovered. Changes to Clang: - [x] Switch 'directive-kind' enum conversions to use tablegen See ff1a7bddd9435b6ae2890c07eae60bb07898bbf5 - [x] Switch 'clause-kind' enum conversions to use tablegen See ff1a7bddd9435b6ae2890c07eae60bb07898bbf5 - [x] Investigate 'parse' test differences to see if any new disagreements arise. - [x] Clang/Flang disagree as to whether 'collapse' can be multiple times on a loop. Further research showed no prose to limit this, and the comment on the clang implementation said "no good reason to allow", so no standards justification. - [x] Clang/Flang disagree whether 'num_gangs' can appear >1 on a compute/combined construct. This ended up being an unjustified restriction. - [x] Clang/Flang disagree as to the list of required clauses on a 'set' construct. My research shows that Clang mistakenly included 'if' in the list, and that it should be just 'default_async', 'device_num', and 'device_type'. - [x] Order of 'at least one of' diagnostic has changed. Tests were updated. - [x] Ensure we are properly 'de-aliasing' clause names in appertainment checks? - [x] What is 'shortloop'? 'shortloop' seems to be an old non-standard extension that isn't supported by flang, but is parsed for backward compat reasons. Clang won't parse, but we at least have a spot for it in the clause list. - [x] Implemented proposed change for 'routine' gang/worker/vector/seq. (see issue 539) - [x] Implement init/shutdown can only have 1 'if' (see issue 540) - [x] Clang/Flang disagree as to whether 'tile' is permitted more than once on a 'loop' or combined constructs (Flang prohibits >1). I see no justification for this in the standard. EDIT: I found a comment in clang that I did this to make SOMETHING around duplicate checks easier. Discussion showed we should actually have a better behavior around 'device_type' and duplicates, so I've since implemented that. - [x] Clang/Flang disagree whether 'gang', 'worker', or 'vector' may appear on the same construct as a 'seq' on a 'loop' or 'combined'. There is prose for this in 2022: (a gang, worker, or vector clause may not appear if a 'seq' clause appears). EDIT: These don't actually disagree, but aren't in the .td file, so I restored the existing code to do this. - [x] Clang/Flang disagree on whether 'bind' can appear >1 on a 'routine'. I believe line 3096 (A bind clause may not bind to a routine name that has a visible bind clause) makes this limitation (Flang permits >1 bind). we discussed and decided this should have the same rules as worker/vector/etc, except without the 'exactly 1 of' rule (so no dupes in individual sections). - [x] Clang/Flang disagree on whether 'init'/'shutdown' can have multiple 'device_num' clauses. I believe there is no supporting prose for this limitation., We decided that `device_num` should only happen 1x. - [x] Clang/Flang disagree whether 'num_gangs' can appear >1 on a 'kernels' construct. Line 1173 (On a kernels construct, the num_gangs clause must have a single argument) justifies limiting on a per-arguement basis, but doesn't do so for multiple num_gangs clauses. WE decided to do this with the '1-per-device-type' region for num_gangs, num_workers, and vector_length, see openacc bug here: https://github.com/OpenACC/openacc-spec/issues/541 Changes to Flang: - [x] Clang/Flang disgree on whether 'atomic' can take an 'if' clause. This was added in OpenACC3.3_Next See #135451 - [x] Clang/Flang disagree on whether 'finalize' can be allowed >1 times on a 'exit_data' construct. see #135415. - [x] Clang/Flang disagree whether 'if_present' should be allowed >1 times on a 'host_data'/'update' construct. see #135422 - [x] Clang/Flang disagree on whether 'init'/'shutdown' can have multiple 'device_type' clauses. I believe there is no supporting prose for this limitation. - [ ] SEE change for num_gangs/etc above. Changes that need discussion/research:
181 lines
6.7 KiB
C
181 lines
6.7 KiB
C
// RUN: %clang_cc1 %s -verify -fopenacc
|
|
|
|
void func() {
|
|
|
|
// expected-error@+1{{expected OpenACC directive}}
|
|
#pragma acc
|
|
for(;;){}
|
|
|
|
// expected-error@+2{{expected OpenACC directive}}
|
|
// expected-error@+1{{invalid OpenACC clause 'whatever'}}
|
|
#pragma acc(whatever) routine
|
|
|
|
// expected-error@+2{{expected OpenACC directive}}
|
|
// expected-error@+1{{invalid OpenACC clause 'routine'}}
|
|
#pragma acc) routine
|
|
|
|
// expected-error@+1{{invalid OpenACC directive 'invalid'}}
|
|
#pragma acc invalid
|
|
for(;;){}
|
|
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc parallel clause list
|
|
for(;;){}
|
|
// expected-error@+2{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc parallel() clause list
|
|
for(;;){}
|
|
// expected-error@+3{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+2{{expected ')'}}
|
|
// expected-note@+1{{to match this '('}}
|
|
#pragma acc parallel( clause list
|
|
for(;;){}
|
|
// expected-error@+2{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc parallel() clause list
|
|
for(;;){}
|
|
// expected-error@+3{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+2{{expected ')'}}
|
|
// expected-note@+1{{to match this '('}}
|
|
#pragma acc parallel( clause list
|
|
for(;;){}
|
|
// expected-error@+2{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc serial() clause list
|
|
for(;;){}
|
|
// expected-error@+3{{expected clause-list or newline in OpenACC directive}}
|
|
// expected-error@+2{{expected ')'}}
|
|
// expected-note@+1{{to match this '('}}
|
|
#pragma acc serial( clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc serial clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc kernels clause list
|
|
for(;;){}
|
|
// expected-error@+2{{OpenACC 'data' construct must have at least one 'attach', 'copy', 'copyin', 'copyout', 'create', 'default', 'deviceptr', 'no_create', or 'present' clause}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc data clause list
|
|
for(;;){}
|
|
// expected-error@+2{{OpenACC 'enter data' construct must have at least one 'attach', 'copyin', or 'create' clause}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc enter data clause list
|
|
for(;;){}
|
|
// expected-error@+2{{OpenACC 'exit data' construct must have at least one 'copyout', 'delete', or 'detach' clause}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc exit data clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC directive 'enter invalid'}}
|
|
#pragma acc enter invalid
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC directive 'exit invalid'}}
|
|
#pragma acc exit invalid
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC directive 'enter'}}
|
|
#pragma acc enter
|
|
for(;;){}
|
|
// expected-error@+1{{expected identifier}}
|
|
#pragma acc exit }
|
|
for(;;){}
|
|
// expected-error@+2{{OpenACC 'host_data' construct must have at least one 'use_device' clause}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc host_data clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc loop clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
// expected-error@+1{{invalid OpenACC clause 'invalid'}}
|
|
#pragma acc parallel invalid clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
// expected-error@+1{{invalid OpenACC clause 'invalid'}}
|
|
#pragma acc serial invalid clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc parallel loop clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
|
|
#pragma acc parallel loop
|
|
for(int i = 0; i < 6;++i){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc serial loop clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
#pragma acc serial loop
|
|
for(int i = 0; i < 6;++i){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc kernels loop clause list
|
|
for(int i = 0; i < 6;++i){}
|
|
#pragma acc kernels loop
|
|
for(int i = 0; i < 6;++i){}
|
|
|
|
int i = 0, j = 0, k = 0;
|
|
#pragma acc atomic
|
|
i = i + 1;
|
|
// expected-error@+1{{invalid OpenACC clause 'garbage'}}
|
|
#pragma acc atomic garbage
|
|
i = i + 1;
|
|
// expected-error@+1{{invalid OpenACC clause 'garbage'}}
|
|
#pragma acc atomic garbage clause list
|
|
i = i + 1;
|
|
#pragma acc atomic read
|
|
i = j;
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc atomic write clause list
|
|
i = i + j;
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc atomic update clause list
|
|
i++;
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc atomic capture clause list
|
|
i = j++;
|
|
|
|
|
|
// expected-error@+2{{invalid OpenACC clause 'clause'}}
|
|
// expected-error@+1{{no valid clauses specified in OpenACC 'declare' directive}}
|
|
#pragma acc declare clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc init clause list
|
|
for(;;){}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc shutdown clause list
|
|
for(;;){}
|
|
// expected-error@+2{{invalid OpenACC clause 'clause'}}
|
|
// expected-error@+1{{OpenACC 'set' construct must have at least one 'default_async', 'device_num', or 'device_type' clause}}
|
|
#pragma acc set clause list
|
|
for(;;){}
|
|
// expected-error@+2{{OpenACC 'update' construct must have at least one 'device', 'host', or 'self' clause}}
|
|
// expected-error@+1{{invalid OpenACC clause 'clause'}}
|
|
#pragma acc update clause list
|
|
for(;;){}
|
|
}
|
|
|
|
#pragma acc routine seq
|
|
void routine_func();
|
|
// expected-error@+2{{invalid OpenACC clause 'clause'}}
|
|
// expected-error@+1{{OpenACC 'routine' construct must have at least one 'gang', 'seq', 'vector', or 'worker' clause}}
|
|
#pragma acc routine clause list
|
|
void routine_func();
|
|
|
|
// expected-error@+1{{use of undeclared identifier 'func_name'}}
|
|
#pragma acc routine (func_name) seq
|
|
// expected-error@+3{{use of undeclared identifier 'func_name'}}
|
|
// expected-error@+2{{invalid OpenACC clause 'clause'}}
|
|
// expected-error@+1{{OpenACC 'routine' construct must have at least one 'gang', 'seq', 'vector', or 'worker' clause}}
|
|
#pragma acc routine (func_name) clause list
|
|
|
|
#pragma acc routine (routine_func) seq
|
|
// expected-error@+2{{invalid OpenACC clause 'clause'}}
|
|
// expected-error@+1{{OpenACC 'routine' construct must have at least one 'gang', 'seq', 'vector', or 'worker' clause}}
|
|
#pragma acc routine (routine_func) clause list
|
|
|
|
// expected-error@+2{{expected ')'}}
|
|
// expected-note@+1{{to match this '('}}
|
|
#pragma acc routine (routine_func()) seq
|
|
|
|
// expected-error@+1{{expected identifier}}
|
|
#pragma acc routine() seq
|
|
|
|
// expected-error@+1{{expected identifier}}
|
|
#pragma acc routine(int) seq
|