
This removes the delayed typo correction functionality from Clang (regular typo correction still remains) due to fragility of the solution. An RFC was posted here: https://discourse.llvm.org/t/rfc-removing-support-for-delayed-typo-correction/86631 and while that RFC was asking for folks to consider stepping up to be maintainers, and we did have a few new contributors show some interest, experiments show that it's likely worth it to remove this functionality entirely and focus efforts on improving regular typo correction. This removal fixes ~20 open issues (quite possibly more), improves compile time performance by roughly .3-.4% (https://llvm-compile-time-tracker.com/?config=Overview&stat=instructions%3Au&remote=AaronBallman&sortBy=date), and does not appear to regress diagnostic behavior in a way we wouldn't find acceptable. Fixes #142457 Fixes #139913 Fixes #138850 Fixes #137867 Fixes #137860 Fixes #107840 Fixes #93308 Fixes #69470 Fixes #59391 Fixes #58172 Fixes #46215 Fixes #45915 Fixes #45891 Fixes #44490 Fixes #36703 Fixes #32903 Fixes #23312 Fixes #69874
61 lines
2.0 KiB
C++
61 lines
2.0 KiB
C++
// RUN: %clang_cc1 %s -verify -fopenacc
|
|
|
|
namespace NS {
|
|
void foo(); // expected-note{{declared here}}
|
|
|
|
template<typename T>
|
|
void templ(); // expected-note 2{{declared here}}
|
|
|
|
class C { // #CDef
|
|
void private_mem_func(); // #PrivateMemFunc
|
|
public:
|
|
void public_mem_func();
|
|
};
|
|
}
|
|
|
|
// expected-error@+1{{use of undeclared identifier 'foo'; did you mean 'NS::foo'?}}
|
|
#pragma acc routine(foo) seq
|
|
#pragma acc routine(NS::foo) seq
|
|
|
|
// expected-error@+2{{use of undeclared identifier 'templ'; did you mean 'NS::templ'?}}
|
|
// expected-error@+1{{OpenACC routine name 'templ' names a set of overloads}}
|
|
#pragma acc routine(templ) seq
|
|
// expected-error@+1{{OpenACC routine name 'NS::templ' names a set of overloads}}
|
|
#pragma acc routine(NS::templ) seq
|
|
|
|
// expected-error@+2{{use of undeclared identifier 'templ'; did you mean 'NS::templ'?}}
|
|
// expected-error@+1{{OpenACC routine name 'templ<int>' names a set of overloads}}
|
|
#pragma acc routine(templ<int>) seq
|
|
// expected-error@+1{{OpenACC routine name 'NS::templ<int>' names a set of overloads}}
|
|
#pragma acc routine(NS::templ<int>) seq
|
|
|
|
// expected-error@+1{{use of undeclared identifier 'T'}}
|
|
#pragma acc routine(templ<T>) seq
|
|
// expected-error@+1{{use of undeclared identifier 'T'}}
|
|
#pragma acc routine(NS::templ<T>) seq
|
|
|
|
// expected-error@+2{{expected ')'}}
|
|
// expected-note@+1{{to match this '('}}
|
|
#pragma acc routine (NS::foo()) seq
|
|
|
|
// expected-error@+1 {{expected unqualified-id}}
|
|
#pragma acc routine() seq
|
|
|
|
// expected-error@+1 {{expected unqualified-id}}
|
|
#pragma acc routine(int) seq
|
|
|
|
// expected-error@+2{{'C' does not refer to a value}}
|
|
// expected-note@#CDef{{declared here}}
|
|
#pragma acc routine (NS::C) seq
|
|
// expected-error@+2{{'private_mem_func' is a private member of 'NS::C'}}
|
|
// expected-note@#PrivateMemFunc{{implicitly declared private here}}
|
|
#pragma acc routine (NS::C::private_mem_func) seq
|
|
#pragma acc routine (NS::C::public_mem_func) seq
|
|
|
|
void foo() {
|
|
auto x = [](){};
|
|
#pragma acc routine seq
|
|
auto y = [](){};
|
|
#pragma acc routine (x) seq
|
|
}
|