244e1d7d0f
with at least one subtle bug in MacOSXKeyChainAPIChecker where the calling the method was a substitute for assuming a symbolic value was null (which is not the case). We still keep ConstraintManager::getSymVal(), but we use that as an optimization in SValBuilder and ProgramState::getSVal() to constant-fold SVals. This is only if the ConstraintManager can provide us with that information, which is no longer a requirement. As part of this, introduce a default implementation of ConstraintManager::getSymVal() which returns null. For Checkers, introduce ConstraintManager::isNull(), which queries the state to see if the symbolic value is constrained to be a null value. It does this without assuming it has been implicitly constant folded. llvm-svn: 163428
47 lines
1.8 KiB
C++
47 lines
1.8 KiB
C++
//== ConstraintManager.cpp - Constraints on symbolic values -----*- C++ -*--==//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defined the interface to manage constraints on symbolic values.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
|
|
#include "llvm/Support/SaveAndRestore.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
ConstraintManager::~ConstraintManager() {}
|
|
|
|
static DefinedSVal getLocFromSymbol(const ProgramStateRef &State,
|
|
SymbolRef Sym) {
|
|
const MemRegion *R = State->getStateManager().getRegionManager()
|
|
.getSymbolicRegion(Sym);
|
|
return loc::MemRegionVal(R);
|
|
}
|
|
|
|
/// Convenience method to query the state to see if a symbol is null or
|
|
/// not null, or neither assumption can be made.
|
|
ConditionTruthVal ConstraintManager::isNull(ProgramStateRef State,
|
|
SymbolRef Sym) {
|
|
// Disable recursive notification of clients.
|
|
llvm::SaveAndRestore<bool> DisableNotify(NotifyAssumeClients, false);
|
|
|
|
ProgramStateManager &Mgr = State->getStateManager();
|
|
QualType Ty = Sym->getType(Mgr.getContext());
|
|
DefinedSVal V = Loc::isLocType(Ty) ? getLocFromSymbol(State, Sym)
|
|
: nonloc::SymbolVal(Sym);
|
|
const ProgramStatePair &P = assumeDual(State, V);
|
|
if (P.first && !P.second)
|
|
return ConditionTruthVal(false);
|
|
if (!P.first && P.second)
|
|
return ConditionTruthVal(true);
|
|
return ConditionTruthVal();
|
|
}
|