28413dd87a
Summary: Looks at conditionals and finds cases of ``cast<>``, which will assert rather than return a null pointer, and ``dyn_cast<>`` where the return value is not captured. Additionally, finds cases that match the pattern ``var.foo() && isa<X>(var.foo())``, where the method is called twice and could be expensive. .. code-block:: c++ // Finds cases like these: if (auto x = cast<X>(y)) <...> if (cast<X>(y)) <...> // But not cases like these: if (auto f = cast<Z>(y)->foo()) <...> if (cast<Z>(y)->foo()) <...> Reviewers: alexfh, rjmccall, hokein, aaron.ballman, JonasToth Reviewed By: aaron.ballman Subscribers: xbolva00, Eugene.Zelenko, mgorny, xazax.hun, cfe-commits Tags: #clang-tools-extra, #clang Differential Revision: https://reviews.llvm.org/D59802 llvm-svn: 359142
47 lines
1.7 KiB
C++
47 lines
1.7 KiB
C++
//===--- LLVMTidyModule.cpp - clang-tidy ----------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "../readability/NamespaceCommentCheck.h"
|
|
#include "HeaderGuardCheck.h"
|
|
#include "IncludeOrderCheck.h"
|
|
#include "PreferIsaOrDynCastInConditionalsCheck.h"
|
|
#include "TwineLocalCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace llvm {
|
|
|
|
class LLVMModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<LLVMHeaderGuardCheck>("llvm-header-guard");
|
|
CheckFactories.registerCheck<IncludeOrderCheck>("llvm-include-order");
|
|
CheckFactories.registerCheck<readability::NamespaceCommentCheck>(
|
|
"llvm-namespace-comment");
|
|
CheckFactories.registerCheck<PreferIsaOrDynCastInConditionalsCheck>(
|
|
"llvm-prefer-isa-or-dyn-cast-in-conditionals");
|
|
CheckFactories.registerCheck<TwineLocalCheck>("llvm-twine-local");
|
|
}
|
|
};
|
|
|
|
// Register the LLVMTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<LLVMModule> X("llvm-module",
|
|
"Adds LLVM lint checks.");
|
|
|
|
} // namespace llvm
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the LLVMModule.
|
|
volatile int LLVMModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|