
This reverts commit 0df522969a7a0128052bd79182c8d58e00556e2f. Additional checks are added to fix the detection of the last memory region in GetMemoryRegions or repeating the "memory region" command when the target has non-address bits. Normally you keep reading from address 0, looking up each region's end address until you get LLDB_INVALID_ADDR as the region end address. (0xffffffffffffffff) This is what the remote will return once you go beyond the last mapped region: [0x0000fffffffdf000-0x0001000000000000) rw- [stack] [0x0001000000000000-0xffffffffffffffff) --- Problem is that when we "fix" the lookup address, we remove some bits from it. On an AArch64 system we have 48 bit virtual addresses, so when we fix the end address of the [stack] region the result is 0. So we loop back to the start. [0x0000fffffffdf000-0x0001000000000000) rw- [stack] [0x0000000000000000-0x0000000000400000) --- To fix this I added an additional check for the last range. If the end address of the region is different once you apply FixDataAddress, we are at the last region. Since the end of the last region will be the last valid mappable address, plus 1. That 1 will be removed by the ABI plugin. The only side effect is that on systems with non-address bits, you won't get that last catch all unmapped region from the max virtual address up to 0xf...f. [0x0000fffff8000000-0x0000fffffffdf000) --- [0x0000fffffffdf000-0x0001000000000000) rw- [stack] <ends here> Though in some way this is more correct because that region is not just unmapped, it's not mappable at all. No extra testing is needed because this is already covered by TestMemoryRegion.py, I simply forgot to run it on system that had both top byte ignore and pointer authentication. This change has been tested on a qemu VM with top byte ignore, memory tagging and pointer authentication enabled. Reviewed By: omjavaid Differential Revision: https://reviews.llvm.org/D115508
380 lines
12 KiB
C++
380 lines
12 KiB
C++
//===-- ScriptedProcess.cpp -----------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ScriptedProcess.h"
|
|
|
|
#include "lldb/Core/Debugger.h"
|
|
#include "lldb/Core/Module.h"
|
|
#include "lldb/Core/PluginManager.h"
|
|
|
|
#include "lldb/Host/OptionParser.h"
|
|
#include "lldb/Host/ThreadLauncher.h"
|
|
#include "lldb/Interpreter/CommandInterpreter.h"
|
|
#include "lldb/Interpreter/OptionArgParser.h"
|
|
#include "lldb/Interpreter/OptionGroupBoolean.h"
|
|
#include "lldb/Interpreter/ScriptInterpreter.h"
|
|
#include "lldb/Target/MemoryRegionInfo.h"
|
|
#include "lldb/Target/RegisterContext.h"
|
|
#include "lldb/Utility/LLDBLog.h"
|
|
#include "lldb/Utility/State.h"
|
|
|
|
#include <mutex>
|
|
|
|
LLDB_PLUGIN_DEFINE(ScriptedProcess)
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
llvm::StringRef ScriptedProcess::GetPluginDescriptionStatic() {
|
|
return "Scripted Process plug-in.";
|
|
}
|
|
|
|
static constexpr lldb::ScriptLanguage g_supported_script_languages[] = {
|
|
ScriptLanguage::eScriptLanguagePython,
|
|
};
|
|
|
|
bool ScriptedProcess::IsScriptLanguageSupported(lldb::ScriptLanguage language) {
|
|
llvm::ArrayRef<lldb::ScriptLanguage> supported_languages =
|
|
llvm::makeArrayRef(g_supported_script_languages);
|
|
|
|
return llvm::is_contained(supported_languages, language);
|
|
}
|
|
|
|
void ScriptedProcess::CheckInterpreterAndScriptObject() const {
|
|
lldbassert(m_interpreter && "Invalid Script Interpreter.");
|
|
lldbassert(m_script_object_sp && "Invalid Script Object.");
|
|
}
|
|
|
|
lldb::ProcessSP ScriptedProcess::CreateInstance(lldb::TargetSP target_sp,
|
|
lldb::ListenerSP listener_sp,
|
|
const FileSpec *file,
|
|
bool can_connect) {
|
|
if (!target_sp ||
|
|
!IsScriptLanguageSupported(target_sp->GetDebugger().GetScriptLanguage()))
|
|
return nullptr;
|
|
|
|
Status error;
|
|
ScriptedProcess::ScriptedProcessInfo scripted_process_info(
|
|
target_sp->GetProcessLaunchInfo());
|
|
|
|
auto process_sp = std::make_shared<ScriptedProcess>(
|
|
target_sp, listener_sp, scripted_process_info, error);
|
|
|
|
if (error.Fail() || !process_sp || !process_sp->m_script_object_sp ||
|
|
!process_sp->m_script_object_sp->IsValid()) {
|
|
LLDB_LOGF(GetLog(LLDBLog::Process), "%s", error.AsCString());
|
|
return nullptr;
|
|
}
|
|
|
|
return process_sp;
|
|
}
|
|
|
|
bool ScriptedProcess::CanDebug(lldb::TargetSP target_sp,
|
|
bool plugin_specified_by_name) {
|
|
return true;
|
|
}
|
|
|
|
ScriptedProcess::ScriptedProcess(
|
|
lldb::TargetSP target_sp, lldb::ListenerSP listener_sp,
|
|
const ScriptedProcess::ScriptedProcessInfo &scripted_process_info,
|
|
Status &error)
|
|
: Process(target_sp, listener_sp),
|
|
m_scripted_process_info(scripted_process_info) {
|
|
|
|
if (!target_sp) {
|
|
error.SetErrorStringWithFormat("ScriptedProcess::%s () - ERROR: %s",
|
|
__FUNCTION__, "Invalid target");
|
|
return;
|
|
}
|
|
|
|
m_interpreter = target_sp->GetDebugger().GetScriptInterpreter();
|
|
|
|
if (!m_interpreter) {
|
|
error.SetErrorStringWithFormat("ScriptedProcess::%s () - ERROR: %s",
|
|
__FUNCTION__,
|
|
"Debugger has no Script Interpreter");
|
|
return;
|
|
}
|
|
|
|
ExecutionContext exe_ctx(target_sp, /*get_process=*/false);
|
|
|
|
StructuredData::GenericSP object_sp = GetInterface().CreatePluginObject(
|
|
m_scripted_process_info.GetClassName().c_str(), exe_ctx,
|
|
m_scripted_process_info.GetArgsSP());
|
|
|
|
if (!object_sp || !object_sp->IsValid()) {
|
|
error.SetErrorStringWithFormat("ScriptedProcess::%s () - ERROR: %s",
|
|
__FUNCTION__,
|
|
"Failed to create valid script object");
|
|
return;
|
|
}
|
|
|
|
m_script_object_sp = object_sp;
|
|
}
|
|
|
|
ScriptedProcess::~ScriptedProcess() {
|
|
Clear();
|
|
// We need to call finalize on the process before destroying ourselves to
|
|
// make sure all of the broadcaster cleanup goes as planned. If we destruct
|
|
// this class, then Process::~Process() might have problems trying to fully
|
|
// destroy the broadcaster.
|
|
Finalize();
|
|
}
|
|
|
|
void ScriptedProcess::Initialize() {
|
|
static llvm::once_flag g_once_flag;
|
|
|
|
llvm::call_once(g_once_flag, []() {
|
|
PluginManager::RegisterPlugin(GetPluginNameStatic(),
|
|
GetPluginDescriptionStatic(), CreateInstance);
|
|
});
|
|
}
|
|
|
|
void ScriptedProcess::Terminate() {
|
|
PluginManager::UnregisterPlugin(ScriptedProcess::CreateInstance);
|
|
}
|
|
|
|
Status ScriptedProcess::DoLoadCore() {
|
|
ProcessLaunchInfo launch_info = GetTarget().GetProcessLaunchInfo();
|
|
|
|
return DoLaunch(nullptr, launch_info);
|
|
}
|
|
|
|
Status ScriptedProcess::DoLaunch(Module *exe_module,
|
|
ProcessLaunchInfo &launch_info) {
|
|
CheckInterpreterAndScriptObject();
|
|
|
|
/* FIXME: This doesn't reflect how lldb actually launches a process.
|
|
In reality, it attaches to debugserver, then resume the process. */
|
|
Status error = GetInterface().Launch();
|
|
SetPrivateState(eStateRunning);
|
|
|
|
if (error.Fail())
|
|
return error;
|
|
|
|
// TODO: Fetch next state from stopped event queue then send stop event
|
|
// const StateType state = SetThreadStopInfo(response);
|
|
// if (state != eStateInvalid) {
|
|
// SetPrivateState(state);
|
|
|
|
SetPrivateState(eStateStopped);
|
|
|
|
return {};
|
|
}
|
|
|
|
void ScriptedProcess::DidLaunch() {
|
|
CheckInterpreterAndScriptObject();
|
|
m_pid = GetInterface().GetProcessID();
|
|
}
|
|
|
|
Status ScriptedProcess::DoResume() {
|
|
CheckInterpreterAndScriptObject();
|
|
|
|
Log *log = GetLog(LLDBLog::Process);
|
|
// FIXME: Fetch data from thread.
|
|
const StateType thread_resume_state = eStateRunning;
|
|
LLDB_LOGF(log, "ScriptedProcess::%s thread_resume_state = %s", __FUNCTION__,
|
|
StateAsCString(thread_resume_state));
|
|
|
|
bool resume = (thread_resume_state == eStateRunning);
|
|
assert(thread_resume_state == eStateRunning && "invalid thread resume state");
|
|
|
|
Status error;
|
|
if (resume) {
|
|
LLDB_LOGF(log, "ScriptedProcess::%s sending resume", __FUNCTION__);
|
|
|
|
SetPrivateState(eStateRunning);
|
|
SetPrivateState(eStateStopped);
|
|
error = GetInterface().Resume();
|
|
}
|
|
|
|
return error;
|
|
}
|
|
|
|
Status ScriptedProcess::DoStop() {
|
|
CheckInterpreterAndScriptObject();
|
|
|
|
Log *log = GetLog(LLDBLog::Process);
|
|
|
|
if (GetInterface().ShouldStop()) {
|
|
SetPrivateState(eStateStopped);
|
|
LLDB_LOGF(log, "ScriptedProcess::%s Immediate stop", __FUNCTION__);
|
|
return {};
|
|
}
|
|
|
|
LLDB_LOGF(log, "ScriptedProcess::%s Delayed stop", __FUNCTION__);
|
|
return GetInterface().Stop();
|
|
}
|
|
|
|
Status ScriptedProcess::DoDestroy() { return Status(); }
|
|
|
|
bool ScriptedProcess::IsAlive() {
|
|
if (m_interpreter && m_script_object_sp)
|
|
return GetInterface().IsAlive();
|
|
return false;
|
|
}
|
|
|
|
size_t ScriptedProcess::DoReadMemory(lldb::addr_t addr, void *buf, size_t size,
|
|
Status &error) {
|
|
if (!m_interpreter)
|
|
return ScriptedInterface::ErrorWithMessage<size_t>(
|
|
LLVM_PRETTY_FUNCTION, "No interpreter.", error);
|
|
|
|
lldb::DataExtractorSP data_extractor_sp =
|
|
GetInterface().ReadMemoryAtAddress(addr, size, error);
|
|
|
|
if (!data_extractor_sp || !data_extractor_sp->GetByteSize() || error.Fail())
|
|
return 0;
|
|
|
|
offset_t bytes_copied = data_extractor_sp->CopyByteOrderedData(
|
|
0, data_extractor_sp->GetByteSize(), buf, size, GetByteOrder());
|
|
|
|
if (!bytes_copied || bytes_copied == LLDB_INVALID_OFFSET)
|
|
return ScriptedInterface::ErrorWithMessage<size_t>(
|
|
LLVM_PRETTY_FUNCTION, "Failed to copy read memory to buffer.", error);
|
|
|
|
return size;
|
|
}
|
|
|
|
ArchSpec ScriptedProcess::GetArchitecture() {
|
|
return GetTarget().GetArchitecture();
|
|
}
|
|
|
|
Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t load_addr,
|
|
MemoryRegionInfo ®ion) {
|
|
CheckInterpreterAndScriptObject();
|
|
|
|
Status error;
|
|
if (auto region_or_err =
|
|
GetInterface().GetMemoryRegionContainingAddress(load_addr, error))
|
|
region = *region_or_err;
|
|
|
|
return error;
|
|
}
|
|
|
|
Status ScriptedProcess::GetMemoryRegions(MemoryRegionInfos ®ion_list) {
|
|
CheckInterpreterAndScriptObject();
|
|
|
|
Status error;
|
|
lldb::addr_t address = 0;
|
|
|
|
while (auto region_or_err =
|
|
GetInterface().GetMemoryRegionContainingAddress(address, error)) {
|
|
if (error.Fail())
|
|
break;
|
|
|
|
MemoryRegionInfo &mem_region = *region_or_err;
|
|
auto range = mem_region.GetRange();
|
|
address += range.GetRangeBase() + range.GetByteSize();
|
|
region_list.push_back(mem_region);
|
|
}
|
|
|
|
return error;
|
|
}
|
|
|
|
void ScriptedProcess::Clear() { Process::m_thread_list.Clear(); }
|
|
|
|
bool ScriptedProcess::DoUpdateThreadList(ThreadList &old_thread_list,
|
|
ThreadList &new_thread_list) {
|
|
// TODO: Implement
|
|
// This is supposed to get the current set of threads, if any of them are in
|
|
// old_thread_list then they get copied to new_thread_list, and then any
|
|
// actually new threads will get added to new_thread_list.
|
|
|
|
CheckInterpreterAndScriptObject();
|
|
m_thread_plans.ClearThreadCache();
|
|
|
|
Status error;
|
|
ScriptLanguage language = m_interpreter->GetLanguage();
|
|
|
|
if (language != eScriptLanguagePython)
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION,
|
|
llvm::Twine("ScriptInterpreter language (" +
|
|
llvm::Twine(m_interpreter->LanguageToString(language)) +
|
|
llvm::Twine(") not supported."))
|
|
.str(),
|
|
error);
|
|
|
|
StructuredData::DictionarySP thread_info_sp = GetInterface().GetThreadsInfo();
|
|
|
|
if (!thread_info_sp)
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION,
|
|
"Couldn't fetch thread list from Scripted Process.", error);
|
|
|
|
auto create_scripted_thread =
|
|
[this, &old_thread_list, &error,
|
|
&new_thread_list](ConstString key, StructuredData::Object *val) -> bool {
|
|
if (!val)
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION, "Invalid thread info object", error);
|
|
|
|
lldb::tid_t tid = LLDB_INVALID_THREAD_ID;
|
|
if (!llvm::to_integer(key.AsCString(), tid))
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION, "Invalid thread id", error);
|
|
|
|
if (ThreadSP thread_sp =
|
|
old_thread_list.FindThreadByID(tid, false /*=can_update*/)) {
|
|
// If the thread was already in the old_thread_list,
|
|
// just add it back to the new_thread_list.
|
|
new_thread_list.AddThread(thread_sp);
|
|
return true;
|
|
}
|
|
|
|
auto thread_or_error = ScriptedThread::Create(*this, val->GetAsGeneric());
|
|
|
|
if (!thread_or_error)
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION, toString(thread_or_error.takeError()), error);
|
|
|
|
ThreadSP thread_sp = thread_or_error.get();
|
|
lldbassert(thread_sp && "Couldn't initialize scripted thread.");
|
|
|
|
RegisterContextSP reg_ctx_sp = thread_sp->GetRegisterContext();
|
|
if (!reg_ctx_sp)
|
|
return ScriptedInterface::ErrorWithMessage<bool>(
|
|
LLVM_PRETTY_FUNCTION,
|
|
llvm::Twine("Invalid Register Context for thread " +
|
|
llvm::Twine(key.AsCString()))
|
|
.str(),
|
|
error);
|
|
|
|
new_thread_list.AddThread(thread_sp);
|
|
|
|
return true;
|
|
};
|
|
|
|
thread_info_sp->ForEach(create_scripted_thread);
|
|
|
|
return new_thread_list.GetSize(false) > 0;
|
|
}
|
|
|
|
void ScriptedProcess::RefreshStateAfterStop() {
|
|
// Let all threads recover from stopping and do any clean up based on the
|
|
// previous thread state (if any).
|
|
}
|
|
|
|
bool ScriptedProcess::GetProcessInfo(ProcessInstanceInfo &info) {
|
|
info.Clear();
|
|
info.SetProcessID(GetID());
|
|
info.SetArchitecture(GetArchitecture());
|
|
lldb::ModuleSP module_sp = GetTarget().GetExecutableModule();
|
|
if (module_sp) {
|
|
const bool add_exe_file_as_first_arg = false;
|
|
info.SetExecutableFile(GetTarget().GetExecutableModule()->GetFileSpec(),
|
|
add_exe_file_as_first_arg);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
ScriptedProcessInterface &ScriptedProcess::GetInterface() const {
|
|
return m_interpreter->GetScriptedProcessInterface();
|
|
}
|