2946cd7010
to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
57 lines
2.1 KiB
C++
57 lines
2.1 KiB
C++
//===--- MisplacedArrayIndexCheck.cpp - clang-tidy-------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MisplacedArrayIndexCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/Lex/Lexer.h"
|
|
#include "clang/Tooling/FixIt.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace readability {
|
|
|
|
void MisplacedArrayIndexCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(arraySubscriptExpr(hasLHS(hasType(isInteger())),
|
|
hasRHS(hasType(isAnyPointer())))
|
|
.bind("expr"),
|
|
this);
|
|
}
|
|
|
|
void MisplacedArrayIndexCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *ArraySubscriptE =
|
|
Result.Nodes.getNodeAs<ArraySubscriptExpr>("expr");
|
|
|
|
auto Diag = diag(ArraySubscriptE->getBeginLoc(), "confusing array subscript "
|
|
"expression, usually the "
|
|
"index is inside the []");
|
|
|
|
// Only try to fixit when LHS and RHS can be swapped directly without changing
|
|
// the logic.
|
|
const Expr *RHSE = ArraySubscriptE->getRHS()->IgnoreParenImpCasts();
|
|
if (!isa<StringLiteral>(RHSE) && !isa<DeclRefExpr>(RHSE) &&
|
|
!isa<MemberExpr>(RHSE))
|
|
return;
|
|
|
|
const StringRef LText = tooling::fixit::getText(
|
|
ArraySubscriptE->getLHS()->getSourceRange(), *Result.Context);
|
|
const StringRef RText = tooling::fixit::getText(
|
|
ArraySubscriptE->getRHS()->getSourceRange(), *Result.Context);
|
|
|
|
Diag << FixItHint::CreateReplacement(
|
|
ArraySubscriptE->getLHS()->getSourceRange(), RText);
|
|
Diag << FixItHint::CreateReplacement(
|
|
ArraySubscriptE->getRHS()->getSourceRange(), LText);
|
|
}
|
|
|
|
} // namespace readability
|
|
} // namespace tidy
|
|
} // namespace clang
|