JF Bastien 2df59c5068 Support tests in freestanding
Summary:
Freestanding is *weird*. The standard allows it to differ in a bunch of odd
manners from regular C++, and the committee would like to improve that
situation. I'd like to make libc++ behave better with what freestanding should
be, so that it can be a tool we use in improving the standard. To do that we
need to try stuff out, both with "freestanding the language mode" and
"freestanding the library subset".

Let's start with the super basic: run the libc++ tests in freestanding, using
clang as the compiler, and see what works. The easiest hack to do this:

In utils/libcxx/test/config.py add:

  self.cxx.compile_flags += ['-ffreestanding']

Run the tests and they all fail.

Why? Because in freestanding `main` isn't special. This "not special" property
has two effects: main doesn't get mangled, and main isn't allowed to omit its
`return` statement. The first means main gets mangled and the linker can't
create a valid executable for us to test. The second means we spew out warnings
(ew) and the compiler doesn't insert the `return` we omitted, and main just
falls of the end and does whatever undefined behavior (if you're luck, ud2
leading to non-zero return code).

Let's start my work with the basics. This patch changes all libc++ tests to
declare `main` as `int main(int, char**` so it mangles consistently (enabling us
to declare another `extern "C"` main for freestanding which calls the mangled
one), and adds `return 0;` to all places where it was missing. This touches 6124
files, and I apologize.

The former was done with The Magic Of Sed.

The later was done with a (not quite correct but decent) clang tool:

  https://gist.github.com/jfbastien/793819ff360baa845483dde81170feed

This works for most tests, though I did have to adjust a few places when e.g.
the test runs with `-x c`, macros are used for main (such as for the filesystem
tests), etc.

Once this is in we can create a freestanding bot which will prevent further
regressions. After that, we can start the real work of supporting C++
freestanding fairly well in libc++.

<rdar://problem/47754795>

Reviewers: ldionne, mclow.lists, EricWF

Subscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commits

Differential Revision: https://reviews.llvm.org/D57624

llvm-svn: 353086
2019-02-04 20:31:13 +00:00

266 lines
6.3 KiB
C++

// -*- C++ -*-
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11, c++14
// XFAIL: availability=macosx10.13
// XFAIL: availability=macosx10.12
// XFAIL: availability=macosx10.11
// XFAIL: availability=macosx10.10
// XFAIL: availability=macosx10.9
// XFAIL: availability=macosx10.8
// XFAIL: availability=macosx10.7
// <variant>
// template <class ...Types> class variant;
// template <class T>
// variant& operator=(T&&) noexcept(see below);
#include <cassert>
#include <string>
#include <type_traits>
#include <variant>
#include "test_macros.h"
#include "variant_test_helpers.hpp"
namespace MetaHelpers {
struct Dummy {
Dummy() = default;
};
struct ThrowsCtorT {
ThrowsCtorT(int) noexcept(false) {}
ThrowsCtorT &operator=(int) noexcept { return *this; }
};
struct ThrowsAssignT {
ThrowsAssignT(int) noexcept {}
ThrowsAssignT &operator=(int) noexcept(false) { return *this; }
};
struct NoThrowT {
NoThrowT(int) noexcept {}
NoThrowT &operator=(int) noexcept { return *this; }
};
} // namespace MetaHelpers
namespace RuntimeHelpers {
#ifndef TEST_HAS_NO_EXCEPTIONS
struct ThrowsCtorT {
int value;
ThrowsCtorT() : value(0) {}
ThrowsCtorT(int) noexcept(false) { throw 42; }
ThrowsCtorT &operator=(int v) noexcept {
value = v;
return *this;
}
};
struct MoveCrashes {
int value;
MoveCrashes(int v = 0) noexcept : value{v} {}
MoveCrashes(MoveCrashes &&) noexcept { assert(false); }
MoveCrashes &operator=(MoveCrashes &&) noexcept { assert(false); return *this; }
MoveCrashes &operator=(int v) noexcept {
value = v;
return *this;
}
};
struct ThrowsCtorTandMove {
int value;
ThrowsCtorTandMove() : value(0) {}
ThrowsCtorTandMove(int) noexcept(false) { throw 42; }
ThrowsCtorTandMove(ThrowsCtorTandMove &&) noexcept(false) { assert(false); }
ThrowsCtorTandMove &operator=(int v) noexcept {
value = v;
return *this;
}
};
struct ThrowsAssignT {
int value;
ThrowsAssignT() : value(0) {}
ThrowsAssignT(int v) noexcept : value(v) {}
ThrowsAssignT &operator=(int) noexcept(false) { throw 42; }
};
struct NoThrowT {
int value;
NoThrowT() : value(0) {}
NoThrowT(int v) noexcept : value(v) {}
NoThrowT &operator=(int v) noexcept {
value = v;
return *this;
}
};
#endif // !defined(TEST_HAS_NO_EXCEPTIONS)
} // namespace RuntimeHelpers
void test_T_assignment_noexcept() {
using namespace MetaHelpers;
{
using V = std::variant<Dummy, NoThrowT>;
static_assert(std::is_nothrow_assignable<V, int>::value, "");
}
{
using V = std::variant<Dummy, ThrowsCtorT>;
static_assert(!std::is_nothrow_assignable<V, int>::value, "");
}
{
using V = std::variant<Dummy, ThrowsAssignT>;
static_assert(!std::is_nothrow_assignable<V, int>::value, "");
}
}
void test_T_assignment_sfinae() {
{
using V = std::variant<long, unsigned>;
static_assert(!std::is_assignable<V, int>::value, "ambiguous");
}
{
using V = std::variant<std::string, std::string>;
static_assert(!std::is_assignable<V, const char *>::value, "ambiguous");
}
{
using V = std::variant<std::string, void *>;
static_assert(!std::is_assignable<V, int>::value, "no matching operator=");
}
#if !defined(TEST_VARIANT_HAS_NO_REFERENCES)
{
using V = std::variant<int, int &&>;
static_assert(!std::is_assignable<V, int>::value, "ambiguous");
}
{
using V = std::variant<int, const int &>;
static_assert(!std::is_assignable<V, int>::value, "ambiguous");
}
#endif // TEST_VARIANT_HAS_NO_REFERENCES
}
void test_T_assignment_basic() {
{
std::variant<int> v(43);
v = 42;
assert(v.index() == 0);
assert(std::get<0>(v) == 42);
}
{
std::variant<int, long> v(43l);
v = 42;
assert(v.index() == 0);
assert(std::get<0>(v) == 42);
v = 43l;
assert(v.index() == 1);
assert(std::get<1>(v) == 43);
}
#if !defined(TEST_VARIANT_HAS_NO_REFERENCES)
{
using V = std::variant<int &, int &&, long>;
int x = 42;
V v(43l);
v = x;
assert(v.index() == 0);
assert(&std::get<0>(v) == &x);
v = std::move(x);
assert(v.index() == 1);
assert(&std::get<1>(v) == &x);
// 'long' is selected by FUN(const int &) since 'const int &' cannot bind
// to 'int&'.
const int &cx = x;
v = cx;
assert(v.index() == 2);
assert(std::get<2>(v) == 42);
}
#endif // TEST_VARIANT_HAS_NO_REFERENCES
}
void test_T_assignment_performs_construction() {
using namespace RuntimeHelpers;
#ifndef TEST_HAS_NO_EXCEPTIONS
{
using V = std::variant<std::string, ThrowsCtorT>;
V v(std::in_place_type<std::string>, "hello");
try {
v = 42;
assert(false);
} catch (...) { /* ... */
}
assert(v.index() == 0);
assert(std::get<0>(v) == "hello");
}
{
using V = std::variant<ThrowsAssignT, std::string>;
V v(std::in_place_type<std::string>, "hello");
v = 42;
assert(v.index() == 0);
assert(std::get<0>(v).value == 42);
}
#endif // TEST_HAS_NO_EXCEPTIONS
}
void test_T_assignment_performs_assignment() {
using namespace RuntimeHelpers;
#ifndef TEST_HAS_NO_EXCEPTIONS
{
using V = std::variant<ThrowsCtorT>;
V v;
v = 42;
assert(v.index() == 0);
assert(std::get<0>(v).value == 42);
}
{
using V = std::variant<ThrowsCtorT, std::string>;
V v;
v = 42;
assert(v.index() == 0);
assert(std::get<0>(v).value == 42);
}
{
using V = std::variant<ThrowsAssignT>;
V v(100);
try {
v = 42;
assert(false);
} catch (...) { /* ... */
}
assert(v.index() == 0);
assert(std::get<0>(v).value == 100);
}
{
using V = std::variant<std::string, ThrowsAssignT>;
V v(100);
try {
v = 42;
assert(false);
} catch (...) { /* ... */
}
assert(v.index() == 1);
assert(std::get<1>(v).value == 100);
}
#endif // TEST_HAS_NO_EXCEPTIONS
}
int main(int, char**) {
test_T_assignment_basic();
test_T_assignment_performs_construction();
test_T_assignment_performs_assignment();
test_T_assignment_noexcept();
test_T_assignment_sfinae();
return 0;
}