43222bd309
This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
16 lines
549 B
LLVM
16 lines
549 B
LLVM
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
|
|
|
|
; CHECK-DAG: %[[#INT:]] = OpTypeInt 32
|
|
; CHECK-DAG: %[[#GLOBAL_PTR_INT:]] = OpTypePointer CrossWorkgroup %[[#INT]]
|
|
|
|
define i32 @foo(i32 %a, ptr addrspace(1) %p) {
|
|
store i32 %a, i32 addrspace(1)* %p
|
|
%b = load i32, i32 addrspace(1)* %p
|
|
ret i32 %b
|
|
}
|
|
|
|
; CHECK: %[[#A:]] = OpFunctionParameter %[[#INT]]
|
|
; CHECK: %[[#CorP:]] = {{OpBitcast|OpFunctionParameter}}{{.*}}%[[#GLOBAL_PTR_INT]]{{.*}}
|
|
; CHECK: OpStore %[[#CorP]] %[[#A]]
|
|
; CHECK: %[[#B:]] = OpLoad %[[#INT]] %[[#CorP]]
|