43222bd309
This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
17 lines
706 B
LLVM
17 lines
706 B
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
|
|
; CHECK-DAG: %[[#float:]] = OpTypeFloat 32
|
|
; CHECK-DAG: %[[#pointer:]] = OpTypePointer CrossWorkgroup %[[#float]]
|
|
|
|
define void @foo(float addrspace(1)* %A, i32 %B) {
|
|
%cmp = icmp sgt i32 %B, 0
|
|
%conv = uitofp i1 %cmp to float
|
|
; CHECK-DAG: %[[#utof_res:]] = OpConvertUToF %[[#float]] %[[#]]
|
|
; CHECK-DAG: %[[#bitcastORparam:]] = {{OpBitcast|OpFunctionParameter}}{{.*}}%[[#pointer]]{{.*}}
|
|
; CHECK: OpStore %[[#bitcastORparam]] %[[#utof_res]]
|
|
%BC1 = bitcast float addrspace(1)* %A to i32 addrspace(1)*
|
|
%BC2 = bitcast i32 addrspace(1)* %BC1 to float addrspace(1)*
|
|
store float %conv, float addrspace(1)* %BC2, align 4;
|
|
ret void
|
|
}
|