
## Purpose This patch prepares the llvm/CodeGen library for public interface annotations in support of an LLVM Windows DLL (shared library) build, tracked in #109483. The purpose of this patch is to make the upcoming codemod of this library more straight-forward. It is not expected to impact any functionality. The `LLVM_ABI` annotations will be added in a subsequent patch. These changes are required to build with visibility annotations using Clang and gcc on Linux/Darwin/etc; Windows DLL can build fine without them. ## Overview This PR does four things in preparation for adding `LLVM_ABI` annotations to llvm/CodeGen: 1. Explicitly include `Machine.h` and `Function.h` headers from `MachinePassManager.cpp` so that `Function` and `Machine` types are available for the instantiations of `InnerAnalysisManagerProxy`. Without this change, Clang only will only export one of the templates after visibility annotations are added to them. Unclear if this is a Clang bug or expected behavior, but this change avoids the issue and should be harmless. 2. Refactor the definition of `MachineFunctionAnalysisManager` to its own header file. Without this change, it is not possible to add visibility annotations to the declaration with causing gcc to produce `-Wattribute` warnings. 3. Remove the redundant specialization of the `DominatorTreeBase<MachineBasicBlock, false>::addRoot` method. The specialization is the same as implemented in `DominatorTreeBase` so should be unnecessary. Without this change, it is not possible to annotate the subsequent instantiations of `DominatorTreeBase` in the header file without gcc producing `-Wattribute` warnings. Mark unspecialized `addRoot` as `inline` to match the removed specialized version. 4. Move the explicit instantiations of the `GenericDomTreeUpdater` template earlier in the header file. These need to appear before being used in the `MachineDomTreeUpdater` class definition or gcc will produce warnings once visibility annotations are added. ## Background The LLVM Windows DLL effort is tracked in #109483. Additional context is provided in [this discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307). Clang and gcc handle visibility attributes on explicit template instantiations a bit differently; gcc is pickier and generates `-Wattribute` warnings when an explicit instantiation with a visibility annotation appears after the type has already appeared in the translation unit. These warnings can be avoided by moving explicit template instantiations so they always appear first. ## Validation Local builds and tests to validate cross-platform compatibility. This included llvm, clang, and lldb on the following configurations: - Windows with MSVC - Windows with Clang - Linux with GCC - Linux with Clang - Darwin with Clang
169 lines
6.5 KiB
C++
169 lines
6.5 KiB
C++
//===---------- MachinePassManager.cpp ------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains the pass management machinery for machine functions.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/MachinePassManager.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineFunctionAnalysis.h"
|
|
#include "llvm/CodeGen/MachineModuleInfo.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/IR/PassManagerImpl.h"
|
|
|
|
using namespace llvm;
|
|
|
|
AnalysisKey FunctionAnalysisManagerMachineFunctionProxy::Key;
|
|
|
|
namespace llvm {
|
|
template class AnalysisManager<MachineFunction>;
|
|
template class PassManager<MachineFunction>;
|
|
template class InnerAnalysisManagerProxy<MachineFunctionAnalysisManager,
|
|
Module>;
|
|
template class InnerAnalysisManagerProxy<MachineFunctionAnalysisManager,
|
|
Function>;
|
|
template class OuterAnalysisManagerProxy<ModuleAnalysisManager,
|
|
MachineFunction>;
|
|
} // namespace llvm
|
|
|
|
bool FunctionAnalysisManagerMachineFunctionProxy::Result::invalidate(
|
|
MachineFunction &IR, const PreservedAnalyses &PA,
|
|
MachineFunctionAnalysisManager::Invalidator &Inv) {
|
|
// MachineFunction passes should not invalidate Function analyses.
|
|
// TODO: verify that PA doesn't invalidate Function analyses.
|
|
return false;
|
|
}
|
|
|
|
template <>
|
|
bool MachineFunctionAnalysisManagerModuleProxy::Result::invalidate(
|
|
Module &M, const PreservedAnalyses &PA,
|
|
ModuleAnalysisManager::Invalidator &Inv) {
|
|
// If literally everything is preserved, we're done.
|
|
if (PA.areAllPreserved())
|
|
return false; // This is still a valid proxy.
|
|
|
|
// If this proxy isn't marked as preserved, then even if the result remains
|
|
// valid, the key itself may no longer be valid, so we clear everything.
|
|
//
|
|
// Note that in order to preserve this proxy, a module pass must ensure that
|
|
// the MFAM has been completely updated to handle the deletion of functions.
|
|
// Specifically, any MFAM-cached results for those functions need to have been
|
|
// forcibly cleared. When preserved, this proxy will only invalidate results
|
|
// cached on functions *still in the module* at the end of the module pass.
|
|
auto PAC = PA.getChecker<MachineFunctionAnalysisManagerModuleProxy>();
|
|
if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Module>>()) {
|
|
InnerAM->clear();
|
|
return true;
|
|
}
|
|
|
|
// FIXME: be more precise, see
|
|
// FunctionAnalysisManagerModuleProxy::Result::invalidate.
|
|
if (!PA.allAnalysesInSetPreserved<AllAnalysesOn<MachineFunction>>()) {
|
|
InnerAM->clear();
|
|
return true;
|
|
}
|
|
|
|
// Return false to indicate that this result is still a valid proxy.
|
|
return false;
|
|
}
|
|
|
|
template <>
|
|
bool MachineFunctionAnalysisManagerFunctionProxy::Result::invalidate(
|
|
Function &F, const PreservedAnalyses &PA,
|
|
FunctionAnalysisManager::Invalidator &Inv) {
|
|
// If literally everything is preserved, we're done.
|
|
if (PA.areAllPreserved())
|
|
return false; // This is still a valid proxy.
|
|
|
|
// If this proxy isn't marked as preserved, then even if the result remains
|
|
// valid, the key itself may no longer be valid, so we clear everything.
|
|
//
|
|
// Note that in order to preserve this proxy, a module pass must ensure that
|
|
// the MFAM has been completely updated to handle the deletion of functions.
|
|
// Specifically, any MFAM-cached results for those functions need to have been
|
|
// forcibly cleared. When preserved, this proxy will only invalidate results
|
|
// cached on functions *still in the module* at the end of the module pass.
|
|
auto PAC = PA.getChecker<MachineFunctionAnalysisManagerFunctionProxy>();
|
|
if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Function>>()) {
|
|
InnerAM->clear();
|
|
return true;
|
|
}
|
|
|
|
// FIXME: be more precise, see
|
|
// FunctionAnalysisManagerModuleProxy::Result::invalidate.
|
|
if (!PA.allAnalysesInSetPreserved<AllAnalysesOn<MachineFunction>>()) {
|
|
InnerAM->clear();
|
|
return true;
|
|
}
|
|
|
|
// Return false to indicate that this result is still a valid proxy.
|
|
return false;
|
|
}
|
|
|
|
PreservedAnalyses
|
|
FunctionToMachineFunctionPassAdaptor::run(Function &F,
|
|
FunctionAnalysisManager &FAM) {
|
|
MachineFunctionAnalysisManager &MFAM =
|
|
FAM.getResult<MachineFunctionAnalysisManagerFunctionProxy>(F)
|
|
.getManager();
|
|
PassInstrumentation PI = FAM.getResult<PassInstrumentationAnalysis>(F);
|
|
PreservedAnalyses PA = PreservedAnalyses::all();
|
|
// Do not codegen any 'available_externally' functions at all, they have
|
|
// definitions outside the translation unit.
|
|
if (F.isDeclaration() || F.hasAvailableExternallyLinkage())
|
|
return PreservedAnalyses::all();
|
|
|
|
MachineFunction &MF = FAM.getResult<MachineFunctionAnalysis>(F).getMF();
|
|
|
|
if (!PI.runBeforePass<MachineFunction>(*Pass, MF))
|
|
return PreservedAnalyses::all();
|
|
PreservedAnalyses PassPA = Pass->run(MF, MFAM);
|
|
MFAM.invalidate(MF, PassPA);
|
|
PI.runAfterPass(*Pass, MF, PassPA);
|
|
PA.intersect(std::move(PassPA));
|
|
|
|
return PA;
|
|
}
|
|
|
|
void FunctionToMachineFunctionPassAdaptor::printPipeline(
|
|
raw_ostream &OS, function_ref<StringRef(StringRef)> MapClassName2PassName) {
|
|
OS << "machine-function(";
|
|
Pass->printPipeline(OS, MapClassName2PassName);
|
|
OS << ')';
|
|
}
|
|
|
|
template <>
|
|
PreservedAnalyses
|
|
PassManager<MachineFunction>::run(MachineFunction &MF,
|
|
AnalysisManager<MachineFunction> &MFAM) {
|
|
PassInstrumentation PI = MFAM.getResult<PassInstrumentationAnalysis>(MF);
|
|
PreservedAnalyses PA = PreservedAnalyses::all();
|
|
for (auto &Pass : Passes) {
|
|
if (!PI.runBeforePass<MachineFunction>(*Pass, MF))
|
|
continue;
|
|
|
|
PreservedAnalyses PassPA = Pass->run(MF, MFAM);
|
|
MFAM.invalidate(MF, PassPA);
|
|
PI.runAfterPass(*Pass, MF, PassPA);
|
|
PA.intersect(std::move(PassPA));
|
|
}
|
|
PA.preserveSet<AllAnalysesOn<MachineFunction>>();
|
|
return PA;
|
|
}
|
|
|
|
PreservedAnalyses llvm::getMachineFunctionPassPreservedAnalyses() {
|
|
PreservedAnalyses PA;
|
|
// Machine function passes are not allowed to modify the LLVM
|
|
// representation, therefore we should preserve all IR analyses.
|
|
PA.template preserveSet<AllAnalysesOn<Module>>();
|
|
PA.template preserveSet<AllAnalysesOn<Function>>();
|
|
return PA;
|
|
}
|