0d4fb98504
The llvm IR until recently had no support for comdats. This was a problem when targeting C++ on ELF/COFF as just using weak linkage would cause quite a bit of dead bits to remain on the executable (unless -ffunction-sections, -fdata-sections and --gc-sections were used). To fix the problem, llvm's codegen will just assume that any weak or linkonce that is not in an explicit comdat should be output in one with the same name as the global. This unfortunately breaks cases like pr19848 where a weak symbol is not xpected to be part of any comdat. Now that we have explicit comdats in the IR, we can finally get both cases right. This first patch just makes clang give explicit comdats to GlobalValues where t is allowed to. A followup patch to llvm will then stop implicitly producing comdats. llvm-svn: 225705
23 lines
752 B
C++
23 lines
752 B
C++
// RUN: %clang_cc1 -emit-llvm -triple=i386-pc-win32 -fms-compatibility %s -o - | FileCheck %s
|
|
|
|
enum Enum { zero, one, two };
|
|
|
|
struct __declspec(dllexport) S {
|
|
// In MS compatibility mode, this counts as a definition.
|
|
// Since it is exported, it must be emitted even if it's unreferenced.
|
|
static const short x = 42;
|
|
|
|
// This works for enums too.
|
|
static const Enum y = two;
|
|
|
|
struct NonExported {
|
|
// dllexport is not inherited by this nested class.
|
|
// Since z is not referenced, it should not be emitted.
|
|
static const int z = 42;
|
|
};
|
|
};
|
|
|
|
// CHECK: @"\01?x@S@@2FB" = weak_odr dllexport constant i16 42, comdat, align 2
|
|
// CHECK: @"\01?y@S@@2W4Enum@@B" = weak_odr dllexport constant i32 2, comdat, align 4
|
|
// CHECK-NOT: NonExported
|