3d334df587
std::format is currently experimental, so there is technically no deployment target requirement for it (since the only symbols required for it are in `libc++experimental.a`). However, some parts of std::format depend indirectly on the floating point std::to_chars implementation, which does have deployment target requirements. This patch removes all the availability format for std::format and updates the XFAILs in the tests to properly explain why they fail on old deployment targets, when they do. It also changes a couple of tests to avoid depending on floating-point std::to_chars when it isn't fundamental to the test. Finally, some tests are marked as XFAIL but I added a comment saying TODO FMT This test should not require std::to_chars(floating-point) These tests do not fundamentally depend on floating-point std::to_chars, however they end up failing because calling std::format even without a floating-point argument to format will end up requiring floating-point std::to_chars. I believe this is an implementation artifact that could be avoided in all cases where we know the format string at compile-time. In the tests, I added the TODO comment only to the places where we could do better and actually avoid relying on floating-point std::to_chars because we know the format string at compile-time. Differential Revision: https://reviews.llvm.org/D134598
72 lines
2.6 KiB
C++
72 lines
2.6 KiB
C++
// -*- C++ -*-
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef _LIBCPP___FORMAT_FORMATTER_POINTER_H
|
|
#define _LIBCPP___FORMAT_FORMATTER_POINTER_H
|
|
|
|
#include <__availability>
|
|
#include <__config>
|
|
#include <__format/concepts.h>
|
|
#include <__format/format_parse_context.h>
|
|
#include <__format/formatter.h>
|
|
#include <__format/formatter_integral.h>
|
|
#include <__format/formatter_output.h>
|
|
#include <__format/parser_std_format_spec.h>
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
|
# pragma GCC system_header
|
|
#endif
|
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
#if _LIBCPP_STD_VER >= 20
|
|
|
|
template <__fmt_char_type _CharT>
|
|
struct _LIBCPP_TEMPLATE_VIS __formatter_pointer {
|
|
public:
|
|
_LIBCPP_HIDE_FROM_ABI constexpr auto
|
|
parse(basic_format_parse_context<_CharT>& __parse_ctx) -> decltype(__parse_ctx.begin()) {
|
|
auto __result = __parser_.__parse(__parse_ctx, __format_spec::__fields_pointer);
|
|
__format_spec::__process_display_type_pointer(__parser_.__type_);
|
|
return __result;
|
|
}
|
|
|
|
_LIBCPP_HIDE_FROM_ABI auto format(const void* __ptr, auto& __ctx) const -> decltype(__ctx.out()) {
|
|
__format_spec::__parsed_specifications<_CharT> __specs = __parser_.__get_parsed_std_specifications(__ctx);
|
|
__specs.__std_.__alternate_form_ = true;
|
|
__specs.__std_.__type_ = __format_spec::__type::__hexadecimal_lower_case;
|
|
return __formatter::__format_integer(reinterpret_cast<uintptr_t>(__ptr), __ctx, __specs);
|
|
}
|
|
|
|
__format_spec::__parser<_CharT> __parser_{.__alignment_ = __format_spec::__alignment::__right};
|
|
};
|
|
|
|
// [format.formatter.spec]/2.4
|
|
// For each charT, the pointer type specializations template<>
|
|
// - struct formatter<nullptr_t, charT>;
|
|
// - template<> struct formatter<void*, charT>;
|
|
// - template<> struct formatter<const void*, charT>;
|
|
template <__fmt_char_type _CharT>
|
|
struct _LIBCPP_TEMPLATE_VIS formatter<nullptr_t, _CharT>
|
|
: public __formatter_pointer<_CharT> {};
|
|
template <__fmt_char_type _CharT>
|
|
struct _LIBCPP_TEMPLATE_VIS formatter<void*, _CharT> : public __formatter_pointer<_CharT> {
|
|
};
|
|
template <__fmt_char_type _CharT>
|
|
struct _LIBCPP_TEMPLATE_VIS formatter<const void*, _CharT>
|
|
: public __formatter_pointer<_CharT> {};
|
|
|
|
#endif //_LIBCPP_STD_VER >= 20
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
#endif // _LIBCPP___FORMAT_FORMATTER_POINTER_H
|