34766d0d48
In #100443, Mach-o and Minidump now only call process API's that take a `SaveCoreOption` as the container for the style and information if a thread should be included in the core or not. This introduced a bug where in subsequent method calls we were not honoring the defaults of both implementations. ~~To solve this I have made a copy of each SaveCoreOptions that is mutable by the respective plugin. Originally I wanted to leave the SaveCoreOptions as non const so these default value mutations could be shown back to the user. Changing that behavior is outside of the scope of this bugfix, but is context for why we are making a copy.~~ Removed const on the savecoreoptions so defaults can be inspected by the user CC: @Michael137
59 lines
2.0 KiB
C++
59 lines
2.0 KiB
C++
//===-- WindowsMiniDump.cpp -----------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// This function is separated out from ObjectFilePECOFF.cpp to name avoid name
|
|
// collisions with WinAPI preprocessor macros.
|
|
|
|
#include "WindowsMiniDump.h"
|
|
#include "lldb/Utility/FileSpec.h"
|
|
#include "llvm/Support/ConvertUTF.h"
|
|
|
|
#ifdef _WIN32
|
|
#include "lldb/Host/windows/windows.h"
|
|
#include <dbghelp.h>
|
|
#endif
|
|
|
|
namespace lldb_private {
|
|
|
|
bool SaveMiniDump(const lldb::ProcessSP &process_sp,
|
|
SaveCoreOptions &core_options, lldb_private::Status &error) {
|
|
if (!process_sp)
|
|
return false;
|
|
#ifdef _WIN32
|
|
const auto &outfile = core_options.GetOutputFile().value();
|
|
HANDLE process_handle = ::OpenProcess(
|
|
PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, process_sp->GetID());
|
|
const std::string file_name = outfile.GetPath();
|
|
std::wstring wide_name;
|
|
wide_name.resize(file_name.size() + 1);
|
|
char *result_ptr = reinterpret_cast<char *>(&wide_name[0]);
|
|
const llvm::UTF8 *error_ptr = nullptr;
|
|
if (!llvm::ConvertUTF8toWide(sizeof(wchar_t), file_name, result_ptr,
|
|
error_ptr)) {
|
|
error.SetErrorString("cannot convert file name");
|
|
return false;
|
|
}
|
|
HANDLE file_handle =
|
|
::CreateFileW(wide_name.c_str(), GENERIC_WRITE, FILE_SHARE_READ, NULL,
|
|
CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
|
|
const auto result =
|
|
::MiniDumpWriteDump(process_handle, process_sp->GetID(), file_handle,
|
|
MiniDumpWithFullMemoryInfo, NULL, NULL, NULL);
|
|
::CloseHandle(file_handle);
|
|
::CloseHandle(process_handle);
|
|
if (!result) {
|
|
error.SetError(::GetLastError(), lldb::eErrorTypeWin32);
|
|
return false;
|
|
}
|
|
return true;
|
|
#endif
|
|
return false;
|
|
}
|
|
|
|
} // namesapce lldb_private
|