6f0253b435
This pr fixes some inconsistencies in behaviour of how we handle `StaticSamplersOffset` with respect to DXC and `RootParameterOffset`. Namely: 1. Make codegen of `RTS0` always compute the `StaticSamplersOffset` regardless if there are any `StaticSampler`s. This is to be consistent and produce an identical `DXContainer` as DXC. 2. Make the `StaticSamplersOffset` and `RootParametersOffset` optional parameters in the yaml description. This means it will be used when it is specified (which was not necassarily the case before). 3. Enforce that the provided `StaticSamplersOffset` and `RootParametersOffset` in a yaml description match the computed value. For more context see: https://github.com/llvm/llvm-project/issues/155299. Description of existing test updates updates: - `CodeGen/DirectX/ContainerData`: Updated to codegen computed values (previously unspecified) - `llvm-objcopy/DXContainer`: Updated to `yaml2obj` computed values (previously unspecified) - `ObjectYAML/DXContainer`: Updated to `yaml2obj` computed values (previously incorrect) - `ObjectYAML/DXContainerYAMLTest`: Updated to `yaml2obj` computed values (previously incorrect) See newly added tests for testing of optional parameter functionality and `StaticSamplersOffset` computation. Resolves: https://github.com/llvm/llvm-project/issues/155299
46 lines
1.4 KiB
YAML
46 lines
1.4 KiB
YAML
# RUN: yaml2obj %s | obj2yaml | FileCheck %s
|
|
|
|
--- !dxcontainer
|
|
Header:
|
|
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
|
|
Version:
|
|
Major: 1
|
|
Minor: 0
|
|
PartCount: 1
|
|
PartOffsets: [ 60 ]
|
|
Parts:
|
|
- Name: RTS0
|
|
Size: 96
|
|
RootSignature:
|
|
Version: 1
|
|
NumRootParameters: 1
|
|
RootParametersOffset: 24
|
|
NumStaticSamplers: 0
|
|
StaticSamplersOffset: 44
|
|
Parameters:
|
|
- ParameterType: 2 # SRV
|
|
ShaderVisibility: 3 # Domain
|
|
Descriptor:
|
|
ShaderRegister: 31
|
|
RegisterSpace: 32
|
|
AllowInputAssemblerInputLayout: true
|
|
DenyGeometryShaderRootAccess: true
|
|
|
|
# CHECK: - Name: RTS0
|
|
# CHECK-NEXT: Size: 96
|
|
# CHECK-NEXT: RootSignature:
|
|
# CHECK-NEXT: Version: 1
|
|
# CHECK-NEXT: NumRootParameters: 1
|
|
# CHECK-NEXT: RootParametersOffset: 24
|
|
# CHECK-NEXT: NumStaticSamplers: 0
|
|
# CHECK-NEXT: StaticSamplersOffset: 44
|
|
# CHECK-NEXT: Parameters:
|
|
# CHECK-NEXT: - ParameterType: 2
|
|
# CHECK-NEXT: ShaderVisibility: 3
|
|
# CHECK-NEXT: Descriptor:
|
|
# CHECK-NEXT: RegisterSpace: 32
|
|
# CHECK-NEXT: ShaderRegister: 31
|
|
# CHECK-NEXT: AllowInputAssemblerInputLayout: true
|
|
# CHECK-NEXT: DenyGeometryShaderRootAccess: true
|