3d334df587
std::format is currently experimental, so there is technically no deployment target requirement for it (since the only symbols required for it are in `libc++experimental.a`). However, some parts of std::format depend indirectly on the floating point std::to_chars implementation, which does have deployment target requirements. This patch removes all the availability format for std::format and updates the XFAILs in the tests to properly explain why they fail on old deployment targets, when they do. It also changes a couple of tests to avoid depending on floating-point std::to_chars when it isn't fundamental to the test. Finally, some tests are marked as XFAIL but I added a comment saying TODO FMT This test should not require std::to_chars(floating-point) These tests do not fundamentally depend on floating-point std::to_chars, however they end up failing because calling std::format even without a floating-point argument to format will end up requiring floating-point std::to_chars. I believe this is an implementation artifact that could be avoided in all cases where we know the format string at compile-time. In the tests, I added the TODO comment only to the places where we could do better and actually avoid relying on floating-point std::to_chars because we know the format string at compile-time. Differential Revision: https://reviews.llvm.org/D134598
81 lines
2.1 KiB
C++
81 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
|
|
// UNSUPPORTED: libcpp-has-no-incomplete-format
|
|
|
|
// TODO FMT Fix this test using GCC, it currently times out.
|
|
// UNSUPPORTED: gcc-12
|
|
|
|
// <format>
|
|
|
|
// template<class charT, formattable<charT>... Ts>
|
|
// struct formatter<pair-or-tuple<Ts...>, charT>
|
|
|
|
// template<class ParseContext>
|
|
// constexpr typename ParseContext::iterator
|
|
// parse(ParseContext& ctx);
|
|
|
|
// Note this tests the basics of this function. It's tested in more detail in
|
|
// the format functions tests.
|
|
|
|
#include <cassert>
|
|
#include <concepts>
|
|
#include <format>
|
|
#include <tuple>
|
|
#include <utility>
|
|
|
|
#include "test_format_context.h"
|
|
#include "test_macros.h"
|
|
#include "make_string.h"
|
|
|
|
#define SV(S) MAKE_STRING_VIEW(CharT, S)
|
|
|
|
template <class Arg, class StringViewT>
|
|
constexpr void test(StringViewT fmt) {
|
|
using CharT = typename StringViewT::value_type;
|
|
auto parse_ctx = std::basic_format_parse_context<CharT>(fmt);
|
|
std::formatter<Arg, CharT> formatter;
|
|
static_assert(std::semiregular<decltype(formatter)>);
|
|
|
|
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
|
|
assert(it == fmt.end() - (!fmt.empty() && fmt.back() == '}'));
|
|
}
|
|
|
|
template <class CharT, class Arg>
|
|
constexpr void test() {
|
|
test<Arg>(SV(""));
|
|
test<Arg>(SV("42"));
|
|
|
|
test<Arg>(SV("}"));
|
|
test<Arg>(SV("42}"));
|
|
}
|
|
|
|
template <class CharT>
|
|
constexpr void test() {
|
|
test<CharT, std::tuple<int>>();
|
|
test<CharT, std::tuple<int, CharT>>();
|
|
test<CharT, std::pair<int, CharT>>();
|
|
test<CharT, std::tuple<int, CharT, bool>>();
|
|
}
|
|
|
|
constexpr bool test() {
|
|
test<char>();
|
|
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
|
|
test<wchar_t>();
|
|
#endif
|
|
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**) {
|
|
test();
|
|
static_assert(test());
|
|
|
|
return 0;
|
|
}
|