e4c30c15c8
Variadic function lowering for SPIR-V was initially added in https://github.com/llvm/llvm-project/pull/175076. However, I tried a full OpenMP offloading example that includes a vararg call and hit a few issues: 1) The OpenMP Deivce library function `ompx::printf` was incorrectly being considered a builtin `printf` function that would be handled specifically by the SPIR-V backend. The fix here is to remove the `printf` special handling. 2) We were getting an assert in ModuleVerifier saying the LLVM lifetime intrinsics were being called with an argument that was neither an `alloca` ptr or `poison`. The problem is the `alloca` was replaced with a SPIR-V intrinsic `alloca` in `SPIRVPrepareFunctions`, but the lifetime intrinsic added in `ExpandVariadics` was not lowered to the SPIR-V lifetime intrinsic since `ExpandVariadics` is run after `SPIRVPrepareFunctions`, The fix here is to just run `ExpandVariadics` first. 3) There were `va` intrinsics taking in a `addrspace(4)` pointer that were not being expanded. The fix here is to extend `ExpandVariadics` to support expanding `va` intrinsics with target-specific address spaces. --------- Signed-off-by: Nick Sarnie <nick.sarnie@intel.com> Co-authored-by: Joseph Huber <huberjn@outlook.com>
43 lines
2.3 KiB
LLVM
43 lines
2.3 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK: %[[#ExtImport:]] = OpExtInstImport "OpenCL.std"
|
|
; CHECK: %[[#Char:]] = OpTypeInt 8 0
|
|
; CHECK: %[[#ConstCharPtr:]] = OpTypePointer UniformConstant %[[#Char]]
|
|
; CHECK: %[[#VarargStruct:]] = OpTypeStruct %[[#Char]]
|
|
; CHECK: %[[#VarargStructPtr:]] = OpTypePointer Function %[[#VarargStruct]]
|
|
; CHECK: %[[#CharPtr:]] = OpTypePointer Function %[[#Char]]
|
|
; CHECK: %[[#IntConst:]] = OpConstant %[[#Char]] 97
|
|
; CHECK: %[[#GV:]] = OpVariable %[[#]] UniformConstant %[[#]]
|
|
; CHECK: OpFunction
|
|
; CHECK: %[[#Arg:]] = OpFunctionParameter
|
|
; CHECK: %[[#VarargBuffer1:]] = OpVariable %[[#VarargStructPtr]] Function
|
|
; CHECK: %[[#VarargBuffer2:]] = OpVariable %[[#VarargStructPtr]] Function
|
|
; CHECK: %[[#CastedBuffer1:]] = OpBitcast %[[#CharPtr]] %[[#VarargBuffer1]]
|
|
; CHECK: %[[#GEP1:]] = OpInBoundsPtrAccessChain %[[#CharPtr]] %[[#VarargBuffer1]]
|
|
; CHECK: OpStore %[[#GEP1]] %[[#IntConst]] Aligned 1
|
|
; CHECK: %[[#CastedGV:]] = OpBitcast %[[#ConstCharPtr]] %[[#GV]]
|
|
; CHECK: OpExtInst %[[#]] %[[#ExtImport]] printf %[[#CastedGV]] %[[#CastedBuffer1:]]
|
|
; CHECK: %[[#CastedBuffer2:]] = OpBitcast %[[#CharPtr]] %[[#VarargBuffer2]]
|
|
; CHECK: %[[#GEP2:]] = OpInBoundsPtrAccessChain %[[#CharPtr]] %[[#VarargBuffer2]]
|
|
; CHECK: OpStore %[[#GEP2]] %[[#IntConst]] Aligned 1
|
|
; CHECK: OpExtInst %[[#]] %[[#ExtImport]] printf %[[#Arg]] %[[#CastedBuffer2:]]
|
|
; CHECK: OpFunctionEnd
|
|
|
|
%struct = type { [6 x i8] }
|
|
|
|
@FmtStr = internal addrspace(2) constant [6 x i8] c"c=%c\0A\00", align 1
|
|
|
|
define spir_kernel void @foo(ptr addrspace(2) %_arg_fmt) {
|
|
entry:
|
|
%r1 = tail call spir_func i32 (ptr addrspace(2), ...) @_Z6printfPU3AS2Kcz(ptr addrspace(2) @FmtStr, i8 signext 97)
|
|
%r2 = tail call spir_func i32 (ptr addrspace(2), ...) @_Z18__spirv_ocl_printfPU3AS2Kcz(ptr addrspace(2) %_arg_fmt, i8 signext 97)
|
|
ret void
|
|
}
|
|
|
|
declare dso_local spir_func i32 @_Z6printfPU3AS2Kcz(ptr addrspace(2), ...)
|
|
declare dso_local spir_func i32 @_Z18__spirv_ocl_printfPU3AS2Kcz(ptr addrspace(2), ...)
|