3fd4213059
Lambdas are implemented as regular classes internally, and the captured variables end up as members there. Do not diagnose those - the check should cover only regular classes and structs. Differential Revision: https://reviews.llvm.org/D131780
50 lines
1.7 KiB
C++
50 lines
1.7 KiB
C++
//===--- AvoidConstOrRefDataMembersCheck.cpp - clang-tidy -----------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AvoidConstOrRefDataMembersCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace cppcoreguidelines {
|
|
namespace {
|
|
|
|
AST_MATCHER(FieldDecl, isMemberOfLambda) {
|
|
return Node.getParent()->isLambda();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
void AvoidConstOrRefDataMembersCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(fieldDecl(unless(isMemberOfLambda()),
|
|
hasType(hasCanonicalType(referenceType())))
|
|
.bind("ref"),
|
|
this);
|
|
Finder->addMatcher(fieldDecl(unless(isMemberOfLambda()),
|
|
hasType(qualType(isConstQualified())))
|
|
.bind("const"),
|
|
this);
|
|
}
|
|
|
|
void AvoidConstOrRefDataMembersCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
if (const auto *MatchedDecl = Result.Nodes.getNodeAs<FieldDecl>("ref"))
|
|
diag(MatchedDecl->getLocation(), "member %0 of type %1 is a reference")
|
|
<< MatchedDecl << MatchedDecl->getType();
|
|
if (const auto *MatchedDecl = Result.Nodes.getNodeAs<FieldDecl>("const"))
|
|
diag(MatchedDecl->getLocation(), "member %0 of type %1 is const qualified")
|
|
<< MatchedDecl << MatchedDecl->getType();
|
|
}
|
|
|
|
} // namespace cppcoreguidelines
|
|
} // namespace tidy
|
|
} // namespace clang
|