This is how it should've been and brings it more in line with std::string_view. There should be no functional change here. This is mostly mechanical from a custom clang-tidy check, with a lot of manual fixups. It uncovers a lot of minor inefficiencies. This doesn't actually modify StringRef yet, I'll do that in a follow-up.
37 lines
1.2 KiB
C++
37 lines
1.2 KiB
C++
//===-- BreakpointBase.cpp --------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "BreakpointBase.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
|
|
using namespace lldb_vscode;
|
|
|
|
BreakpointBase::BreakpointBase(const llvm::json::Object &obj)
|
|
: condition(std::string(GetString(obj, "condition"))),
|
|
hitCondition(std::string(GetString(obj, "hitCondition"))),
|
|
logMessage(std::string(GetString(obj, "logMessage"))) {}
|
|
|
|
void BreakpointBase::SetCondition() { bp.SetCondition(condition.c_str()); }
|
|
|
|
void BreakpointBase::SetHitCondition() {
|
|
uint64_t hitCount = 0;
|
|
if (llvm::to_integer(hitCondition, hitCount))
|
|
bp.SetIgnoreCount(hitCount - 1);
|
|
}
|
|
|
|
void BreakpointBase::UpdateBreakpoint(const BreakpointBase &request_bp) {
|
|
if (condition != request_bp.condition) {
|
|
condition = request_bp.condition;
|
|
SetCondition();
|
|
}
|
|
if (hitCondition != request_bp.hitCondition) {
|
|
hitCondition = request_bp.hitCondition;
|
|
SetHitCondition();
|
|
}
|
|
}
|