I’m seeing a series of errors when trying to run the cmake configure step on macOS when the cmake generator is set to Xcode. All is well if I use the Ninja or Unix Makefile generators. Messages are all of the form: ~~~ CMake Error at …llvm-project/clang/cmake/modules/AddClang.cmake:120 (target_compile_definitions): Cannot specify compile definitions for target "obj.clangBasic" which is not built by this project. Call Stack (most recent call first): …llvm-project/clang/lib/Basic/CMakeLists.txt:57 (add_clang_library) ~~~ The remaining errors are similar but mention targets obj.clangAPINotes, obj.clangLex, obj.clangParse, and so on. The regression appears to have been introduced by commit 09fa2f012fcc (Oct 14 2024) which added the code in this area. My proposed solution is simply to add a test to ensure that the obj.x target exists before setting its compile definitions. There is precedent doing just this in both clang/cmake/modules/AddClang.cmake and clang/lib/support/CMakeLists.txt as well as in the “MSVC AND NOT CLANG_LINK_CLANG_DYLIB” path immediately above the offending line. I’ve also made a couple of grammatical tweaks in the comments surrounding this code. In case it's relevant, the cmake settings and definitions I've used to trigger these errors is: ~~~bash GENERATOR="Xcode" OUTDIR=build_macos cmake \ -S "$SCRIPT_DIR/llvm" \ -B "$SCRIPT_DIR/$OUTDIR" \ -G "$GENERATOR" \ -D CMAKE_BUILD_TYPE=Release \ -D CMAKE_OSX_ARCHITECTURES=arm64 \ -D LLVM_PARALLEL_LINK_JOBS=1 \ -D LLVM_ENABLE_PROJECTS="clang;lld" \ -D LLVM_TARGETS_TO_BUILD=RISCV \ -D LLVM_DEFAULT_TARGET_TRIPLE=riscv32-unknown-elf \ -D LLVM_OPTIMIZED_TABLEGEN=Yes ~~~ (cmake v3.31.1, Xcode 16.1. I know that not all of these variables are useful for the Xcode generator!) Co-authored-by: Paul Bowen-Huggett <phuggett@keysom.io>
230 lines
7.6 KiB
CMake
230 lines
7.6 KiB
CMake
include(GNUInstallDirs)
|
|
include(LLVMDistributionSupport)
|
|
|
|
function(clang_tablegen)
|
|
# Syntax:
|
|
# clang_tablegen output-file [tablegen-arg ...] SOURCE source-file
|
|
# [[TARGET cmake-target-name] [DEPENDS extra-dependency ...]]
|
|
#
|
|
# Generates a custom command for invoking tblgen as
|
|
#
|
|
# tblgen source-file -o=output-file tablegen-arg ...
|
|
#
|
|
# and, if cmake-target-name is provided, creates a custom target for
|
|
# executing the custom command depending on output-file. It is
|
|
# possible to list more files to depend after DEPENDS.
|
|
|
|
cmake_parse_arguments(CTG "" "SOURCE;TARGET" "" ${ARGN})
|
|
|
|
if( NOT CTG_SOURCE )
|
|
message(FATAL_ERROR "SOURCE source-file required by clang_tablegen")
|
|
endif()
|
|
|
|
set( CLANG_TABLEGEN_ARGUMENTS "" )
|
|
set( LLVM_TARGET_DEFINITIONS ${CTG_SOURCE} )
|
|
tablegen(CLANG ${CTG_UNPARSED_ARGUMENTS} ${CLANG_TABLEGEN_ARGUMENTS})
|
|
|
|
if(CTG_TARGET)
|
|
add_public_tablegen_target(${CTG_TARGET})
|
|
set_property(GLOBAL APPEND PROPERTY CLANG_TABLEGEN_TARGETS ${CTG_TARGET})
|
|
endif()
|
|
endfunction(clang_tablegen)
|
|
|
|
macro(set_clang_windows_version_resource_properties name)
|
|
if(DEFINED windows_resource_file)
|
|
set_windows_version_resource_properties(${name} ${windows_resource_file}
|
|
VERSION_MAJOR ${CLANG_VERSION_MAJOR}
|
|
VERSION_MINOR ${CLANG_VERSION_MINOR}
|
|
VERSION_PATCHLEVEL ${CLANG_VERSION_PATCHLEVEL}
|
|
VERSION_STRING "${CLANG_VERSION}"
|
|
PRODUCT_NAME "clang")
|
|
endif()
|
|
endmacro()
|
|
|
|
macro(add_clang_subdirectory name)
|
|
add_llvm_subdirectory(CLANG TOOL ${name})
|
|
endmacro()
|
|
|
|
macro(add_clang_library name)
|
|
cmake_parse_arguments(ARG
|
|
"SHARED;STATIC;INSTALL_WITH_TOOLCHAIN"
|
|
""
|
|
"ADDITIONAL_HEADERS"
|
|
${ARGN})
|
|
set(srcs)
|
|
if(MSVC_IDE OR XCODE)
|
|
# Add public headers
|
|
file(RELATIVE_PATH lib_path
|
|
${CLANG_SOURCE_DIR}/lib/
|
|
${CMAKE_CURRENT_SOURCE_DIR}
|
|
)
|
|
if(NOT lib_path MATCHES "^[.][.]")
|
|
file( GLOB_RECURSE headers
|
|
${CLANG_SOURCE_DIR}/include/clang/${lib_path}/*.h
|
|
${CLANG_SOURCE_DIR}/include/clang/${lib_path}/*.def
|
|
)
|
|
set_source_files_properties(${headers} PROPERTIES HEADER_FILE_ONLY ON)
|
|
|
|
file( GLOB_RECURSE tds
|
|
${CLANG_SOURCE_DIR}/include/clang/${lib_path}/*.td
|
|
)
|
|
source_group("TableGen descriptions" FILES ${tds})
|
|
set_source_files_properties(${tds} PROPERTIES HEADER_FILE_ONLY ON)
|
|
|
|
if(headers OR tds)
|
|
set(srcs ${headers} ${tds})
|
|
endif()
|
|
endif()
|
|
endif(MSVC_IDE OR XCODE)
|
|
if(srcs OR ARG_ADDITIONAL_HEADERS)
|
|
set(srcs
|
|
ADDITIONAL_HEADERS
|
|
${srcs}
|
|
${ARG_ADDITIONAL_HEADERS} # It may contain unparsed unknown args.
|
|
)
|
|
endif()
|
|
|
|
if(ARG_SHARED AND ARG_STATIC)
|
|
set(LIBTYPE SHARED STATIC)
|
|
elseif(ARG_SHARED)
|
|
set(LIBTYPE SHARED)
|
|
else()
|
|
# llvm_add_library ignores BUILD_SHARED_LIBS if STATIC is explicitly set,
|
|
# so we need to handle it here.
|
|
if(BUILD_SHARED_LIBS)
|
|
set(LIBTYPE SHARED)
|
|
else()
|
|
set(LIBTYPE STATIC)
|
|
endif()
|
|
if(NOT XCODE AND NOT MSVC_IDE)
|
|
# The Xcode generator doesn't handle object libraries correctly.
|
|
# The Visual Studio CMake generator does handle object libraries
|
|
# correctly, but it is preferable to list the libraries with their
|
|
# source files (instead of the object files and the source files in
|
|
# a separate target in the "Object Libraries" folder)
|
|
list(APPEND LIBTYPE OBJECT)
|
|
endif()
|
|
set_property(GLOBAL APPEND PROPERTY CLANG_STATIC_LIBS ${name})
|
|
endif()
|
|
llvm_add_library(${name} ${LIBTYPE} ${ARG_UNPARSED_ARGUMENTS} ${srcs})
|
|
|
|
if(MSVC AND NOT CLANG_LINK_CLANG_DYLIB)
|
|
# Make sure all consumers also turn off visibility macros so they're not
|
|
# trying to dllimport symbols.
|
|
target_compile_definitions(${name} PUBLIC CLANG_BUILD_STATIC)
|
|
if(TARGET "obj.${name}")
|
|
target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC)
|
|
endif()
|
|
elseif(TARGET "obj.${name}" AND NOT ARG_SHARED AND NOT ARG_STATIC)
|
|
# Clang component libraries linked to clang-cpp are declared without SHARED or STATIC
|
|
target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS)
|
|
endif()
|
|
|
|
set(libs ${name})
|
|
if(ARG_SHARED AND ARG_STATIC)
|
|
list(APPEND libs ${name}_static)
|
|
endif()
|
|
|
|
foreach(lib ${libs})
|
|
if(TARGET ${lib})
|
|
target_link_libraries(${lib} INTERFACE ${LLVM_COMMON_LIBS})
|
|
|
|
if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ARG_INSTALL_WITH_TOOLCHAIN)
|
|
get_target_export_arg(${name} Clang export_to_clangtargets UMBRELLA clang-libraries)
|
|
install(TARGETS ${lib}
|
|
COMPONENT ${lib}
|
|
${export_to_clangtargets}
|
|
LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX}
|
|
ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX}
|
|
RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}")
|
|
|
|
if (NOT LLVM_ENABLE_IDE)
|
|
add_llvm_install_targets(install-${lib}
|
|
DEPENDS ${lib}
|
|
COMPONENT ${lib})
|
|
endif()
|
|
|
|
set_property(GLOBAL APPEND PROPERTY CLANG_LIBS ${lib})
|
|
endif()
|
|
set_property(GLOBAL APPEND PROPERTY CLANG_EXPORTS ${lib})
|
|
else()
|
|
# Add empty "phony" target
|
|
add_custom_target(${lib})
|
|
endif()
|
|
endforeach()
|
|
|
|
set_clang_windows_version_resource_properties(${name})
|
|
endmacro(add_clang_library)
|
|
|
|
macro(add_clang_executable name)
|
|
add_llvm_executable( ${name} ${ARGN} )
|
|
set_clang_windows_version_resource_properties(${name})
|
|
set_target_properties(${name} PROPERTIES XCODE_GENERATE_SCHEME ON)
|
|
endmacro(add_clang_executable)
|
|
|
|
macro(add_clang_tool name)
|
|
cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN})
|
|
if (NOT CLANG_BUILD_TOOLS)
|
|
set(EXCLUDE_FROM_ALL ON)
|
|
endif()
|
|
if(ARG_GENERATE_DRIVER
|
|
AND LLVM_TOOL_LLVM_DRIVER_BUILD
|
|
AND (NOT LLVM_DISTRIBUTION_COMPONENTS OR ${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS)
|
|
)
|
|
set(get_obj_args ${ARGN})
|
|
list(FILTER get_obj_args EXCLUDE REGEX "^SUPPORT_PLUGINS$")
|
|
generate_llvm_objects(${name} ${get_obj_args})
|
|
add_custom_target(${name} DEPENDS llvm-driver clang-resource-headers)
|
|
else()
|
|
add_clang_executable(${name} ${ARGN})
|
|
add_dependencies(${name} clang-resource-headers)
|
|
|
|
if (CLANG_BUILD_TOOLS)
|
|
get_target_export_arg(${name} Clang export_to_clangtargets)
|
|
install(TARGETS ${name}
|
|
${export_to_clangtargets}
|
|
RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}"
|
|
COMPONENT ${name})
|
|
|
|
if(NOT LLVM_ENABLE_IDE)
|
|
add_llvm_install_targets(install-${name}
|
|
DEPENDS ${name}
|
|
COMPONENT ${name})
|
|
endif()
|
|
set_property(GLOBAL APPEND PROPERTY CLANG_EXPORTS ${name})
|
|
endif()
|
|
endif()
|
|
set_target_properties(${name} PROPERTIES XCODE_GENERATE_SCHEME ON)
|
|
endmacro()
|
|
|
|
macro(add_clang_symlink name dest)
|
|
get_property(LLVM_DRIVER_TOOLS GLOBAL PROPERTY LLVM_DRIVER_TOOLS)
|
|
if(LLVM_TOOL_LLVM_DRIVER_BUILD
|
|
AND ${dest} IN_LIST LLVM_DRIVER_TOOLS
|
|
AND (NOT LLVM_DISTRIBUTION_COMPONENTS OR ${dest} IN_LIST LLVM_DISTRIBUTION_COMPONENTS)
|
|
)
|
|
set_property(GLOBAL APPEND PROPERTY LLVM_DRIVER_TOOL_ALIASES_${dest} ${name})
|
|
else()
|
|
llvm_add_tool_symlink(CLANG ${name} ${dest} ALWAYS_GENERATE)
|
|
# Always generate install targets
|
|
llvm_install_symlink(CLANG ${name} ${dest} ALWAYS_GENERATE)
|
|
endif()
|
|
endmacro()
|
|
|
|
function(clang_target_link_libraries target type)
|
|
if (TARGET obj.${target})
|
|
target_link_libraries(obj.${target} ${ARGN})
|
|
endif()
|
|
|
|
get_property(LLVM_DRIVER_TOOLS GLOBAL PROPERTY LLVM_DRIVER_TOOLS)
|
|
if(LLVM_TOOL_LLVM_DRIVER_BUILD AND ${target} IN_LIST LLVM_DRIVER_TOOLS)
|
|
set(target llvm-driver)
|
|
endif()
|
|
|
|
if (CLANG_LINK_CLANG_DYLIB)
|
|
target_link_libraries(${target} ${type} clang-cpp)
|
|
else()
|
|
target_link_libraries(${target} ${type} ${ARGN})
|
|
endif()
|
|
endfunction()
|