David Justo 2dc22615fd

[ASan] Honor allocator_may_return_null when set through user-function and fix large alloc edge case (#117929) ...

**Related:** #117925

**About this PR:**
This PR performs 3 small but related fixes for ASan users on Windows:
1. It ensures that the `allocator_may_return_null` flag is honored when
set through the user function `__asan_default_options`. For more
details, please see: #117925
2. It adds a missing `AllocatorMayReturnNull()` check inside
`InternalAlloc` that's needed to avoid error'ing out when the allocator
_correctly_ returns `null` when `allocator_may_return_null` is set.
3. In `sanitizer_win`'s `ReturnNullptrOnOOMOrDie`, it allows returning
`null` when the last error is set to `ERROR_INVALID_PARAMETER` which may
be set by `VirtualAlloc` on WIndows when attempting to allocate
exceedingly large memory.

I've added test cases that should cover these new behaviors. Happy to
take on any feedback as well. Thank you :-)

---------

Co-authored-by: David Justo <dajusto@microsoft.com>

2024-12-11 10:21:35 +01:00

..

msvc

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

aligned_mallocs.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

allocator_may_return_null_limits.cpp

[ASan] Honor allocator_may_return_null when set through user-function and fix large alloc edge case (#117929)

2024-12-11 10:21:35 +01:00

allocators_sanity.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

beginthreadex.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

bind_io_completion_callback.cpp

…

bitfield_uaf.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

bitfield.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

breakpoint.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

calloc_left_oob.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

calloc_right_oob.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

calloc_uaf.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

coverage-basic.cpp

[sanitizer][win] Fix Atexit() on MinGW asan_dynamic runtime

2023-04-10 23:21:16 +08:00

crash_read_write.cpp

…

crt_initializers.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW

2023-04-21 21:25:54 +08:00

delay_dbghelp.cpp

[compiler-rt] [test] Remove an unintended grep parameter

2024-10-20 22:56:41 +03:00

demangled_names.cpp

[asan][test][win] Fix demangled_names test on MSVC target

2023-04-21 21:49:05 +08:00

dll_aligned_mallocs.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_allocators_sanity.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_global_dead_strip.c

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

dll_heap_allocation.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_host.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_intercept_memchr.cpp

[compiler-rt] [test] [asan] Fix Windows tests in i386 mode after StripFunctionName() improvements

2023-05-29 22:49:34 +03:00

dll_intercept_memcpy_indirect.cpp

[asan] Fix Windows tests after StripFunctionName() improvements

2023-05-25 17:54:50 +02:00

dll_intercept_memcpy.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (4)

2023-05-16 19:53:49 +08:00

dll_intercept_memset.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (4)

2023-05-16 19:53:49 +08:00

dll_intercept_strlen.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_malloc_left_oob.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_malloc_uaf.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_noreturn.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_null_deref.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_operator_array_new_left_oob.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_operator_array_new_with_dtor_left_oob.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_poison_unpoison.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_report_globals_symbolization_at_startup.cpp

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

dll_stack_use_after_return.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_thread_stack_array_left_oob.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

dll_unload.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

double_free.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

double_operator_delete.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

free_hook_realloc.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

fuse-lld-globals.cpp

[ASan] rename left/right to before/after.

2022-09-06 13:25:15 -07:00

fuse-lld.cpp

…

global_const_string_oob.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

global_const_string.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

global_dead_strip.c

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

heapalloc_dll_double_free.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_dll_unload_realloc_uaf.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_doublefree.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_flags_fallback.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_huge.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_rtl_transfer.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_sanity.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

heapalloc_transfer.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_uaf.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc_zero_size.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heapalloc.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heaprealloc_alloc_zero.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heaprealloc_zero_size.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

heaprealloc.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

hello_world.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

illegal_instruction.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

integer_divide_by_zero.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

intercept_memcpy.cpp

[asan] Fix Windows tests after StripFunctionName() improvements

2023-05-25 17:54:50 +02:00

intercept_strdup.cpp

Reapply "[sanitizer][asan][win] Intercept _strdup on Windows (#85006)

2024-03-13 16:11:21 -07:00

intercept_strlen.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

issue64990.cpp

[asan][windows] fix issue64990 test (#85137)

2024-03-13 15:34:12 -07:00

lit.local.cfg.py

[NFC][Py Reformat] Reformat python files in the rest of the dirs

2023-05-25 11:17:05 +02:00

longjmp.cpp

…

malloc_left_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

malloc_right_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

malloc_uaf.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

null_deref_multiple_dlls.cpp

[asan] Fix Windows tests

2024-08-08 00:17:19 -07:00

null_deref.cpp

…

oom.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

operator_array_new_left_oob.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_array_new_right_oob.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_array_new_uaf.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_array_new_with_dtor_left_oob.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_delete_wrong_argument.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_new_left_oob.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_new_right_oob.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

operator_new_uaf.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

queue_user_work_item_report.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

queue_user_work_item.cpp

…

realloc_left_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

realloc_right_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

realloc_uaf.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

recalloc_sanity.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

report_after_syminitialize.cpp

[asan][test][win] Make report_after_syminitialize test less brittle

2023-04-02 15:37:27 +08:00

report_globals_reload_dll.cpp

[asan] Fix Windows tests

2024-08-08 00:17:19 -07:00

report_globals_vs_freelibrary.cpp

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

rtlallocateheap_dll_unload_double_free.cpp

[asan][test][win] Remove REQUIRES: asan-rtl-heap-interception

2023-05-16 19:53:49 +08:00

rtlallocateheap_dll_unload_realloc.cpp

[asan][test][win] Remove REQUIRES: asan-rtl-heap-interception

2023-05-16 19:53:49 +08:00

rtlallocateheap_flags_fallback.cpp

[asan][test][win] Remove REQUIRES: asan-rtl-heap-interception

2023-05-16 19:53:49 +08:00

rtlallocateheap_zero.cpp

[asan][test][win] Remove REQUIRES: asan-rtl-heap-interception

2023-05-16 19:53:49 +08:00

rtlallocateheap.cpp

[asan][test][win] Remove REQUIRES: asan-rtl-heap-interception

2023-05-16 19:53:49 +08:00

sanitizer_purge.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

shadow_conflict_32.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (3)

2023-05-16 19:53:49 +08:00

shadow_mapping_failure.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

sse_misalignment.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW

2023-04-21 21:25:54 +08:00

stack_array_left_oob.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

stack_array_right_oob.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

stack_array_sanity.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

stack_use_after_return.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

symbols_path.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

thread_simple.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

thread_stack_array_left_oob.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

thread_stack_array_right_oob.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

thread_stack_reuse.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

thread_stress.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

thread_suspended.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

unsymbolized.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

use_after_realloc.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

user-exception.cpp

[asan][test][win] Port more tests to not use clang-cl on MinGW (2)

2023-05-16 19:53:49 +08:00

windows_h.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00

wrong_downcast_on_heap.cpp

Revert "[asan][win][msvc] override new and delete and seperate TUs (#68754)"

2023-12-01 22:28:12 +00:00

wrong_downcast_on_stack.cpp

[asan][test][win] Port trivial tests to not use clang-cl on MinGW

2023-04-21 21:25:49 +08:00