3717048496
This is allowed by the OpenMP and F23 standards. But variables in a namelist are not allowed in OpenMP privatisation. I suspect this was an oversight. If we allow this we run into problems masking the original symbol with the symbol for the reduction variable when the variable is accessed via a namelist initialised as a global variable. See #101907. One solution for this would be to force the namelist to always be initilized inside of the block in which it is used (therefore using the correct mapping for the reduction variable), but this could make some production applications slow. I tentatively think it is probably better to disallow a (perhaps mistaken) edge case of the standards with (I think) little practical use, than to make real applications slow in order to make this work. If reviewers would rather keep to the letter of the standard, see #109303 which implements the alternative solution. I'm open to either path forward. Fixes #101907
53 lines
2.0 KiB
C++
53 lines
2.0 KiB
C++
//===-- lib/Semantics/check-namelist.cpp ----------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "check-namelist.h"
|
|
|
|
namespace Fortran::semantics {
|
|
|
|
void NamelistChecker::Leave(const parser::NamelistStmt &nmlStmt) {
|
|
for (const auto &x : nmlStmt.v) {
|
|
if (const auto *nml{std::get<parser::Name>(x.t).symbol}) {
|
|
for (const auto &nmlObjName : std::get<std::list<parser::Name>>(x.t)) {
|
|
const auto *nmlObjSymbol{nmlObjName.symbol};
|
|
if (nmlObjSymbol) {
|
|
if (IsAssumedSizeArray(*nmlObjSymbol)) { // C8104
|
|
context_.Say(nmlObjName.source,
|
|
"A namelist group object '%s' must not be assumed-size"_err_en_US,
|
|
nmlObjSymbol->name());
|
|
}
|
|
if (nml->attrs().test(Attr::PUBLIC) &&
|
|
nmlObjSymbol->attrs().test(Attr::PRIVATE)) { // C8105
|
|
context_.Say(nmlObjName.source,
|
|
"A PRIVATE namelist group object '%s' must not be in a "
|
|
"PUBLIC namelist"_err_en_US,
|
|
nmlObjSymbol->name());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
void NamelistChecker::Leave(const parser::LocalitySpec::Reduce &x) {
|
|
for (const parser::Name &name : std::get<std::list<parser::Name>>(x.t)) {
|
|
Symbol *sym{name.symbol};
|
|
// This is not disallowed by the standard, but would be difficult to
|
|
// support. This has to go here not with the other checks for locality specs
|
|
// in resolve-names.cpp so that it is done after the InNamelist flag is
|
|
// applied.
|
|
if (sym && sym->GetUltimate().test(Symbol::Flag::InNamelist)) {
|
|
context_.Say(name.source,
|
|
"NAMELIST variable '%s' not allowed in a REDUCE locality-spec"_err_en_US,
|
|
name.ToString());
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace Fortran::semantics
|