579e70c9b0
We want to do a better job presenting errors that occur when evaluating expressions. Key to this effort is getting away from a model where all errors are spat out onto a stream where the client has to take or leave all of them. To this end, this patch adds a new class, DiagnosticManager, which contains errors produced by the compiler or by LLDB as an expression is created. The DiagnosticManager can dump itself to a log as well as to a string. Clients will (in the future) be able to filter out the errors they're interested in by ID or present subsets of these errors to the user. This patch is not intended to change the *users* of errors - only to thread DiagnosticManagers to all the places where streams are used. I also attempt to standardize our use of errors a bit, removing trailing newlines and making clients omit 'error:', 'warning:' etc. and instead pass the Severity flag. The patch is testsuite-neutral, with modifications to one part of the MI tests because it relied on "error: error:" being erroneously printed. This patch fixes the MI variable handling and the testcase. <rdar://problem/22864976> llvm-svn: 263859
100 lines
3.2 KiB
C++
100 lines
3.2 KiB
C++
//===-- GoUserExpression.h --------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_GoUserExpression_h_
|
|
#define liblldb_GoUserExpression_h_
|
|
|
|
// C Includes
|
|
// C++ Includes
|
|
#include <memory>
|
|
|
|
// Other libraries and framework includes
|
|
// Project includes
|
|
#include "lldb/lldb-forward.h"
|
|
#include "lldb/lldb-private.h"
|
|
#include "lldb/Expression/UserExpression.h"
|
|
#include "lldb/Expression/ExpressionVariable.h"
|
|
#include "lldb/Target/ExecutionContext.h"
|
|
|
|
namespace lldb_private
|
|
{
|
|
class GoParser;
|
|
|
|
class GoPersistentExpressionState : public PersistentExpressionState
|
|
{
|
|
public:
|
|
GoPersistentExpressionState();
|
|
|
|
ConstString GetNextPersistentVariableName() override;
|
|
|
|
void RemovePersistentVariable(lldb::ExpressionVariableSP variable) override;
|
|
|
|
lldb::addr_t
|
|
LookupSymbol(const ConstString &name) override
|
|
{
|
|
return LLDB_INVALID_ADDRESS;
|
|
}
|
|
|
|
static bool
|
|
classof(const PersistentExpressionState *pv)
|
|
{
|
|
return pv->getKind() == PersistentExpressionState::eKindGo;
|
|
}
|
|
|
|
private:
|
|
uint32_t m_next_persistent_variable_id; ///< The counter used by GetNextResultName().
|
|
};
|
|
|
|
//----------------------------------------------------------------------
|
|
/// @class GoUserExpression GoUserExpression.h "lldb/Expression/GoUserExpression.h"
|
|
/// @brief Encapsulates a single expression for use with Go
|
|
///
|
|
/// LLDB uses expressions for various purposes, notably to call functions
|
|
/// and as a backend for the expr command. GoUserExpression encapsulates
|
|
/// the objects needed to parse and interpret an expression.
|
|
//----------------------------------------------------------------------
|
|
class GoUserExpression : public UserExpression
|
|
{
|
|
public:
|
|
GoUserExpression(ExecutionContextScope &exe_scope, const char *expr, const char *expr_prefix,
|
|
lldb::LanguageType language, ResultType desired_type, const EvaluateExpressionOptions &options);
|
|
|
|
bool
|
|
Parse(DiagnosticManager &diagnostic_manager, ExecutionContext &exe_ctx,
|
|
lldb_private::ExecutionPolicy execution_policy, bool keep_result_in_memory,
|
|
bool generate_debug_info) override;
|
|
|
|
lldb::ExpressionResults
|
|
Execute(DiagnosticManager &diagnostic_manager, ExecutionContext &exe_ctx,
|
|
const EvaluateExpressionOptions &options, lldb::UserExpressionSP &shared_ptr_to_me,
|
|
lldb::ExpressionVariableSP &result) override;
|
|
|
|
bool
|
|
CanInterpret() override
|
|
{
|
|
return true;
|
|
}
|
|
bool
|
|
FinalizeJITExecution(DiagnosticManager &diagnostic_manager, ExecutionContext &exe_ctx,
|
|
lldb::ExpressionVariableSP &result,
|
|
lldb::addr_t function_stack_bottom = LLDB_INVALID_ADDRESS,
|
|
lldb::addr_t function_stack_top = LLDB_INVALID_ADDRESS) override
|
|
{
|
|
return true;
|
|
}
|
|
|
|
private:
|
|
class GoInterpreter;
|
|
std::unique_ptr<GoInterpreter> m_interpreter;
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_GoUserExpression_h_
|