bf789b1957
For the longest time we used `AAValueSimplify` and `genericValueTraversal` to determine "potential values". This was problematic for many reasons: - We recomputed the result a lot as there was no caching for the 9 locations calling `genericValueTraversal`. - We added the idea of "intra" vs. "inter" procedural simplification only as an afterthought. `genericValueTraversal` did offer an option but `AAValueSimplify` did not. Thus, we might end up with "too much" simplification in certain situations and then gave up on it. - Because `genericValueTraversal` was not a real `AA` we ended up with problems like the infinite recursion bug (#54981) as well as code duplication. This patch introduces `AAPotentialValues` and replaces the `AAValueSimplify` uses with it. `genericValueTraversal` is folded into `AAPotentialValues` as are the instruction simplifications performed in `AAValueSimplify` before. We further distinguish "intra" and "inter" procedural simplification now. `AAValueSimplify` was not deleted as we haven't ported the re-materialization of instructions yet. There are other differences over the former handling, e.g., we may not fold trivially foldable instructions right now, e.g., `add i32 1, 1` is not folded to `i32 2` but if an operand would be simplified to `i32 1` we would fold it still. We are also even more aware of function/SCC boundaries in CGSCC passes, which is good even if some tests look like they regress. Fixes: https://github.com/llvm/llvm-project/issues/54981 Note: A previous version was flawed and consequently reverted in 6555558a80589d1c5a1154b92cc3af9495f8f86c.
76 lines
4.2 KiB
LLVM
76 lines
4.2 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
|
|
; RUN: opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=2 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=2 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_OPM,NOT_CGSCC_NPM,NOT_TUNIT_OPM,IS__TUNIT____,IS________NPM,IS__TUNIT_NPM
|
|
; RUN: opt -attributor-cgscc -enable-new-pm=0 -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_NPM,IS__CGSCC____,IS________OPM,IS__CGSCC_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_OPM,IS__CGSCC____,IS________NPM,IS__CGSCC_NPM
|
|
|
|
target datalayout = "E-p:64:64:64-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128"
|
|
|
|
define internal i32 @callee(i1 %C, i32* %P) {
|
|
; IS__CGSCC_OPM: Function Attrs: argmemonly nofree norecurse nosync nounwind readonly willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@callee
|
|
; IS__CGSCC_OPM-SAME: (i32* noalias nocapture nofree noundef nonnull readonly align 4 dereferenceable(4) [[P:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__CGSCC_OPM-NEXT: br label [[F:%.*]]
|
|
; IS__CGSCC_OPM: T:
|
|
; IS__CGSCC_OPM-NEXT: unreachable
|
|
; IS__CGSCC_OPM: F:
|
|
; IS__CGSCC_OPM-NEXT: [[X:%.*]] = load i32, i32* [[P]], align 4
|
|
; IS__CGSCC_OPM-NEXT: ret i32 [[X]]
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: argmemonly nofree norecurse nosync nounwind readonly willreturn
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@callee
|
|
; IS__CGSCC_NPM-SAME: (i32 [[TMP0:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__CGSCC_NPM-NEXT: [[P_PRIV:%.*]] = alloca i32, align 4
|
|
; IS__CGSCC_NPM-NEXT: store i32 [[TMP0]], i32* [[P_PRIV]], align 4
|
|
; IS__CGSCC_NPM-NEXT: br label [[F:%.*]]
|
|
; IS__CGSCC_NPM: T:
|
|
; IS__CGSCC_NPM-NEXT: unreachable
|
|
; IS__CGSCC_NPM: F:
|
|
; IS__CGSCC_NPM-NEXT: [[X:%.*]] = load i32, i32* [[P_PRIV]], align 4
|
|
; IS__CGSCC_NPM-NEXT: ret i32 [[X]]
|
|
;
|
|
br i1 %C, label %T, label %F
|
|
|
|
T: ; preds = %0
|
|
ret i32 17
|
|
|
|
F: ; preds = %0
|
|
%X = load i32, i32* %P ; <i32> [#uses=1]
|
|
ret i32 %X
|
|
}
|
|
|
|
define i32 @foo() {
|
|
; IS__TUNIT____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__TUNIT____-LABEL: define {{[^@]+}}@foo
|
|
; IS__TUNIT____-SAME: () #[[ATTR0:[0-9]+]] {
|
|
; IS__TUNIT____-NEXT: [[A:%.*]] = alloca i32, align 4
|
|
; IS__TUNIT____-NEXT: ret i32 17
|
|
;
|
|
; IS__CGSCC_OPM: Function Attrs: nofree nosync nounwind readnone willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@foo
|
|
; IS__CGSCC_OPM-SAME: () #[[ATTR1:[0-9]+]] {
|
|
; IS__CGSCC_OPM-NEXT: [[A:%.*]] = alloca i32, align 4
|
|
; IS__CGSCC_OPM-NEXT: store i32 17, i32* [[A]], align 4
|
|
; IS__CGSCC_OPM-NEXT: [[X:%.*]] = call i32 @callee(i32* noalias nocapture nofree noundef nonnull readonly align 4 dereferenceable(4) [[A]]) #[[ATTR2:[0-9]+]]
|
|
; IS__CGSCC_OPM-NEXT: ret i32 [[X]]
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: nofree nosync nounwind readnone willreturn
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@foo
|
|
; IS__CGSCC_NPM-SAME: () #[[ATTR1:[0-9]+]] {
|
|
; IS__CGSCC_NPM-NEXT: [[X:%.*]] = call i32 @callee(i32 17) #[[ATTR2:[0-9]+]]
|
|
; IS__CGSCC_NPM-NEXT: ret i32 [[X]]
|
|
;
|
|
%A = alloca i32 ; <i32*> [#uses=2]
|
|
store i32 17, i32* %A
|
|
%X = call i32 @callee( i1 false, i32* %A ) ; <i32> [#uses=1]
|
|
ret i32 %X
|
|
}
|
|
|
|
;.
|
|
; IS__TUNIT____: attributes #[[ATTR0]] = { nofree norecurse nosync nounwind readnone willreturn }
|
|
;.
|
|
; IS__CGSCC____: attributes #[[ATTR0:[0-9]+]] = { argmemonly nofree norecurse nosync nounwind readonly willreturn }
|
|
; IS__CGSCC____: attributes #[[ATTR1:[0-9]+]] = { nofree nosync nounwind readnone willreturn }
|
|
; IS__CGSCC____: attributes #[[ATTR2:[0-9]+]] = { readonly willreturn }
|
|
;.
|