9f732af583
As a follow up to {D123271}, LBR ranges that are too big should also be considered as invalid.
For example, the last two pairs in the following trace form a range [0x0d7b02b0, 0x368ba706] that covers a ton of functions in the binary. Such oversized range should also be ignored.
0x0c74505f/0x368b99a0 **0x368ba706**/0x0c745040 0x0d7b1c3f/**0x0d7b02b0**
Add a defensive check to filter out those ranges based that the valid range should not cross the unconditional branch(Call, return, unconditional jmp).
Reviewed By: hoy, wenlei
Differential Revision: https://reviews.llvm.org/D125448
70 lines
2.0 KiB
Plaintext
70 lines
2.0 KiB
Plaintext
; In the perfscript input, the consecutive branch pairs 0x2017bf/0x201760 and 0x2017d8/0x2017e3 form an invalid execution range [0x2017e3, 0x2017bf].
|
|
; We are testing only the invalid range is dropped to avoid bogus instruction ranges. All other ranges and all branch samples should be kept.
|
|
;
|
|
; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/invalid-range.perfscript --binary=%S/Inputs/noinline-cs-pseudoprobe.perfbin --output=%t1 --skip-symbolization --ignore-stack-samples --use-offset=0
|
|
; RUN: FileCheck %s --input-file %t1 --check-prefix=NOCS
|
|
|
|
; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/invalid-range.perfscript --binary=%S/Inputs/noinline-cs-pseudoprobe.perfbin --output=%t2 --skip-symbolization --use-offset=0
|
|
; RUN: FileCheck %s --input-file %t2 --check-prefix=CS
|
|
|
|
|
|
; NOCS: 4
|
|
; NOCS-NEXT: 201760-20177f:7
|
|
; NOCS-NEXT: 20179e-2017bf:5
|
|
; NOCS-NEXT: 2017c4-2017cf:6
|
|
; NOCS-NEXT: 2017c4-2017d8:1
|
|
; NOCS-NEXT: 4
|
|
; NOCS-NEXT: 20177f->2017c4:7
|
|
; NOCS-NEXT: 2017bf->201760:7
|
|
; NOCS-NEXT: 2017cf->20179e:8
|
|
; NOCS-NEXT: 2017d8->2017e3:1
|
|
|
|
|
|
; CS: []
|
|
; CS-NEXT: 4
|
|
; CS-NEXT: 201760-20177f:6
|
|
; CS-NEXT: 20179e-2017bf:5
|
|
; CS-NEXT: 2017c4-2017cf:5
|
|
; CS-NEXT: 2017c4-2017d8:1
|
|
; CS-NEXT: 4
|
|
; CS-NEXT: 20177f->2017c4:6
|
|
; CS-NEXT: 2017bf->201760:6
|
|
; CS-NEXT: 2017cf->20179e:6
|
|
; CS-NEXT: 2017d8->2017e3:1
|
|
; CS-NEXT: [0x7f4]
|
|
; CS-NEXT: 1
|
|
; CS-NEXT: 2017c4-2017cf:1
|
|
; CS-NEXT: 2
|
|
; CS-NEXT: 2017bf->201760:1
|
|
; CS-NEXT: 2017cf->20179e:2
|
|
; CS-NEXT: [0x7f4 @ 0x7bf]
|
|
; CS-NEXT: 1
|
|
; CS-NEXT: 201760-20177f:1
|
|
; CS-NEXT: 1
|
|
; CS-NEXT: 20177f->2017c4:1
|
|
|
|
; clang -O3 -fuse-ld=lld -fpseudo-probe-for-profiling
|
|
; -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Xclang -mdisable-tail-calls
|
|
; -g test.c -o a.out
|
|
|
|
#include <stdio.h>
|
|
|
|
int bar(int x, int y) {
|
|
if (x % 3) {
|
|
return x - y;
|
|
}
|
|
return x + y;
|
|
}
|
|
|
|
void foo() {
|
|
int s, i = 0;
|
|
while (i++ < 4000 * 4000)
|
|
if (i % 91) s = bar(i, s); else s += 30;
|
|
printf("sum is %d\n", s);
|
|
}
|
|
|
|
int main() {
|
|
foo();
|
|
return 0;
|
|
}
|