4aca9b1cd8
Summary: In clang-tidy we'd like to know the name of the checker producing each diagnostic message. PathDiagnostic has BugType and Category fields, which are both arbitrary human-readable strings, but we need to know the exact name of the checker in the form that can be used in the CheckersControlList option to enable/disable the specific checker. This patch adds the CheckName field to the CheckerBase class, and sets it in the CheckerManager::registerChecker() method, which gets them from the CheckerRegistry. Checkers that implement multiple checks have to store the names of each check in the respective registerXXXChecker method. Reviewers: jordan_rose, krememek Reviewed By: jordan_rose CC: cfe-commits Differential Revision: http://llvm-reviews.chandlerc.com/D2557 llvm-svn: 201186
65 lines
2.1 KiB
C++
65 lines
2.1 KiB
C++
//===--- UndefinedArraySubscriptChecker.h ----------------------*- C++ -*--===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This defines UndefinedArraySubscriptChecker, a builtin check in ExprEngine
|
|
// that performs checks for undefined array subscripts.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ClangSACheckers.h"
|
|
#include "clang/AST/DeclCXX.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class UndefinedArraySubscriptChecker
|
|
: public Checker< check::PreStmt<ArraySubscriptExpr> > {
|
|
mutable OwningPtr<BugType> BT;
|
|
|
|
public:
|
|
void checkPreStmt(const ArraySubscriptExpr *A, CheckerContext &C) const;
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
void
|
|
UndefinedArraySubscriptChecker::checkPreStmt(const ArraySubscriptExpr *A,
|
|
CheckerContext &C) const {
|
|
const Expr *Index = A->getIdx();
|
|
if (!C.getSVal(Index).isUndef())
|
|
return;
|
|
|
|
// Sema generates anonymous array variables for copying array struct fields.
|
|
// Don't warn if we're in an implicitly-generated constructor.
|
|
const Decl *D = C.getLocationContext()->getDecl();
|
|
if (const CXXConstructorDecl *Ctor = dyn_cast<CXXConstructorDecl>(D))
|
|
if (Ctor->isDefaulted())
|
|
return;
|
|
|
|
ExplodedNode *N = C.generateSink();
|
|
if (!N)
|
|
return;
|
|
if (!BT)
|
|
BT.reset(new BuiltinBug(this, "Array subscript is undefined"));
|
|
|
|
// Generate a report for this bug.
|
|
BugReport *R = new BugReport(*BT, BT->getName(), N);
|
|
R->addRange(A->getIdx()->getSourceRange());
|
|
bugreporter::trackNullOrUndefValue(N, A->getIdx(), *R);
|
|
C.emitReport(R);
|
|
}
|
|
|
|
void ento::registerUndefinedArraySubscriptChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<UndefinedArraySubscriptChecker>();
|
|
}
|