Eric Fiselier da8f9b5b1b [coroutines] Fix fallthrough diagnostics for coroutines ...

Summary:
This patch fixes a number of issues with the analysis warnings emitted when a coroutine may reach the end of the function w/o returning.

* Fix bug where coroutines with `return_value` are incorrectly diagnosed as missing `co_return`'s.
* Rework diagnostic message to no longer say "non-void coroutine", because that implies the coroutine doesn't have a void return type, which it might. In this case a non-void coroutine is one who's promise type does not contain `return_void()`

As a side-effect of this patch, coroutine bodies that contain an invalid coroutine promise objects are marked as invalid.

Reviewers: GorNishanov, rsmith, aaron.ballman, majnemer

Reviewed By: GorNishanov

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D33532

llvm-svn: 303831

2017-05-25 02:16:53 +00:00

..

AnalysisDeclContext.cpp

[coroutines] Fix fallthrough diagnostics for coroutines

2017-05-25 02:16:53 +00:00

BodyFarm.cpp

Encapsulate FPOptions and use it consistently

2017-03-27 19:17:25 +00:00

BodyFarm.h

Make headers self-contained.

2016-02-02 11:06:57 +00:00

CallGraph.cpp

[analyzer] Consider function call arguments while building CallGraph.

2017-01-27 12:14:56 +00:00

CFG.cpp

[analyzer] Fix crash when building CFG with variable of incomplete type

2017-03-07 08:42:37 +00:00

CFGReachabilityAnalysis.cpp

Rework CFG edges to encode potentially unreachable edges, instead of just making them NULL.

2014-02-27 00:24:00 +00:00

CFGStmtMap.cpp

[C++11] Use 'nullptr'. Analysis edition.

2014-05-20 04:30:07 +00:00

CloneDetection.cpp

Fix unused lambda capture. Follow up to r299653.

2017-04-06 17:42:05 +00:00

CMakeLists.txt

Add support for __builtin_os_log_format[_buffer_size]

2016-10-24 20:39:34 +00:00

CocoaConventions.cpp

Allow the cf_returns_[not_]retained attributes to appear on out-parameters.

2015-06-19 23:17:46 +00:00

CodeInjector.cpp

Roll-back r250822.

2015-10-20 13:23:58 +00:00

Consumed.cpp

[NFC] Header cleanup

2016-07-18 19:02:11 +00:00

Dominators.cpp

Unweaken vtables as per http://llvm.org/docs/CodingStandards.html#ll_virtual_anch

2011-12-20 02:48:34 +00:00

FormatString.cpp

Add support for __builtin_os_log_format[_buffer_size]

2016-10-24 20:39:34 +00:00

FormatStringParsing.h

[NFC] Header cleanup

2016-07-18 19:02:11 +00:00

LiveVariables.cpp

[analyzer] Remove superquadratic behaviour from DataflowWorklist

2016-10-13 21:31:46 +00:00

ObjCNoReturn.cpp

clang/lib/Analysis/ObjCNoReturn.cpp: Fix [-Wnewline-eof]

2012-09-13 05:53:17 +00:00

OSLog.cpp

Make helpers static. NFC.

2017-02-11 12:21:17 +00:00

PostOrderCFGView.cpp

Reverting r214064 and r215650 while investigating a pesky performance regression

2014-09-23 08:34:41 +00:00

PrintfFormatString.cpp

Add support for __builtin_os_log_format[_buffer_size]

2016-10-24 20:39:34 +00:00

ProgramPoint.cpp

Roll-back r250822.

2015-10-20 13:23:58 +00:00

PseudoConstantAnalysis.cpp

Avoid overly large SmallPtrSet/SmallSet

2016-01-30 01:27:06 +00:00

ReachableCode.cpp

Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

2017-04-11 15:36:06 +00:00

ScanfFormatString.cpp

[Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 16:51:33 +00:00

ThreadSafety.cpp

DR616, and part of P0135R1: member access (or pointer-to-member access) on a

2016-12-03 01:14:32 +00:00

ThreadSafetyCommon.cpp

DR616, and part of P0135R1: member access (or pointer-to-member access) on a

2016-12-03 01:14:32 +00:00

ThreadSafetyLogical.cpp

Revert r240270 ("Fixed/added namespace ending comments using clang-tidy").

2015-06-22 23:07:51 +00:00

ThreadSafetyTIL.cpp

Spelling mistakes in comments. NFCI. (PR27635)

2017-03-30 14:13:19 +00:00

UninitializedValues.cpp

NFC small format

2016-10-29 15:28:25 +00:00