a1857e2ce3
span.cons/container.pass.cpp
N4842 22.7.3.2 [span.cons]/13 constrains span's range constructor
for ranges::contiguous_range (among other criteria).
24.4.5 [range.refinements]/2 says that contiguous_range requires data(),
and (via contiguous_range, random_access_range, bidirectional_range,
forward_range, input_range, range) it also requires begin() and end()
(see 24.4.2 [range.range]/1).
Therefore, IsAContainer needs to provide begin() and end().
(Detected by MSVC's concept-constrained implementation.)
span.cons/stdarray.pass.cpp
This test uses std::array, so it must include <array>.
<span> isn't guaranteed to drag in <array>.
(Detected by MSVC's implementation which uses a forward declaration to
avoid dragging in <array>, for increased compiler throughput.)
span.objectrep/as_bytes.pass.cpp
span.objectrep/as_writable_bytes.pass.cpp
Testing `sp.extent == std::dynamic_extent` triggers MSVC warning
C4127 "conditional expression is constant". Using `if constexpr` is a
simple way to avoid this without disrupting anyone else (as span
requires C++20 mode).
span.tuple/get.pass.cpp
22.7.3.2 [span.cons]/4.3: "Preconditions: If extent is not equal to
dynamic_extent, then count is equal to extent."
These lines were triggering undefined behavior (detected by assertions
in MSVC's implementation).
I changed the count arguments in the first two chunks, followed by
changing the span extents, in order to preserve the test's coverage
and follow the existing pattern.
span.cons/span.pass.cpp
22.7.3.2 [span.cons]/18.1 constrains span's converting constructor with
"Extent == dynamic_extent || Extent == OtherExtent is true".
This means that converting from dynamic extent to static extent is
not allowed. (Other constructors tested elsewhere, like
span(It first, size_type count), can be used to write such code.)
As this is the test for the converting constructor, I have:
* Removed the "dynamic -> static" case from checkCV(), which is
comprehensive.
* Changed the initialization of std::span<T, 0> s1{}; in
testConstexprSpan() and testRuntimeSpan(), because s1 is used below.
* Removed ASSERT_NOEXCEPT(std::span<T, 0>{s0}); from those functions,
as they are otherwise comprehensive.
* Deleted testConversionSpan() entirely. Note that this could never
compile (it had a bool return type, but forgot to say `return`). And it
couldn't have provided useful coverage, as the /18.2 constraint
"OtherElementType(*)[] is convertible to ElementType(*)[]"
permits only cv-qualifications, which are already tested by checkCV().
80 lines
2.5 KiB
C++
80 lines
2.5 KiB
C++
// -*- C++ -*-
|
|
//===------------------------------ span ---------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===---------------------------------------------------------------------===//
|
|
// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
|
|
|
|
// <span>
|
|
|
|
// template <class ElementType, size_t Extent>
|
|
// span<byte,
|
|
// Extent == dynamic_extent
|
|
// ? dynamic_extent
|
|
// : sizeof(ElementType) * Extent>
|
|
// as_writable_bytes(span<ElementType, Extent> s) noexcept;
|
|
|
|
|
|
#include <span>
|
|
#include <cassert>
|
|
#include <string>
|
|
|
|
#include "test_macros.h"
|
|
|
|
template<typename Span>
|
|
void testRuntimeSpan(Span sp)
|
|
{
|
|
ASSERT_NOEXCEPT(std::as_writable_bytes(sp));
|
|
|
|
auto spBytes = std::as_writable_bytes(sp);
|
|
using SB = decltype(spBytes);
|
|
ASSERT_SAME_TYPE(std::byte, typename SB::element_type);
|
|
|
|
if constexpr (sp.extent == std::dynamic_extent)
|
|
assert(spBytes.extent == std::dynamic_extent);
|
|
else
|
|
assert(spBytes.extent == sizeof(typename Span::element_type) * sp.extent);
|
|
|
|
assert(static_cast<void*>(spBytes.data()) == static_cast<void*>(sp.data()));
|
|
assert(spBytes.size() == sp.size_bytes());
|
|
}
|
|
|
|
struct A{};
|
|
int iArr2[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
|
|
|
|
int main(int, char**)
|
|
{
|
|
testRuntimeSpan(std::span<int> ());
|
|
testRuntimeSpan(std::span<long> ());
|
|
testRuntimeSpan(std::span<double> ());
|
|
testRuntimeSpan(std::span<A> ());
|
|
testRuntimeSpan(std::span<std::string>());
|
|
|
|
testRuntimeSpan(std::span<int, 0> ());
|
|
testRuntimeSpan(std::span<long, 0> ());
|
|
testRuntimeSpan(std::span<double, 0> ());
|
|
testRuntimeSpan(std::span<A, 0> ());
|
|
testRuntimeSpan(std::span<std::string, 0>());
|
|
|
|
testRuntimeSpan(std::span<int>(iArr2, 1));
|
|
testRuntimeSpan(std::span<int>(iArr2, 2));
|
|
testRuntimeSpan(std::span<int>(iArr2, 3));
|
|
testRuntimeSpan(std::span<int>(iArr2, 4));
|
|
testRuntimeSpan(std::span<int>(iArr2, 5));
|
|
|
|
testRuntimeSpan(std::span<int, 1>(iArr2 + 5, 1));
|
|
testRuntimeSpan(std::span<int, 2>(iArr2 + 4, 2));
|
|
testRuntimeSpan(std::span<int, 3>(iArr2 + 3, 3));
|
|
testRuntimeSpan(std::span<int, 4>(iArr2 + 2, 4));
|
|
testRuntimeSpan(std::span<int, 5>(iArr2 + 1, 5));
|
|
|
|
std::string s;
|
|
testRuntimeSpan(std::span<std::string>(&s, (std::size_t) 0));
|
|
testRuntimeSpan(std::span<std::string>(&s, 1));
|
|
|
|
return 0;
|
|
}
|