
Summary: This patch gets rid of the C-string parameter in the RawCommandObject::DoExecute function, making the code simpler and less memory unsafe. There seems to be a assumption in some command objects that this parameter could be a nullptr, but from what I can see the rest of the API doesn't actually allow this (and other command objects and related code pieces dereference this parameter without any checks). Especially CommandObjectRegexCommand has error handling code for a nullptr that is now gone. Reviewers: davide, jingham, teemperor Reviewed By: teemperor Subscribers: jingham, lldb-commits Differential Revision: https://reviews.llvm.org/D49207 llvm-svn: 336955
39 lines
1.1 KiB
C++
39 lines
1.1 KiB
C++
//===-- CommandObjectScript.h -----------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_CommandObjectScript_h_
|
|
#define liblldb_CommandObjectScript_h_
|
|
|
|
// C Includes
|
|
// C++ Includes
|
|
// Other libraries and framework includes
|
|
// Project includes
|
|
#include "lldb/Interpreter/CommandObject.h"
|
|
|
|
namespace lldb_private {
|
|
|
|
//-------------------------------------------------------------------------
|
|
// CommandObjectScript
|
|
//-------------------------------------------------------------------------
|
|
|
|
class CommandObjectScript : public CommandObjectRaw {
|
|
public:
|
|
CommandObjectScript(CommandInterpreter &interpreter,
|
|
lldb::ScriptLanguage script_lang);
|
|
|
|
~CommandObjectScript() override;
|
|
|
|
protected:
|
|
bool DoExecute(llvm::StringRef command, CommandReturnObject &result) override;
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_CommandObjectScript_h_
|