4f0436dd15
Main reason for this change is that these checkers were implemented in the same class but had different dependency ordering. (NonNullParamChecker should run before StdCLibraryFunctionArgs to get more special warning about null arguments, but the apiModeling.StdCLibraryFunctions was a modeling checker that should run before other non-modeling checkers. The modeling checker changes state in a way that makes it impossible to detect a null argument by NonNullParamChecker.) To make it more simple, the modeling part is removed as separate checker and can be only used if checker StdCLibraryFunctions is turned on, that produces the warnings too. Modeling the functions without bug detection (for invalid argument) is not possible. The modeling of standard functions does not happen by default from this change on. Reviewed By: Szelethus Differential Revision: https://reviews.llvm.org/D151225
50 lines
1.8 KiB
C
50 lines
1.8 KiB
C
// RUN: %clang_analyze_cc1 -verify -analyzer-output text %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-checker=alpha.unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=apiModeling.Errno \
|
|
// RUN: -analyzer-checker=alpha.unix.Errno \
|
|
// RUN: -analyzer-config alpha.unix.StdCLibraryFunctions:ModelPOSIX=true
|
|
|
|
#include "Inputs/errno_var.h"
|
|
|
|
int access(const char *path, int amode);
|
|
|
|
void clang_analyzer_warnIfReached();
|
|
|
|
void test1() {
|
|
access("path", 0); // no note here
|
|
access("path", 0);
|
|
// expected-note@-1{{Assuming that function 'access' is successful, in this case the value 'errno' may be undefined after the call and should not be used}}
|
|
if (errno != 0) {
|
|
// expected-warning@-1{{An undefined value may be read from 'errno'}}
|
|
// expected-note@-2{{An undefined value may be read from 'errno'}}
|
|
}
|
|
}
|
|
|
|
void test2() {
|
|
if (access("path", 0) == -1) {
|
|
// expected-note@-1{{Taking true branch}}
|
|
// Failure path.
|
|
if (errno != 0) {
|
|
// expected-note@-1{{'errno' is not equal to 0}}
|
|
// expected-note@-2{{Taking true branch}}
|
|
clang_analyzer_warnIfReached(); // expected-note {{REACHABLE}} expected-warning {{REACHABLE}}
|
|
} else {
|
|
clang_analyzer_warnIfReached(); // no-warning: We are on the failure path.
|
|
}
|
|
}
|
|
}
|
|
|
|
void test3() {
|
|
if (access("path", 0) != -1) {
|
|
// Success path.
|
|
// expected-note@-2{{Assuming that function 'access' is successful, in this case the value 'errno' may be undefined after the call and should not be used}}
|
|
// expected-note@-3{{Taking true branch}}
|
|
if (errno != 0) {
|
|
// expected-warning@-1{{An undefined value may be read from 'errno'}}
|
|
// expected-note@-2{{An undefined value may be read from 'errno'}}
|
|
}
|
|
}
|
|
}
|