4f0436dd15
Main reason for this change is that these checkers were implemented in the same class but had different dependency ordering. (NonNullParamChecker should run before StdCLibraryFunctionArgs to get more special warning about null arguments, but the apiModeling.StdCLibraryFunctions was a modeling checker that should run before other non-modeling checkers. The modeling checker changes state in a way that makes it impossible to detect a null argument by NonNullParamChecker.) To make it more simple, the modeling part is removed as separate checker and can be only used if checker StdCLibraryFunctions is turned on, that produces the warnings too. Modeling the functions without bug detection (for invalid argument) is not possible. The modeling of standard functions does not happen by default from this change on. Reviewed By: Szelethus Differential Revision: https://reviews.llvm.org/D151225
57 lines
1.7 KiB
C
57 lines
1.7 KiB
C
// RUN: %clang_analyze_cc1 -verify %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-checker=alpha.unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=apiModeling.Errno \
|
|
// RUN: -analyzer-checker=alpha.unix.Errno \
|
|
// RUN: -analyzer-config alpha.unix.StdCLibraryFunctions:ModelPOSIX=true
|
|
|
|
#include "Inputs/errno_var.h"
|
|
|
|
typedef typeof(sizeof(int)) size_t;
|
|
typedef __typeof(sizeof(int)) off_t;
|
|
typedef size_t ssize_t;
|
|
ssize_t send(int sockfd, const void *buf, size_t len, int flags);
|
|
off_t lseek(int fildes, off_t offset, int whence);
|
|
|
|
void clang_analyzer_warnIfReached();
|
|
void clang_analyzer_eval(int);
|
|
|
|
int unsafe_errno_read(int sock, void *data, int data_size) {
|
|
if (send(sock, data, data_size, 0) != data_size) {
|
|
if (errno == 1) {
|
|
// expected-warning@-1{{An undefined value may be read from 'errno'}}
|
|
return 0;
|
|
}
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
int errno_lseek(int fildes, off_t offset) {
|
|
off_t result = lseek(fildes, offset, 0);
|
|
if (result == (off_t)-1) {
|
|
// Failure path.
|
|
// check if the function is modeled
|
|
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
|
|
return 2;
|
|
}
|
|
if (result != offset) {
|
|
// Not success path (?)
|
|
// not sure if this is a valid case, allow to check 'errno'
|
|
if (errno == 1) { // no warning
|
|
return 1;
|
|
}
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
if (result == offset) {
|
|
// The checker does not differentiate for this case.
|
|
// In general case no relation exists between the arg 2 and the returned
|
|
// value, only for SEEK_SET.
|
|
if (errno == 1) { // no warning
|
|
return 1;
|
|
}
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
return 0;
|
|
}
|