4f0436dd15
Main reason for this change is that these checkers were implemented in the same class but had different dependency ordering. (NonNullParamChecker should run before StdCLibraryFunctionArgs to get more special warning about null arguments, but the apiModeling.StdCLibraryFunctions was a modeling checker that should run before other non-modeling checkers. The modeling checker changes state in a way that makes it impossible to detect a null argument by NonNullParamChecker.) To make it more simple, the modeling part is removed as separate checker and can be only used if checker StdCLibraryFunctions is turned on, that produces the warnings too. Modeling the functions without bug detection (for invalid argument) is not possible. The modeling of standard functions does not happen by default from this change on. Reviewed By: Szelethus Differential Revision: https://reviews.llvm.org/D151225
21 lines
881 B
C
21 lines
881 B
C
// This test case crashes if strncasecmp is modeled in StdCLibraryFunctions.
|
|
// Either we fix CStringChecker to handle the call prerequisites in
|
|
// checkPreCall, or we must not evaluate any pure functions in
|
|
// StdCLibraryFunctions that are also handled in CStringChecker.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=alpha.unix.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=unix.cstring.NullArg \
|
|
// RUN: -analyzer-config alpha.unix.StdCLibraryFunctions:ModelPOSIX=true \
|
|
// RUN: -triple x86_64-unknown-linux-gnu \
|
|
// RUN: -verify
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
int strncasecmp(const char *s1, const char *s2, size_t n);
|
|
|
|
int strncasecmp_null_argument(char *a, size_t n) {
|
|
char *b = 0;
|
|
return strncasecmp(a, b, n); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
|
|
}
|