53e5e58670
Introduce a new attribute "function-inline-cost-multiplier" which multiplies the inline cost of a call site (or all calls to a callee) by the multiplier. When processing the list of calls created by inlining, check each call to see if the new call's callee is in the same SCC as the original callee. If so, set the "function-inline-cost-multiplier" attribute of the new call site to double the original call site's attribute value. This does not happen when the original call site is intra-SCC. This is an alternative to D120584, which marks the call sites as noinline. Hopefully fixes PR45253. Reviewed By: davidxl Differential Revision: https://reviews.llvm.org/D121084
76 lines
2.3 KiB
LLVM
76 lines
2.3 KiB
LLVM
; RUN: opt -S -passes='cgscc(inline,instcombine)' < %s | FileCheck %s
|
|
; RUN: opt -S -intra-scc-cost-multiplier=3 -passes='cgscc(inline,instcombine)' < %s | FileCheck %s --check-prefix=THREE
|
|
|
|
; We use call to a dummy function to avoid inlining test1 into test2 or vice
|
|
; versa, such that we aren't left with a trivial cycle, as trivial cycles are
|
|
; special-cased to never be inlined.
|
|
; However, InstCombine will eliminate these calls after inlining, and thus
|
|
; make the functions eligible for inlining in their callers.
|
|
declare void @dummy() readnone nounwind willreturn
|
|
|
|
define void @test1() {
|
|
; CHECK-LABEL: define void @test1(
|
|
; CHECK-NEXT: call void @test2()
|
|
; CHECK-NEXT: call void @test2()
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call void @test2()
|
|
call void @test2()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
ret void
|
|
}
|
|
|
|
define void @test2() {
|
|
; CHECK-LABEL: define void @test2(
|
|
; CHECK-NEXT: call void @test1()
|
|
; CHECK-NEXT: call void @test1()
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call void @test1()
|
|
call void @test1()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
call void @dummy()
|
|
ret void
|
|
}
|
|
|
|
; The inlined call sites should have the "function-inline-cost-multiplier" call site attribute.
|
|
; This test is a bit fragile in the exact number of inlining that happens based on thresholds.
|
|
define void @test3() {
|
|
; CHECK-LABEL: define void @test3(
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT:[0-9]+]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: call void @test2() #[[COSTMULT]]
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call void @test2()
|
|
call void @test2()
|
|
ret void
|
|
}
|
|
|
|
; CHECK: [[COSTMULT]] = { "function-inline-cost-multiplier"="4" }
|
|
; THREE: "function-inline-cost-multiplier"="9"
|