Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.
The reasons for this are:
* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.
For the record, the following tests had their line numbers changed to pass with the removal of the license header:
lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
lldb-shell :: Reproducer/TestGDBRemoteRepro.test
lldb-shell :: Reproducer/TestMultipleTargets.test
lldb-shell :: Reproducer/TestReuseDirectory.test
lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
lldb-shell :: ExecControl/StopHook/stop-hook.test
lldb-api :: lang/objc/exceptions/TestObjCExceptions.py
Reviewers: #lldb, espindola, JDevlieghere
Reviewed By: #lldb, JDevlieghere
Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74839
56 lines
1.3 KiB
C
56 lines
1.3 KiB
C
int a(int);
|
|
int b(int);
|
|
int c(int);
|
|
const char *print_string = "aaaaaaaaaa\n";
|
|
|
|
int a(int val)
|
|
{
|
|
int return_value = val; // basic break at the start of b
|
|
|
|
if (val <= 1)
|
|
{
|
|
return_value = b(val); // break here to stop in a before calling b
|
|
}
|
|
else if (val >= 3)
|
|
{
|
|
return_value = c(val);
|
|
}
|
|
|
|
return return_value;
|
|
}
|
|
|
|
int b(int val)
|
|
{
|
|
int rc = c(val); // thread step-out while stopped at "c(2)"
|
|
return rc;
|
|
}
|
|
|
|
int c(int val)
|
|
{
|
|
return val + 3; // Find the line number of function "c" here.
|
|
}
|
|
|
|
int complex (int first, int second, int third)
|
|
{
|
|
return first + second + third; // Step in targeting complex should stop here
|
|
}
|
|
|
|
int main (int argc, char const *argv[])
|
|
{
|
|
int A1 = a(1); // frame select 2, thread step-out while stopped at "c(1)"
|
|
|
|
int B2 = b(2);
|
|
|
|
int A3 = a(3); // frame select 1, thread step-out while stopped at "c(3)"
|
|
|
|
int A4 = complex (a(1), b(2), c(3)); // Stop here to try step in targeting b.
|
|
|
|
int A5 = complex (a(2), b(3), c(4)); // Stop here to try step in targeting complex.
|
|
|
|
int A6 = complex (a(4), b(5), c(6)); // Stop here to step targeting b and hitting breakpoint.
|
|
|
|
int A7 = complex (a(5), b(6), c(7)); // Stop here to make sure bogus target steps over.
|
|
|
|
return A1 + B2 + A3 + A4 + A5 + A6 + A7 + *print_string;
|
|
}
|