b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
49 lines
1.4 KiB
Python
49 lines
1.4 KiB
Python
"""
|
|
Test that dynamically discovered ivars of type IMP do not crash LLDB
|
|
"""
|
|
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class ObjCiVarIMPTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
@skipUnlessDarwin
|
|
@skipIf(archs=['i386']) # objc file does not build for i386
|
|
@no_debug_info_test
|
|
def test_imp_ivar_type(self):
|
|
"""Test that dynamically discovered ivars of type IMP do not crash LLDB"""
|
|
self.build()
|
|
exe = self.getBuildArtifact("a.out")
|
|
|
|
# Create a target from the debugger.
|
|
target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(target, VALID_TARGET)
|
|
|
|
# Set up our breakpoint
|
|
|
|
bkpt = lldbutil.run_break_set_by_source_regexp(self, "break here")
|
|
|
|
# Now launch the process, and do not stop at the entry point.
|
|
process = target.LaunchSimple(
|
|
None, None, self.get_process_working_directory())
|
|
|
|
self.assertEquals(process.GetState(), lldb.eStateStopped,
|
|
PROCESS_STOPPED)
|
|
|
|
self.expect(
|
|
'frame variable --ptr-depth=1 --show-types -d run -- object',
|
|
substrs=[
|
|
'(MyClass *) object = 0x',
|
|
'(void *) myImp = 0x'])
|
|
self.expect(
|
|
'disassemble --start-address `((MyClass*)object)->myImp`',
|
|
substrs=['-[MyClass init]'])
|