Jay Foad 56af0e913c [EarlyCSE] Do not CSE convergent calls in different basic blocks
"convergent" is documented as meaning that the call cannot be made
control-dependent on more values, but in practice we also require that
it cannot be made control-dependent on fewer values, e.g. it cannot be
hoisted out of the body of an "if" statement.

In code like this, if we allow CSE to combine the two calls:

  x = convergent_call();
  if (cond) {
    y = convergent_call();
    use y;
  }

then we get this:

  x = convergent_call();
  if (cond) {
    use x;
  }

This is conceptually equivalent to moving the second call out of the
body of the "if", up to the location of the first call, so it should be
disallowed.

Differential Revision: https://reviews.llvm.org/D149348
2023-04-28 14:50:48 +01:00
..
2022-07-08 09:13:59 +01:00
2022-07-08 09:13:59 +01:00
2022-12-13 10:34:26 -05:00
2023-04-19 16:15:14 +01:00
2022-07-08 09:13:59 +01:00
2022-12-22 13:01:41 -05:00
2022-07-08 09:13:59 +01:00
2022-07-08 09:13:59 +01:00
2022-07-08 09:13:59 +01:00
2023-04-17 09:01:22 +02:00
2022-07-08 09:13:59 +01:00
2022-07-08 09:13:59 +01:00

+==============================================================================+
| How to organize the lit tests                                                |
+==============================================================================+

- If you write a test for matching a single DAG opcode or intrinsic, it should
  go in a file called {opcode_name,intrinsic_name}.ll (e.g. fadd.ll)

- If you write a test that matches several DAG opcodes and checks for a single
  ISA instruction, then that test should go in a file called {ISA_name}.ll (e.g.
  bfi_int.ll

- For all other tests, use your best judgement for organizing tests and naming
  the files.

+==============================================================================+
| Naming conventions                                                           |
+==============================================================================+

- Use dash '-' and not underscore '_' to separate words in file names, unless
  the file is named after a DAG opcode or ISA instruction that has an
  underscore '_' in its name.