5a8d096ae3
this PR fixes #126424 for `ArraySubScriptExpr`, `hasBase` Matcher will get right operand when it is not integer type, but is not for sure that left operand is integer type. For the example code below `hasBase` will get `r` for the Subsequent matching and causing false positive. ``` template <typename R> int f(std::map<R*, int>& map, R* r) { return map[r]; } ``` so is needed to see if index is integer type to avoid this situation.
59 lines
2.0 KiB
C++
59 lines
2.0 KiB
C++
//===--- ProBoundsPointerArithmeticCheck.cpp - clang-tidy------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ProBoundsPointerArithmeticCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::cppcoreguidelines {
|
|
|
|
void ProBoundsPointerArithmeticCheck::registerMatchers(MatchFinder *Finder) {
|
|
if (!getLangOpts().CPlusPlus)
|
|
return;
|
|
|
|
const auto AllPointerTypes =
|
|
anyOf(hasType(pointerType()),
|
|
hasType(autoType(
|
|
hasDeducedType(hasUnqualifiedDesugaredType(pointerType())))),
|
|
hasType(decltypeType(hasUnderlyingType(pointerType()))));
|
|
|
|
// Flag all operators +, -, +=, -=, ++, -- that result in a pointer
|
|
Finder->addMatcher(
|
|
binaryOperator(
|
|
hasAnyOperatorName("+", "-", "+=", "-="), AllPointerTypes,
|
|
unless(hasLHS(ignoringImpCasts(declRefExpr(to(isImplicit()))))))
|
|
.bind("expr"),
|
|
this);
|
|
|
|
Finder->addMatcher(
|
|
unaryOperator(hasAnyOperatorName("++", "--"), hasType(pointerType()))
|
|
.bind("expr"),
|
|
this);
|
|
|
|
// Array subscript on a pointer (not an array) is also pointer arithmetic
|
|
Finder->addMatcher(
|
|
arraySubscriptExpr(
|
|
hasBase(ignoringImpCasts(
|
|
anyOf(AllPointerTypes,
|
|
hasType(decayedType(hasDecayedType(pointerType())))))),
|
|
hasIndex(hasType(isInteger())))
|
|
.bind("expr"),
|
|
this);
|
|
}
|
|
|
|
void ProBoundsPointerArithmeticCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedExpr = Result.Nodes.getNodeAs<Expr>("expr");
|
|
|
|
diag(MatchedExpr->getExprLoc(), "do not use pointer arithmetic");
|
|
}
|
|
|
|
} // namespace clang::tidy::cppcoreguidelines
|