3d334df587
std::format is currently experimental, so there is technically no deployment target requirement for it (since the only symbols required for it are in `libc++experimental.a`). However, some parts of std::format depend indirectly on the floating point std::to_chars implementation, which does have deployment target requirements. This patch removes all the availability format for std::format and updates the XFAILs in the tests to properly explain why they fail on old deployment targets, when they do. It also changes a couple of tests to avoid depending on floating-point std::to_chars when it isn't fundamental to the test. Finally, some tests are marked as XFAIL but I added a comment saying TODO FMT This test should not require std::to_chars(floating-point) These tests do not fundamentally depend on floating-point std::to_chars, however they end up failing because calling std::format even without a floating-point argument to format will end up requiring floating-point std::to_chars. I believe this is an implementation artifact that could be avoided in all cases where we know the format string at compile-time. In the tests, I added the TODO comment only to the places where we could do better and actually avoid relying on floating-point std::to_chars because we know the format string at compile-time. Differential Revision: https://reviews.llvm.org/D134598
54 lines
1.6 KiB
C++
54 lines
1.6 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14, c++17
|
|
// UNSUPPORTED: libcpp-has-no-incomplete-format
|
|
|
|
// libc++ supports basic_format_string in C++20 as an extension
|
|
// UNSUPPORTED: !stdlib=libc++ && c++20
|
|
|
|
// <format>
|
|
|
|
// template<class charT, class... Args>
|
|
// class basic_format_string<charT, type_identity_t<Args>...>
|
|
//
|
|
// constexpr basic_string_view<charT> get() const noexcept { return str; }
|
|
|
|
#include <format>
|
|
|
|
#include <cassert>
|
|
#include <concepts>
|
|
#include <string_view>
|
|
|
|
#include "test_macros.h"
|
|
#include "make_string.h"
|
|
|
|
#define CSTR(S) MAKE_CSTRING(CharT, S)
|
|
#define SV(S) MAKE_STRING_VIEW(CharT, S)
|
|
|
|
template <class CharT>
|
|
constexpr bool test() {
|
|
assert((std::basic_format_string<CharT>{CSTR("foo")}.get() == SV("foo")));
|
|
assert((std::basic_format_string<CharT, int>{CSTR("{}")}.get() == SV("{}")));
|
|
assert((std::basic_format_string<CharT, int, char>{CSTR("{} {:*>6}")}.get() == SV("{} {:*>6}")));
|
|
|
|
// Embedded NUL character
|
|
assert((std::basic_format_string<CharT, void*, bool>{SV("{}\0{}")}.get() == SV("{}\0{}")));
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**) {
|
|
test<char>();
|
|
static_assert(test<char>());
|
|
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
|
|
test<wchar_t>();
|
|
static_assert(test<wchar_t>());
|
|
#endif
|
|
return 0;
|
|
}
|