This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
58 lines
2.2 KiB
C++
58 lines
2.2 KiB
C++
//===- TestDataLayoutQuery.cpp - Test Data Layout Queries -----------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TestDialect.h"
|
|
#include "mlir/Analysis/DataLayoutAnalysis.h"
|
|
#include "mlir/Dialect/DLTI/DLTI.h"
|
|
#include "mlir/IR/BuiltinAttributes.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
|
|
/// A pass that finds "test.data_layout_query" operations and attaches to them
|
|
/// attributes containing the results of data layout queries for operation
|
|
/// result types.
|
|
struct TestDataLayoutQuery
|
|
: public PassWrapper<TestDataLayoutQuery, OperationPass<FuncOp>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDataLayoutQuery)
|
|
|
|
StringRef getArgument() const final { return "test-data-layout-query"; }
|
|
StringRef getDescription() const final { return "Test data layout queries"; }
|
|
void runOnOperation() override {
|
|
FuncOp func = getOperation();
|
|
Builder builder(func.getContext());
|
|
const DataLayoutAnalysis &layouts = getAnalysis<DataLayoutAnalysis>();
|
|
|
|
func.walk([&](test::DataLayoutQueryOp op) {
|
|
// Skip the ops with already processed in a deeper call.
|
|
if (op->getAttr("size"))
|
|
return;
|
|
|
|
const DataLayout &layout = layouts.getAbove(op);
|
|
unsigned size = layout.getTypeSize(op.getType());
|
|
unsigned bitsize = layout.getTypeSizeInBits(op.getType());
|
|
unsigned alignment = layout.getTypeABIAlignment(op.getType());
|
|
unsigned preferred = layout.getTypePreferredAlignment(op.getType());
|
|
op->setAttrs(
|
|
{builder.getNamedAttr("size", builder.getIndexAttr(size)),
|
|
builder.getNamedAttr("bitsize", builder.getIndexAttr(bitsize)),
|
|
builder.getNamedAttr("alignment", builder.getIndexAttr(alignment)),
|
|
builder.getNamedAttr("preferred", builder.getIndexAttr(preferred))});
|
|
});
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestDataLayoutQuery() { PassRegistration<TestDataLayoutQuery>(); }
|
|
} // namespace test
|
|
} // namespace mlir
|