984475d82d
This PR adds support for detecting unsafe union members and pointers to unsafe pointers (e.g. T** where T* is an unsafe pointer type).
84 lines
2.3 KiB
C++
84 lines
2.3 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.NoUncheckedPtrMemberChecker -verify %s
|
|
|
|
#include "mock-types.h"
|
|
|
|
namespace members {
|
|
|
|
struct Foo {
|
|
private:
|
|
CheckedObj* a = nullptr;
|
|
// expected-warning@-1{{Member variable 'a' in 'members::Foo' is a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
CheckedObj& b;
|
|
// expected-warning@-1{{Member variable 'b' in 'members::Foo' is a reference to CheckedPtr capable type 'CheckedObj'}}
|
|
|
|
[[clang::suppress]]
|
|
CheckedObj* a_suppressed = nullptr;
|
|
|
|
[[clang::suppress]]
|
|
CheckedObj& b_suppressed;
|
|
|
|
CheckedPtr<CheckedObj> c;
|
|
CheckedRef<CheckedObj> d;
|
|
|
|
public:
|
|
Foo();
|
|
};
|
|
|
|
template <typename S>
|
|
struct FooTmpl {
|
|
S* e;
|
|
// expected-warning@-1{{Member variable 'e' in 'members::FooTmpl<CheckedObj>' is a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
};
|
|
|
|
void forceTmplToInstantiate(FooTmpl<CheckedObj>) { }
|
|
|
|
} // namespace members
|
|
|
|
namespace unions {
|
|
|
|
union Foo {
|
|
CheckedObj* a;
|
|
// expected-warning@-1{{Member variable 'a' in 'unions::Foo' is a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
CheckedPtr<CheckedObj> c;
|
|
CheckedRef<CheckedObj> d;
|
|
};
|
|
|
|
template<class T>
|
|
union FooTmpl {
|
|
T* a;
|
|
// expected-warning@-1{{Member variable 'a' in 'unions::FooTmpl<CheckedObj>' is a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
};
|
|
|
|
void forceTmplToInstantiate(FooTmpl<CheckedObj>) { }
|
|
|
|
} // namespace unions
|
|
|
|
namespace checked_ptr_ref_ptr_capable {
|
|
|
|
RefCountableAndCheckable* provide();
|
|
void foo() {
|
|
RefPtr<RefCountableAndCheckable> foo = provide();
|
|
}
|
|
|
|
} // checked_ptr_ref_ptr_capable
|
|
|
|
namespace ptr_to_ptr_to_checked_ptr_capable {
|
|
|
|
struct List {
|
|
CheckedObj** elements;
|
|
// expected-warning@-1{{Member variable 'elements' in 'ptr_to_ptr_to_checked_ptr_capable::List' contains a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
};
|
|
|
|
template <typename T>
|
|
struct TemplateList {
|
|
T** elements;
|
|
// expected-warning@-1{{Member variable 'elements' in 'ptr_to_ptr_to_checked_ptr_capable::TemplateList<CheckedObj>' contains a raw pointer to CheckedPtr capable type 'CheckedObj'}}
|
|
};
|
|
TemplateList<CheckedObj> list;
|
|
|
|
struct SafeList {
|
|
CheckedPtr<CheckedObj>* elements;
|
|
};
|
|
|
|
} // namespace ptr_to_ptr_to_checked_ptr_capable
|