llvm-project/flang/test/lib/OpenACC/TestOpenACCInterfaces.cpp
Razvan Lupusoru 9077522b2b
[acc][flang] Define hasUnknownDimensions in MappableType (#165794)
The MappableType interface currently defines a `generateAccBounds`
method which examines a variable and generates `acc.bounds` operations
that encode its dimensions. The implementation can extract bounds
information in various ways: either from the MLIR type itself or by
analyzing the IR to find dimension information from defining operations.

However, we need to distinguish between cases where dimensional
information is not directly available from the type itself. This new
`hasUnknownDimensions` API returns true when the MLIR type does not
encode dimensional information and there is no associated descriptor or
metadata that would make this information extractable from the visible
ssa value the represents the variable. The expected use case is calling
`generateAccBounds` only when this returns true, as it indicates that
bounds must be extracted from the IR (by walking back from current
variable to its defining spots or its descriptor).

This supports cases such as raw references to arrays with non-constant
bounds (e.g., explicit-shape arrays in Fortran where bounds are passed
as arguments). This functionality could also be leveraged for CIR VLA
support in the future.

For FIR types:
- Box types return false (descriptor encodes dimensions)
- Reference types check if the pointee has dynamic size using
fir::hasDynamicSize()
2025-10-30 16:17:00 -07:00

144 lines
5.6 KiB
C++

//===- TestOpenACCInterfaces.cpp ------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "mlir/Dialect/Arith/IR/Arith.h"
#include "mlir/Dialect/DLTI/DLTI.h"
#include "mlir/Dialect/OpenACC/OpenACC.h"
#include "mlir/IR/Builders.h"
#include "mlir/IR/BuiltinOps.h"
#include "mlir/Pass/Pass.h"
#include "mlir/Support/LLVM.h"
#include "flang/Optimizer/Dialect/FIRDialect.h"
#include "flang/Optimizer/HLFIR/HLFIRDialect.h"
#include "flang/Optimizer/HLFIR/HLFIROps.h"
#include "flang/Optimizer/Support/DataLayout.h"
using namespace mlir;
namespace {
struct TestFIROpenACCInterfaces
: public PassWrapper<TestFIROpenACCInterfaces, OperationPass<ModuleOp>> {
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestFIROpenACCInterfaces)
StringRef getArgument() const final { return "test-fir-openacc-interfaces"; }
StringRef getDescription() const final {
return "Test FIR implementation of the OpenACC interfaces.";
}
void getDependentDialects(::mlir::DialectRegistry &registry) const override {
registry.insert<fir::FIROpsDialect, hlfir::hlfirDialect,
mlir::arith::ArithDialect, mlir::acc::OpenACCDialect,
mlir::DLTIDialect>();
}
void runOnOperation() override {
mlir::ModuleOp mod = getOperation();
auto datalayout =
fir::support::getOrSetMLIRDataLayout(mod, /*allowDefaultLayout=*/true);
mlir::OpBuilder builder(mod);
getOperation().walk([&](Operation *op) {
if (isa<ACC_DATA_ENTRY_OPS>(op)) {
Value var = acc::getVar(op);
Type typeOfVar = var.getType();
// Attempt to determine if the variable is mappable-like or if
// the pointee itself is mappable-like. For example, if the variable is
// of type !fir.ref<!fir.box<>>, we want to print both the details about
// the !fir.ref since it is pointer-like, and about !fir.box since it
// is mappable.
auto mappableTy = dyn_cast_if_present<acc::MappableType>(typeOfVar);
if (!mappableTy) {
mappableTy =
dyn_cast_if_present<acc::MappableType>(acc::getVarType(op));
}
llvm::errs() << "Visiting: " << *op << "\n";
llvm::errs() << "\tVar: " << var << "\n";
if (mlir::isa<acc::PointerLikeType>(typeOfVar) &&
mlir::isa<acc::MappableType>(typeOfVar)) {
llvm::errs() << "\tPointer-like and Mappable: " << typeOfVar << "\n";
} else if (mlir::isa<acc::PointerLikeType>(typeOfVar)) {
llvm::errs() << "\tPointer-like: " << typeOfVar << "\n";
} else {
assert(
mlir::isa<acc::MappableType>(typeOfVar) && "expected mappable");
llvm::errs() << "\tMappable: " << typeOfVar << "\n";
}
if (auto ptrTy = dyn_cast_if_present<acc::PointerLikeType>(typeOfVar)) {
// If the pointee is not mappable, print details about it. Otherwise,
// we defer to the mappable printing below to print those details.
if (!mappableTy) {
acc::VariableTypeCategory typeCategory =
ptrTy.getPointeeTypeCategory(
cast<TypedValue<acc::PointerLikeType>>(var),
acc::getVarType(op));
llvm::errs() << "\t\tType category: " << typeCategory << "\n";
}
}
if (mappableTy) {
acc::VariableTypeCategory typeCategory =
mappableTy.getTypeCategory(var);
llvm::errs() << "\t\tType category: " << typeCategory << "\n";
if (datalayout.has_value()) {
auto size = mappableTy.getSizeInBytes(
acc::getVar(op), acc::getBounds(op), datalayout.value());
if (size) {
llvm::errs() << "\t\tSize: " << size.value() << "\n";
}
auto offset = mappableTy.getOffsetInBytes(
acc::getVar(op), acc::getBounds(op), datalayout.value());
if (offset) {
llvm::errs() << "\t\tOffset: " << offset.value() << "\n";
}
}
llvm::errs() << "\t\tHas unknown dimensions: "
<< (mappableTy.hasUnknownDimensions() ? "true" : "false")
<< "\n";
if (auto declareOp =
dyn_cast_if_present<hlfir::DeclareOp>(var.getDefiningOp())) {
llvm::errs() << "\t\tShape: " << declareOp.getShape() << "\n";
}
builder.setInsertionPoint(op);
auto bounds = mappableTy.generateAccBounds(acc::getVar(op), builder);
if (!bounds.empty()) {
for (auto [idx, bound] : llvm::enumerate(bounds)) {
if (auto boundOp = dyn_cast_if_present<acc::DataBoundsOp>(
bound.getDefiningOp())) {
llvm::errs() << "\t\tBound[" << idx << "]: " << bound << "\n";
llvm::errs()
<< "\t\tLower bound: " << boundOp.getLowerbound() << "\n";
llvm::errs()
<< "\t\tUpper bound: " << boundOp.getUpperbound() << "\n";
}
}
}
}
}
});
}
};
} // namespace
//===----------------------------------------------------------------------===//
// Pass Registration
//===----------------------------------------------------------------------===//
namespace fir {
namespace test {
void registerTestFIROpenACCInterfacesPass() {
PassRegistration<TestFIROpenACCInterfaces>();
}
} // namespace test
} // namespace fir