William Tran-Viet 9f5efd5d03
[libc++] Correct optional<T&> implementation (#174537)
Resolves #174350

- Several issues were found in the current implementation of
`optional<T&>`
- `value()`, `operator*()`, `and_then()`, `transform()`, `operator->()`
still provided their ref-qualified versions for rvalues and `const&`.
- Using the listed methods on an rvalue `optional<T&>` would cause a
compile failure due to a mismatch in return types.
- On the latter, `operator*`, `operator->` would return `const` for a
`optional<T&>`, which is an incorrect deep const.
- A few constructors were missing (`optional<U>&`), and most
constructors relevant to `optional<T&>` were missing `noexcept`
- Constructors and `emplace` were not correctly constructing a `T&` as
specified in _`convert-ref-init-val`_
- Also corrects the behavior of `value_or` which should return
`remove_cv_t<T>` (in our case `decay_t<_Tp>`)
- Add several test cases to verify behavior, update `value_or` tests
2026-01-09 16:33:10 +08:00

116 lines
2.8 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14
// <optional>
// optional<T>& operator=(nullopt_t) noexcept;
#include <optional>
#include <type_traits>
#include <cassert>
#include "test_macros.h"
#include "archetypes.h"
using std::optional;
using std::nullopt_t;
using std::nullopt;
TEST_CONSTEXPR_CXX20 bool test()
{
enum class State { inactive, constructed, destroyed };
State state = State::inactive;
struct StateTracker {
TEST_CONSTEXPR_CXX20 StateTracker(State& s)
: state_(&s)
{
s = State::constructed;
}
TEST_CONSTEXPR_CXX20 ~StateTracker() { *state_ = State::destroyed; }
State* state_;
};
{
optional<int> opt;
static_assert(noexcept(opt = nullopt) == true, "");
opt = nullopt;
assert(static_cast<bool>(opt) == false);
}
{
optional<int> opt(3);
opt = nullopt;
assert(static_cast<bool>(opt) == false);
}
{
optional<StateTracker> opt;
opt = nullopt;
assert(state == State::inactive);
assert(static_cast<bool>(opt) == false);
}
{
optional<StateTracker> opt(state);
assert(state == State::constructed);
opt = nullopt;
assert(state == State::destroyed);
assert(static_cast<bool>(opt) == false);
}
#if TEST_STD_VER >= 26
{
int i = 0;
optional<int&> o{i};
ASSERT_NOEXCEPT(o = std::nullopt);
o = std::nullopt;
assert(!o.has_value());
assert(static_cast<bool>(o) == false);
}
#endif
return true;
}
int main(int, char**)
{
#if TEST_STD_VER > 17
static_assert(test());
#endif
test();
using TT = TestTypes::TestType;
TT::reset();
{
optional<TT> opt;
static_assert(noexcept(opt = nullopt) == true, "");
assert(TT::destroyed == 0);
opt = nullopt;
assert(TT::constructed == 0);
assert(TT::alive == 0);
assert(TT::destroyed == 0);
assert(static_cast<bool>(opt) == false);
}
assert(TT::alive == 0);
assert(TT::destroyed == 0);
TT::reset();
{
optional<TT> opt(42);
assert(TT::destroyed == 0);
TT::reset_constructors();
opt = nullopt;
assert(TT::constructed == 0);
assert(TT::alive == 0);
assert(TT::destroyed == 1);
assert(static_cast<bool>(opt) == false);
}
assert(TT::alive == 0);
assert(TT::destroyed == 1);
TT::reset();
return 0;
}