9f5efd5d03
Resolves #174350 - Several issues were found in the current implementation of `optional<T&>` - `value()`, `operator*()`, `and_then()`, `transform()`, `operator->()` still provided their ref-qualified versions for rvalues and `const&`. - Using the listed methods on an rvalue `optional<T&>` would cause a compile failure due to a mismatch in return types. - On the latter, `operator*`, `operator->` would return `const` for a `optional<T&>`, which is an incorrect deep const. - A few constructors were missing (`optional<U>&`), and most constructors relevant to `optional<T&>` were missing `noexcept` - Constructors and `emplace` were not correctly constructing a `T&` as specified in _`convert-ref-init-val`_ - Also corrects the behavior of `value_or` which should return `remove_cv_t<T>` (in our case `decay_t<_Tp>`) - Add several test cases to verify behavior, update `value_or` tests
86 lines
1.8 KiB
C++
86 lines
1.8 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14
|
|
|
|
// <optional>
|
|
|
|
// void reset() noexcept;
|
|
|
|
#include <optional>
|
|
#include <type_traits>
|
|
#include <cassert>
|
|
|
|
#include "test_macros.h"
|
|
|
|
using std::optional;
|
|
|
|
struct X
|
|
{
|
|
static bool dtor_called;
|
|
X() = default;
|
|
X(const X&) = default;
|
|
X& operator=(const X&) = default;
|
|
~X() {dtor_called = true;}
|
|
};
|
|
|
|
bool X::dtor_called = false;
|
|
|
|
TEST_CONSTEXPR_CXX20 bool check_reset() {
|
|
{
|
|
optional<int> opt;
|
|
static_assert(noexcept(opt.reset()) == true, "");
|
|
opt.reset();
|
|
assert(static_cast<bool>(opt) == false);
|
|
}
|
|
{
|
|
optional<int> opt(3);
|
|
opt.reset();
|
|
assert(static_cast<bool>(opt) == false);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**)
|
|
{
|
|
check_reset();
|
|
#if TEST_STD_VER >= 20
|
|
static_assert(check_reset());
|
|
#endif
|
|
{
|
|
optional<X> opt;
|
|
static_assert(noexcept(opt.reset()) == true, "");
|
|
assert(X::dtor_called == false);
|
|
opt.reset();
|
|
assert(X::dtor_called == false);
|
|
assert(static_cast<bool>(opt) == false);
|
|
}
|
|
{
|
|
optional<X> opt(X{});
|
|
X::dtor_called = false;
|
|
opt.reset();
|
|
assert(X::dtor_called == true);
|
|
assert(static_cast<bool>(opt) == false);
|
|
X::dtor_called = false;
|
|
}
|
|
|
|
#if TEST_STD_VER >= 26
|
|
{
|
|
X x{};
|
|
optional<X&> opt(x);
|
|
X::dtor_called = false;
|
|
opt.reset();
|
|
ASSERT_NOEXCEPT(opt.reset());
|
|
assert(X::dtor_called == false);
|
|
assert(static_cast<bool>(opt) == false);
|
|
}
|
|
#endif
|
|
|
|
return 0;
|
|
}
|