bb9df2e3bd
If we open a `NativeFile` with a `FILE*`, the OpenOptions default to
`eOpenOptionReadOnly`. This is an issue in python scripts if you try to
write to one of the files like `print("Hi",
file=lldb.debugger.GetOutputFileHandle())`.
To address this, we need to specify the access mode whenever we create a
`NativeFile` from a `FILE*`. I also added an assert on the `NativeFile`
that validates the file is opened with the correct access mode and
updated `NativeFile::Read` and `NativeFile::Write` to check the access
mode.
Before these changes:
```
$ lldb -b -O 'script lldb.debugger.GetOutputFileHandle().write("abc")'
(lldb) script lldb.debugger.GetOutputFileHandle().write("abc")
Traceback (most recent call last):
File "<input>", line 1, in <module>
io.UnsupportedOperation: not writable
```
After:
```
$ lldb -b -O 'script lldb.debugger.GetOutputFileHandle().write("abc")'
(lldb) script lldb.debugger.GetOutputFileHandle().write("abc")
abc3
```
Fixes #122387
56 lines
1.8 KiB
C++
56 lines
1.8 KiB
C++
//===-- StreamFile.cpp ----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Host/StreamFile.h"
|
|
#include "lldb/Host/FileSystem.h"
|
|
#include "lldb/Utility/LLDBLog.h"
|
|
#include "lldb/Utility/Log.h"
|
|
|
|
#include <cstdio>
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
StreamFile::StreamFile(uint32_t flags, uint32_t addr_size, ByteOrder byte_order)
|
|
: Stream(flags, addr_size, byte_order) {
|
|
m_file_sp = std::make_shared<File>();
|
|
}
|
|
|
|
StreamFile::StreamFile(int fd, bool transfer_ownership) : Stream() {
|
|
m_file_sp = std::make_shared<NativeFile>(fd, File::eOpenOptionWriteOnly,
|
|
transfer_ownership);
|
|
}
|
|
|
|
StreamFile::StreamFile(FILE *fh, bool transfer_ownership) : Stream() {
|
|
m_file_sp = std::make_shared<NativeFile>(fh, File::eOpenOptionWriteOnly,
|
|
transfer_ownership);
|
|
}
|
|
|
|
StreamFile::StreamFile(const char *path, File::OpenOptions options,
|
|
uint32_t permissions)
|
|
: Stream() {
|
|
auto file = FileSystem::Instance().Open(FileSpec(path), options, permissions);
|
|
if (file)
|
|
m_file_sp = std::move(file.get());
|
|
else {
|
|
// TODO refactor this so the error gets popagated up instead of logged here.
|
|
LLDB_LOG_ERROR(GetLog(LLDBLog::Host), file.takeError(),
|
|
"Cannot open {1}: {0}", path);
|
|
m_file_sp = std::make_shared<File>();
|
|
}
|
|
}
|
|
|
|
StreamFile::~StreamFile() = default;
|
|
|
|
void StreamFile::Flush() { m_file_sp->Flush(); }
|
|
|
|
size_t StreamFile::WriteImpl(const void *s, size_t length) {
|
|
m_file_sp->Write(s, length);
|
|
return length;
|
|
}
|