35dfeb7b4d
The instruction selection pass for SPIR-V now performs dead code elimination (DCE). This change removes unused instructions, leading to more optimized SPIR-V output. As a consequence of this, several tests were updated to ensure their continued correctness and to prevent previously tested code from being optimized away. Specifically: - Many tests now store computed values into global variables to ensure they are not eliminated by DCE, allowing their code generation to be verified. - The test `keep-tracked-const.ll` was removed because it no longer tested its original intent. The check statements in this test were for constants generated when expanding a G_TRUNC instruction, which is now removed by DCE instead of being expanded. - A new test, `remove-dead-type-intrinsics.ll`, was added to confirm that dead struct types are correctly removed by the compiler. These updates improve the SPIR-V backends optimization capabilities and maintain the robustness of the test suite. --------- Co-authored-by: Nathan Gauër <github@keenuts.net>
73 lines
2.1 KiB
LLVM
73 lines
2.1 KiB
LLVM
; The goal of the test is to check that internal intrinsic functions for PHI's
|
|
; operand are inserted at the correct positions, and don't break rules of
|
|
; instruction domination and PHI nodes grouping at top of basic block.
|
|
|
|
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-DAG: OpName %[[#Foo:]] "foo"
|
|
; CHECK-DAG: OpName %[[#Bar:]] "bar"
|
|
; CHECK: %[[#Foo]] = OpFunction
|
|
; CHECK: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK: %[[#Bar]] = OpFunction
|
|
; CHECK: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
; CHECK-NEXT: OpPhi
|
|
|
|
%struct = type { i64, i64 }
|
|
|
|
define spir_kernel void @foo(i64 %arg_val, ptr addrspace(4) byval(%struct) %arg_ptr) {
|
|
entry:
|
|
%fl = icmp eq i64 %arg_val, 0
|
|
br i1 %fl, label %ok, label %err
|
|
|
|
err:
|
|
br label %ok
|
|
|
|
ok:
|
|
%r1 = phi i64 [ undef, %err ], [ %arg_val, %entry ]
|
|
%r2 = phi i64 [ undef, %err ], [ %arg_val, %entry ]
|
|
%r3 = phi ptr addrspace(4) [ undef, %err ], [ %arg_ptr, %entry ]
|
|
%r4 = phi ptr addrspace(4) [ undef, %err ], [ %arg_ptr, %entry ]
|
|
br label %exit
|
|
|
|
exit:
|
|
store i64 %r1, ptr @g1
|
|
store i64 %r2, ptr @g2
|
|
store ptr addrspace(4) %r3, ptr @g3
|
|
store ptr addrspace(4) %r4, ptr @g4
|
|
ret void
|
|
}
|
|
|
|
@g1 = internal global i64 0
|
|
@g2 = internal global i64 0
|
|
@g3 = internal global ptr addrspace(4) null
|
|
@g4 = internal global ptr addrspace(4) null
|
|
|
|
define spir_kernel void @bar(i64 %arg_val, i64 %arg_val_def, ptr addrspace(4) byval(%struct) %arg_ptr, ptr addrspace(4) %arg_ptr_def) {
|
|
entry:
|
|
%fl = icmp eq i64 %arg_val, 0
|
|
br i1 %fl, label %ok, label %err
|
|
|
|
err:
|
|
br label %ok
|
|
|
|
ok:
|
|
%r1 = phi i64 [ %arg_val_def, %err ], [ %arg_val, %entry ]
|
|
%r2 = phi i64 [ %arg_val_def, %err ], [ %arg_val, %entry ]
|
|
%r3 = phi ptr addrspace(4) [ %arg_ptr_def, %err ], [ %arg_ptr, %entry ]
|
|
%r4 = phi ptr addrspace(4) [ %arg_ptr_def, %err ], [ %arg_ptr, %entry ]
|
|
br label %exit
|
|
|
|
exit:
|
|
store i64 %r1, ptr @g1
|
|
store i64 %r2, ptr @g2
|
|
store ptr addrspace(4) %r3, ptr @g3
|
|
store ptr addrspace(4) %r4, ptr @g4
|
|
ret void
|
|
}
|