llvm-project/mlir/lib/Dialect/LLVMIR/IR/LLVMDialectBytecode.cpp
Bruno Cardoso Lopes 34c0a5f1b4
[MLIR][LLVM] Add bytecode support for several attributes (#162577)
For a total of 20 attributes, 18 debug information related + 2 regular
ones (loop and alias_scope).

Quick background on how this work: if a given attribute isn't supported,
by default its textual form is dumped into the bytecode. In order to get
proper encoding, an attribute needs a tablegen description of it and its
element. There's an additional rule here: if an attribute is only used
by another attribute, it's user need also to have an encoding in order
for it to be encoded. (e.g. `DICompileUnitAttr` only gets encoded while
in `DISubprogramAttr` if the later also has an encoded form), otherwise
text is used. For this reason, this PR does a bunch at the same time,
otherwise there isn't really much to test (easy to break it down if
needed though).

The PR is tested against some of our internal apps, successfully
round-tripping around 14Gb of llvm dialect text. Some interesting
findings include a 800K mlir textual file that used to become 1.2G in
bytecode format - now down to 100K due to proper encoding of debug info
attributes.

In the future we should find a way to merge this together in the
attribute definitions (perhaps autogenerate the entries from LLVM
attribute descriptions), seems like we can benefit from the boilerplate.
It's not clear yet how to solve some of the tablegen issues; some fields
require manual translation of flag values using `LocalVar`, others
require custom getters, etc. Ideas on that front are welcome.

A next natural step here is to add type support, LLVM structs can also
lead to non-neglible disk footprint.
2025-10-13 11:10:59 -07:00

155 lines
5.2 KiB
C++

//===- LLVMDialectBytecode.cpp - LLVM Bytecode Implementation -------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "LLVMDialectBytecode.h"
#include "mlir/Bytecode/BytecodeImplementation.h"
#include "mlir/Dialect/LLVMIR/LLVMAttrs.h"
#include "mlir/Dialect/LLVMIR/LLVMDialect.h"
#include "mlir/Dialect/LLVMIR/LLVMTypes.h"
#include "mlir/IR/Diagnostics.h"
#include "llvm/ADT/APFloat.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/TypeSwitch.h"
#include <type_traits>
using namespace mlir;
using namespace mlir::LLVM;
namespace {
// Provide some forward declarations of the functions that will be generated by
// the include below.
static void write(DIExpressionElemAttr attribute,
DialectBytecodeWriter &writer);
static LogicalResult writeAttribute(Attribute attribute,
DialectBytecodeWriter &writer);
//===--------------------------------------------------------------------===//
// Optional ArrayRefs
//
// Note that both the writer and reader functions consider attributes to be
// optional. This is because the attribute may be present or empty.
//===--------------------------------------------------------------------===//
template <class EntryTy>
static void writeOptionalArrayRef(DialectBytecodeWriter &writer,
ArrayRef<EntryTy> storage) {
if (storage.empty()) {
writer.writeOwnedBool(false);
return;
}
writer.writeOwnedBool(true);
writer.writeList(storage, [&](EntryTy val) {
if constexpr (std::is_base_of_v<Attribute, EntryTy>) {
(void)writer.writeOptionalAttribute(val);
} else if constexpr (std::is_integral_v<EntryTy>) {
(void)writer.writeVarInt(val);
} else {
static_assert(true, "EntryTy not supported");
}
});
}
template <class EntryTy>
static LogicalResult readOptionalArrayRef(DialectBytecodeReader &reader,
SmallVectorImpl<EntryTy> &storage) {
bool isPresent = false;
if (failed(reader.readBool(isPresent)))
return failure();
// Nothing to do here, the array is empty.
if (!isPresent)
return success();
auto readEntry = [&]() -> FailureOr<EntryTy> {
EntryTy temp;
if constexpr (std::is_base_of_v<Attribute, EntryTy>) {
if (succeeded(reader.readOptionalAttribute(temp)))
return temp;
} else if constexpr (std::is_integral_v<EntryTy>) {
if (succeeded(reader.readVarInt(temp)))
return temp;
} else {
static_assert(true, "EntryTy not supported");
}
return failure();
};
return reader.readList(storage, readEntry);
}
//===--------------------------------------------------------------------===//
// Optional integral types
//===--------------------------------------------------------------------===//
template <class EntryTy>
static void writeOptionalInt(DialectBytecodeWriter &writer,
std::optional<EntryTy> storage) {
static_assert(std::is_integral_v<EntryTy>,
"EntryTy must be an integral type");
EntryTy val = storage.value_or(0);
writer.writeVarIntWithFlag(val, storage.has_value());
}
template <class EntryTy>
static LogicalResult readOptionalInt(DialectBytecodeReader &reader,
std::optional<EntryTy> &storage) {
static_assert(std::is_integral_v<EntryTy>,
"EntryTy must be an integral type");
uint64_t result = 0;
bool flag = false;
if (failed(reader.readVarIntWithFlag(result, flag)))
return failure();
if (flag)
storage = static_cast<EntryTy>(result);
else
storage = std::nullopt;
return success();
}
//===--------------------------------------------------------------------===//
// Tablegen generated bytecode functions
//===--------------------------------------------------------------------===//
#include "mlir/Dialect/LLVMIR/LLVMDialectBytecode.cpp.inc"
//===--------------------------------------------------------------------===//
// LLVMDialectBytecodeInterface
//===--------------------------------------------------------------------===//
/// This class implements the bytecode interface for the LLVM dialect.
struct LLVMDialectBytecodeInterface : public BytecodeDialectInterface {
LLVMDialectBytecodeInterface(Dialect *dialect)
: BytecodeDialectInterface(dialect) {}
// Attributes
Attribute readAttribute(DialectBytecodeReader &reader) const override {
return ::readAttribute(getContext(), reader);
}
LogicalResult writeAttribute(Attribute attr,
DialectBytecodeWriter &writer) const override {
return ::writeAttribute(attr, writer);
}
// Types
Type readType(DialectBytecodeReader &reader) const override {
return ::readType(getContext(), reader);
}
LogicalResult writeType(Type type,
DialectBytecodeWriter &writer) const override {
return ::writeType(type, writer);
}
};
} // namespace
void LLVM::detail::addBytecodeInterface(LLVMDialect *dialect) {
dialect->addInterfaces<LLVMDialectBytecodeInterface>();
}